From: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: acme@kernel.org, peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org,
Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Subject: Re: [PATCH 2/2] perf probe: Remove stale func add_perf_probe_events
Date: Wed, 8 Mar 2017 15:28:08 +0530 [thread overview]
Message-ID: <58BFD5B0.2000103@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170308104308.343460a35e17003b731f3760@kernel.org>
Thanks Masami for the review,
On Wednesday 08 March 2017 03:13 PM, Masami Hiramatsu wrote:
> On Wed, 8 Mar 2017 12:29:08 +0530
> Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> wrote:
>
>> I don't see any user of this function. This function was being copied
>> to tools/perf/builtin-probe.c by commit b02137cc6550 ("perf probe: Move
>> print logic into cmd_probe()"). Since then it has became stale.
> Hmm, I have intended to keep it as an library API, which allows
> user to add event silently (e.g. adding sdt event in background).
Makes sense. Dropping it.
-Ravi
next prev parent reply other threads:[~2017-03-08 13:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 6:59 [PATCH 1/2] perf probe: Fix concat_probe_trace_events Ravi Bangoria
2017-03-08 6:59 ` [PATCH 2/2] perf probe: Remove stale func add_perf_probe_events Ravi Bangoria
2017-03-08 9:43 ` Masami Hiramatsu
2017-03-08 9:58 ` Ravi Bangoria [this message]
2017-03-08 8:37 ` [PATCH 1/2] perf probe: Fix concat_probe_trace_events Masami Hiramatsu
2017-03-20 9:33 ` Ravi Bangoria
2017-03-20 13:39 ` Arnaldo Carvalho de Melo
2017-03-21 6:53 ` [tip:perf/core] " tip-bot for Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58BFD5B0.2000103@linux.vnet.ibm.com \
--to=ravi.bangoria@linux.vnet.ibm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.