From mboxrd@z Thu Jan 1 00:00:00 1970 From: kishon@ti.com (Kishon Vijay Abraham I) Date: Wed, 8 Mar 2017 17:56:55 +0530 Subject: [PATCH for-4.11 1/2] Revert "phy: Add USB3 PHY support for Broadcom NSP SoC" In-Reply-To: References: <20170208233023.31922-1-zajec5@gmail.com> <82b47a03-c41b-378b-2d7c-f263eff514a9@gmail.com> <1b66f9ab3a9efd1bd0817a114e5b9ec9@milecki.pl> <06b6461c-9f43-3482-352f-374490056e90@gmail.com> Message-ID: <58BFF88F.8080008@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Rafal, On Wednesday 08 March 2017 05:43 PM, Rafa? Mi?ecki wrote: > On 10 February 2017 at 01:27, Jon Mason wrote: >> On Thu, Feb 9, 2017 at 2:18 PM, Florian Fainelli >> wrote: >>> >>> On 02/08/2017 11:21 PM, Rafa? Mi?ecki wrote: >>>> On 2017-02-09 00:44, Florian Fainelli wrote: >>>>> On 02/08/2017 03:39 PM, Rafa? Mi?ecki wrote: >>>>>> On 2017-02-09 00:32, Florian Fainelli wrote: >>>>>>> On 02/08/2017 03:30 PM, Rafa? Mi?ecki wrote: >>>>>>>> From: Rafa? Mi?ecki >>>>>>>> >>>>>>>> This reverts commit d7bc1a7d41bf ("phy: Add USB3 PHY support for >>>>>>>> Broadcom NSP SoC") as we already have driver for this PHY (shared >>>>>>>> by NS >>>>>>>> and NSP). It was added in commit e5666281d9ea ("phy: bcm-ns-usb3: >>>>>>>> new >>>>>>>> driver for USB 3.0 PHY on Northstar"). >>>>>>>> >>>>>>>> Instead of adding separated driver & duplicating code we should >>>>>>>> work on >>>>>>>> improving existing (old) one. Thanks to work done by Broadcom we >>>>>>>> know >>>>>>>> there is MDIO bus we weren't aware of & we know register names which >>>>>>>> makes initialization more clear. This is very valuable info and we >>>>>>>> should work on using it in existing driver afterwards. >>>>>>> >>>>>>> Should not we first extend the old driver to support NSP and then >>>>>>> revert >>>>>>> d7bc1a7d41bf ("phy: Add USB3 PHY support for Broadcom NSP SoC")? >>>>>> >>>>>> Sounds like a weird / dirty development method to me: adding >>>>>> duplicated >>>>>> code >>>>>> first then working on cleaning it. Unless you mean drivers/staging/. >>>>> >>>>> There was clearly a mistake in submitting this NSP USB PHY driver, and >>>>> it should have been a patch against the existing NS USB PHY driver, but >>>>> it was not, okay fair enough. >>>>> >>>>> It's one thing to address that in the future, and it's another thing to >>>>> flat out revert the driver just because you don't like the duplication. >>>>> >>>>> I don't like that either, and we can discuss on how to improve things >>>>> (like have the maintainer review that too), but duplication is a lesser >>>>> evil than not having the hardware supported at all, and even more so, >>>>> purposely reverting in the name of removing that duplication, that's >>>>> intentionally breaking working hardware! >>>> >>>> Hardware support is not excuse and I don't think it ever was in the >>>> Linux. >>>> >>>> We don't accept badly designed drivers just because they provide new hw >>>> support. >>>> We have various standards (for quality, style, design, code) at kernel >>>> and we >>>> stick to them unless it's drivers/staging/. As you said this driver >>>> shouldn't be >>>> pushed in the first place. >>>> >>>> Dropping hardware support in kernel happens. Sometimes it's about >>>> ancient >>>> devices, sometimes about code quality (some forgotten staging drivers >>>> used to be >>>> dropped AFAIK). >>>> >>>> Additionally you're talking about support that was *just* added and >>>> isn't used >>>> by anyone in the wild world yet. >>> >>> Except people working on it at Broadcom, but fair enough. >>> >>>> >>>> This hardware was missing upstream support for 4 years so 2 extra months >>>> won't >>>> really hurt anyone. >>>> >>>> I really don't see excusee or need for keeping this driver. >>>> >>>> If you want to (and you feel it's well designed), we can keep >>>> brcm,nsp-usb3-phy.txt >>> >>> No it's fine, let's drop it all and replace it with whatever you and Jon >>> come up with next. >>> >>>> >>>> I vote for focusing on existing driver improvements instead of looking >>>> for >>>> excuses for keeping driver that shouldn't be added in the first place. >>>> Jon seems to be already working on this, I'm willing to help him, I'm >>>> sure we >>>> can get you a proper support for the next merge window. >>> >>> Fair enough, I dropped Dhanajay's changes ("ARM: dts: NSP: Add USB nodes >>> for Northstar Plus") from devicetree/next so you and Jon can figure out >>> what is the best thing to move forward and we minimize the amount of >>> incompatible DT stuff to be sorted out later on. So as far as I am >>> concerned, there are no board/SoC DTS changes to be patched later on, we >>> could re-apply this patch as-is, or we could have to define a new binding. >> >> Per the discussion with Rafal, this is acceptable >> >> Acked-by: Jon Mason > > Hi Kishon, what's the status of this? Will be merging this in a day or so. Thanks Kishon From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Subject: Re: [PATCH for-4.11 1/2] Revert "phy: Add USB3 PHY support for Broadcom NSP SoC" Date: Wed, 8 Mar 2017 17:56:55 +0530 Message-ID: <58BFF88F.8080008@ti.com> References: <20170208233023.31922-1-zajec5@gmail.com> <82b47a03-c41b-378b-2d7c-f263eff514a9@gmail.com> <1b66f9ab3a9efd1bd0817a114e5b9ec9@milecki.pl> <06b6461c-9f43-3482-352f-374490056e90@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Jon Mason Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Florian Fainelli , Scott Branden , Jon Mason , Ray Jui , Yendapally Reddy Dhananjaya Reddy , Rob Herring , BCM Kernel Feedback , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , linux-arm-kernel List-Id: devicetree@vger.kernel.org SGkgUmFmYWwsCgpPbiBXZWRuZXNkYXkgMDggTWFyY2ggMjAxNyAwNTo0MyBQTSwgUmFmYcWCIE1p xYJlY2tpIHdyb3RlOgo+IE9uIDEwIEZlYnJ1YXJ5IDIwMTcgYXQgMDE6MjcsIEpvbiBNYXNvbiA8 am9uLm1hc29uQGJyb2FkY29tLmNvbT4gd3JvdGU6Cj4+IE9uIFRodSwgRmViIDksIDIwMTcgYXQg MjoxOCBQTSwgRmxvcmlhbiBGYWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+Cj4+IHdyb3Rl Ogo+Pj4KPj4+IE9uIDAyLzA4LzIwMTcgMTE6MjEgUE0sIFJhZmHFgiBNacWCZWNraSB3cm90ZToK Pj4+PiBPbiAyMDE3LTAyLTA5IDAwOjQ0LCBGbG9yaWFuIEZhaW5lbGxpIHdyb3RlOgo+Pj4+PiBP biAwMi8wOC8yMDE3IDAzOjM5IFBNLCBSYWZhxYIgTWnFgmVja2kgd3JvdGU6Cj4+Pj4+PiBPbiAy MDE3LTAyLTA5IDAwOjMyLCBGbG9yaWFuIEZhaW5lbGxpIHdyb3RlOgo+Pj4+Pj4+IE9uIDAyLzA4 LzIwMTcgMDM6MzAgUE0sIFJhZmHFgiBNacWCZWNraSB3cm90ZToKPj4+Pj4+Pj4gRnJvbTogUmFm YcWCIE1pxYJlY2tpIDxyYWZhbEBtaWxlY2tpLnBsPgo+Pj4+Pj4+Pgo+Pj4+Pj4+PiBUaGlzIHJl dmVydHMgY29tbWl0IGQ3YmMxYTdkNDFiZiAoInBoeTogQWRkIFVTQjMgUEhZIHN1cHBvcnQgZm9y Cj4+Pj4+Pj4+IEJyb2FkY29tIE5TUCBTb0MiKSBhcyB3ZSBhbHJlYWR5IGhhdmUgZHJpdmVyIGZv ciB0aGlzIFBIWSAoc2hhcmVkCj4+Pj4+Pj4+IGJ5IE5TCj4+Pj4+Pj4+IGFuZCBOU1ApLiBJdCB3 YXMgYWRkZWQgaW4gY29tbWl0IGU1NjY2MjgxZDllYSAoInBoeTogYmNtLW5zLXVzYjM6Cj4+Pj4+ Pj4+IG5ldwo+Pj4+Pj4+PiBkcml2ZXIgZm9yIFVTQiAzLjAgUEhZIG9uIE5vcnRoc3RhciIpLgo+ Pj4+Pj4+Pgo+Pj4+Pj4+PiBJbnN0ZWFkIG9mIGFkZGluZyBzZXBhcmF0ZWQgZHJpdmVyICYgZHVw bGljYXRpbmcgY29kZSB3ZSBzaG91bGQKPj4+Pj4+Pj4gd29yayBvbgo+Pj4+Pj4+PiBpbXByb3Zp bmcgZXhpc3RpbmcgKG9sZCkgb25lLiBUaGFua3MgdG8gd29yayBkb25lIGJ5IEJyb2FkY29tIHdl Cj4+Pj4+Pj4+IGtub3cKPj4+Pj4+Pj4gdGhlcmUgaXMgTURJTyBidXMgd2Ugd2VyZW4ndCBhd2Fy ZSBvZiAmIHdlIGtub3cgcmVnaXN0ZXIgbmFtZXMgd2hpY2gKPj4+Pj4+Pj4gbWFrZXMgaW5pdGlh bGl6YXRpb24gbW9yZSBjbGVhci4gVGhpcyBpcyB2ZXJ5IHZhbHVhYmxlIGluZm8gYW5kIHdlCj4+ Pj4+Pj4+IHNob3VsZCB3b3JrIG9uIHVzaW5nIGl0IGluIGV4aXN0aW5nIGRyaXZlciBhZnRlcndh cmRzLgo+Pj4+Pj4+Cj4+Pj4+Pj4gU2hvdWxkIG5vdCB3ZSBmaXJzdCBleHRlbmQgdGhlIG9sZCBk cml2ZXIgdG8gc3VwcG9ydCBOU1AgYW5kIHRoZW4KPj4+Pj4+PiByZXZlcnQKPj4+Pj4+PiBkN2Jj MWE3ZDQxYmYgKCJwaHk6IEFkZCBVU0IzIFBIWSBzdXBwb3J0IGZvciBCcm9hZGNvbSBOU1AgU29D Iik/Cj4+Pj4+Pgo+Pj4+Pj4gU291bmRzIGxpa2UgYSB3ZWlyZCAvIGRpcnR5IGRldmVsb3BtZW50 IG1ldGhvZCB0byBtZTogYWRkaW5nCj4+Pj4+PiBkdXBsaWNhdGVkCj4+Pj4+PiBjb2RlCj4+Pj4+ PiBmaXJzdCB0aGVuIHdvcmtpbmcgb24gY2xlYW5pbmcgaXQuIFVubGVzcyB5b3UgbWVhbiBkcml2 ZXJzL3N0YWdpbmcvLgo+Pj4+Pgo+Pj4+PiBUaGVyZSB3YXMgY2xlYXJseSBhIG1pc3Rha2UgaW4g c3VibWl0dGluZyB0aGlzIE5TUCBVU0IgUEhZIGRyaXZlciwgYW5kCj4+Pj4+IGl0IHNob3VsZCBo YXZlIGJlZW4gYSBwYXRjaCBhZ2FpbnN0IHRoZSBleGlzdGluZyBOUyBVU0IgUEhZIGRyaXZlciwg YnV0Cj4+Pj4+IGl0IHdhcyBub3QsIG9rYXkgZmFpciBlbm91Z2guCj4+Pj4+Cj4+Pj4+IEl0J3Mg b25lIHRoaW5nIHRvIGFkZHJlc3MgdGhhdCBpbiB0aGUgZnV0dXJlLCBhbmQgaXQncyBhbm90aGVy IHRoaW5nIHRvCj4+Pj4+IGZsYXQgb3V0IHJldmVydCB0aGUgZHJpdmVyIGp1c3QgYmVjYXVzZSB5 b3UgZG9uJ3QgbGlrZSB0aGUgZHVwbGljYXRpb24uCj4+Pj4+Cj4+Pj4+IEkgZG9uJ3QgbGlrZSB0 aGF0IGVpdGhlciwgYW5kIHdlIGNhbiBkaXNjdXNzIG9uIGhvdyB0byBpbXByb3ZlIHRoaW5ncwo+ Pj4+PiAobGlrZSBoYXZlIHRoZSBtYWludGFpbmVyIHJldmlldyB0aGF0IHRvbyksIGJ1dCBkdXBs aWNhdGlvbiBpcyBhIGxlc3Nlcgo+Pj4+PiBldmlsIHRoYW4gbm90IGhhdmluZyB0aGUgaGFyZHdh cmUgc3VwcG9ydGVkIGF0IGFsbCwgYW5kIGV2ZW4gbW9yZSBzbywKPj4+Pj4gcHVycG9zZWx5IHJl dmVydGluZyBpbiB0aGUgbmFtZSBvZiByZW1vdmluZyB0aGF0IGR1cGxpY2F0aW9uLCB0aGF0J3MK Pj4+Pj4gaW50ZW50aW9uYWxseSBicmVha2luZyB3b3JraW5nIGhhcmR3YXJlIQo+Pj4+Cj4+Pj4g SGFyZHdhcmUgc3VwcG9ydCBpcyBub3QgZXhjdXNlIGFuZCBJIGRvbid0IHRoaW5rIGl0IGV2ZXIg d2FzIGluIHRoZQo+Pj4+IExpbnV4Lgo+Pj4+Cj4+Pj4gV2UgZG9uJ3QgYWNjZXB0IGJhZGx5IGRl c2lnbmVkIGRyaXZlcnMganVzdCBiZWNhdXNlIHRoZXkgcHJvdmlkZSBuZXcgaHcKPj4+PiBzdXBw b3J0Lgo+Pj4+IFdlIGhhdmUgdmFyaW91cyBzdGFuZGFyZHMgKGZvciBxdWFsaXR5LCBzdHlsZSwg ZGVzaWduLCBjb2RlKSBhdCBrZXJuZWwKPj4+PiBhbmQgd2UKPj4+PiBzdGljayB0byB0aGVtIHVu bGVzcyBpdCdzIGRyaXZlcnMvc3RhZ2luZy8uIEFzIHlvdSBzYWlkIHRoaXMgZHJpdmVyCj4+Pj4g c2hvdWxkbid0IGJlCj4+Pj4gcHVzaGVkIGluIHRoZSBmaXJzdCBwbGFjZS4KPj4+Pgo+Pj4+IERy b3BwaW5nIGhhcmR3YXJlIHN1cHBvcnQgaW4ga2VybmVsIGhhcHBlbnMuIFNvbWV0aW1lcyBpdCdz IGFib3V0Cj4+Pj4gYW5jaWVudAo+Pj4+IGRldmljZXMsIHNvbWV0aW1lcyBhYm91dCBjb2RlIHF1 YWxpdHkgKHNvbWUgZm9yZ290dGVuIHN0YWdpbmcgZHJpdmVycwo+Pj4+IHVzZWQgdG8gYmUKPj4+ PiBkcm9wcGVkIEFGQUlLKS4KPj4+Pgo+Pj4+IEFkZGl0aW9uYWxseSB5b3UncmUgdGFsa2luZyBh Ym91dCBzdXBwb3J0IHRoYXQgd2FzICpqdXN0KiBhZGRlZCBhbmQKPj4+PiBpc24ndCB1c2VkCj4+ Pj4gYnkgYW55b25lIGluIHRoZSB3aWxkIHdvcmxkIHlldC4KPj4+Cj4+PiBFeGNlcHQgcGVvcGxl IHdvcmtpbmcgb24gaXQgYXQgQnJvYWRjb20sIGJ1dCBmYWlyIGVub3VnaC4KPj4+Cj4+Pj4KPj4+ PiBUaGlzIGhhcmR3YXJlIHdhcyBtaXNzaW5nIHVwc3RyZWFtIHN1cHBvcnQgZm9yIDQgeWVhcnMg c28gMiBleHRyYSBtb250aHMKPj4+PiB3b24ndAo+Pj4+IHJlYWxseSBodXJ0IGFueW9uZS4KPj4+ Pgo+Pj4+IEkgcmVhbGx5IGRvbid0IHNlZSBleGN1c2VlIG9yIG5lZWQgZm9yIGtlZXBpbmcgdGhp cyBkcml2ZXIuCj4+Pj4KPj4+PiBJZiB5b3Ugd2FudCB0byAoYW5kIHlvdSBmZWVsIGl0J3Mgd2Vs bCBkZXNpZ25lZCksIHdlIGNhbiBrZWVwCj4+Pj4gYnJjbSxuc3AtdXNiMy1waHkudHh0Cj4+Pgo+ Pj4gTm8gaXQncyBmaW5lLCBsZXQncyBkcm9wIGl0IGFsbCBhbmQgcmVwbGFjZSBpdCB3aXRoIHdo YXRldmVyIHlvdSBhbmQgSm9uCj4+PiBjb21lIHVwIHdpdGggbmV4dC4KPj4+Cj4+Pj4KPj4+PiBJ IHZvdGUgZm9yIGZvY3VzaW5nIG9uIGV4aXN0aW5nIGRyaXZlciBpbXByb3ZlbWVudHMgaW5zdGVh ZCBvZiBsb29raW5nCj4+Pj4gZm9yCj4+Pj4gZXhjdXNlcyBmb3Iga2VlcGluZyBkcml2ZXIgdGhh dCBzaG91bGRuJ3QgYmUgYWRkZWQgaW4gdGhlIGZpcnN0IHBsYWNlLgo+Pj4+IEpvbiBzZWVtcyB0 byBiZSBhbHJlYWR5IHdvcmtpbmcgb24gdGhpcywgSSdtIHdpbGxpbmcgdG8gaGVscCBoaW0sIEkn bQo+Pj4+IHN1cmUgd2UKPj4+PiBjYW4gZ2V0IHlvdSBhIHByb3BlciBzdXBwb3J0IGZvciB0aGUg bmV4dCBtZXJnZSB3aW5kb3cuCj4+Pgo+Pj4gRmFpciBlbm91Z2gsIEkgZHJvcHBlZCBEaGFuYWph eSdzIGNoYW5nZXMgKCJBUk06IGR0czogTlNQOiBBZGQgVVNCIG5vZGVzCj4+PiBmb3IgTm9ydGhz dGFyIFBsdXMiKSBmcm9tIGRldmljZXRyZWUvbmV4dCBzbyB5b3UgYW5kIEpvbiBjYW4gZmlndXJl IG91dAo+Pj4gd2hhdCBpcyB0aGUgYmVzdCB0aGluZyB0byBtb3ZlIGZvcndhcmQgYW5kIHdlIG1p bmltaXplIHRoZSBhbW91bnQgb2YKPj4+IGluY29tcGF0aWJsZSBEVCBzdHVmZiB0byBiZSBzb3J0 ZWQgb3V0IGxhdGVyIG9uLiBTbyBhcyBmYXIgYXMgSSBhbQo+Pj4gY29uY2VybmVkLCB0aGVyZSBh cmUgbm8gYm9hcmQvU29DIERUUyBjaGFuZ2VzIHRvIGJlIHBhdGNoZWQgbGF0ZXIgb24sIHdlCj4+ PiBjb3VsZCByZS1hcHBseSB0aGlzIHBhdGNoIGFzLWlzLCBvciB3ZSBjb3VsZCBoYXZlIHRvIGRl ZmluZSBhIG5ldyBiaW5kaW5nLgo+Pgo+PiBQZXIgdGhlIGRpc2N1c3Npb24gd2l0aCBSYWZhbCwg dGhpcyBpcyBhY2NlcHRhYmxlCj4+Cj4+IEFja2VkLWJ5OiBKb24gTWFzb24gPGpvbi5tYXNvbkBi cm9hZGNvbS5jb20+Cj4gCj4gSGkgS2lzaG9uLCB3aGF0J3MgdGhlIHN0YXR1cyBvZiB0aGlzPwoK V2lsbCBiZSBtZXJnaW5nIHRoaXMgaW4gYSBkYXkgb3Igc28uCgpUaGFua3MKS2lzaG9uCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2Vy bmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs Cg==