From: Jason Yan <yanaijie@huawei.com>
To: Jens Axboe <axboe@kernel.dk>, <linux-block@vger.kernel.org>
Cc: <miaoxie@huawei.com>, <zhaohongjiang@huawei.com>
Subject: Re: [PATCH] brd: make rd_size static
Date: Mon, 13 Mar 2017 08:56:49 +0800 [thread overview]
Message-ID: <58C5EE51.4000703@huawei.com> (raw)
In-Reply-To: <4dd2367b-61b9-d390-5bb1-955e90fef0b0@kernel.dk>
On 2017/3/12 6:29, Jens Axboe wrote:
> On 03/10/2017 12:32 AM, Jason Yan wrote:
>> Fixes the following sparse warning:
>>
>> drivers/block/brd.c:411:15: warning: symbol 'rd_size' was not declared.
>> Should it be static?
>
> If you do a search on this topic, you'll find others that attempted
> to do the same. Arm uses it for tag parsing, for some reason, your
> patch below would break it.
>
> It'd be great if this was fixed up for real, though.
>
how about fix this like this, looks ugly but works:
#ifndef CONFIG_ARM
static
#endif
next prev parent reply other threads:[~2017-03-13 0:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-10 7:32 [PATCH] brd: make rd_size static Jason Yan
2017-03-11 22:29 ` Jens Axboe
2017-03-13 0:56 ` Jason Yan [this message]
2017-03-13 2:56 ` Jens Axboe
2017-03-13 20:07 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58C5EE51.4000703@huawei.com \
--to=yanaijie@huawei.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=zhaohongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.