From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751964AbdCMKal (ORCPT ); Mon, 13 Mar 2017 06:30:41 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:43287 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751490AbdCMKac (ORCPT ); Mon, 13 Mar 2017 06:30:32 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: b6c32a38-f79f06d000001a72-17-58c674c07eab Content-transfer-encoding: 8BIT Message-id: <58C674C0.3010001@samsung.com> Date: Mon, 13 Mar 2017 19:30:24 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Hans de Goede , MyungJoo Ham , Chen-Yu Tsai Cc: linux-kernel@vger.kernel.org, Andy Shevchenko Subject: Re: [PATCH v2] extcon: int3496: Set the id pin to direction-input if necessary In-reply-to: <20170313084003.14416-1-hdegoede@redhat.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpjk+LIzCtJLcpLzFFi42LZdlhTX/dAybEIg9nnLSx6m6YzWbw5DiQu 75rDZnG7cQWbxc9D55kcWD02PFrN6jHvZKDH+31X2Tz6tqxi9Pi8SS6ANSrVJiM1MSW1SCE1 Lzk/JTMv3VbJOzjeOd7UzMBQ19DSwlxJIS8xN9VWycUnQNctMwdot5JCWWJOKVAoILG4WEnf zqYov7QkVSEjv7jEVina0NBIz9DAXM/IyEjPxDjWysgUqCQhNWPB7otsBesFKz7szmtg7ODr YuTkkBAwkZh1agsrhC0mceHeerYuRi4OIYEdjBKfnvxhgXDamSRmbz/L3sXIAdZx9psnSIOQ wBxGia6F4iA2r4CgxI/J91hASpgF5CWOXMoGCTMLaEps3b2eHWLMPUaJK/OvM0HUa0mc6J7L CGKzCKhKXO6awAZiswHF97+4AWbzCyhKXP3xGKxGVCBCYuf8b+wgtohAgUTjj21sEAvCJV4+ 28IMYgsLREq0fvsIZnMKWErsv3qXCWSxhMAidonj1z4wQtwvK7HpADPEwy4SW9oXMELYwhKv jm9hh7ClJVb9uwXV284osXnOPRYIp4NR4v7KRmhwGUvcf3CPGeIKPol3X3tYIRbwSnS0CUGU eEjMWrYFapmjxJbXPxkhIdHDKNF37x3jBEaFWUiBNwsReLOQAm8BI/MqRrHUguLc9NRiwwIT veLE3OLSvHS95PzcTYzgNKhlsYNxzzmfQ4wCHIxKPLwbZh2NEGJNLCuuzD3EKMHBrCTCe7rw WIQQb0piZVVqUX58UWlOavEhRlNg2E9klhJNzgem6LySeEMTM0MTIxNDQ3MjAyMlcV5Wg4kR QgLpiSWp2ampBalFMH1MHJxSDYzLJii3X3CqX2josXMhh1uosXaay3TV+xPfTvhWNuX41kdW Ug8PbhRYULHlGlNuy6Wi6bfFJeOYjj05ne7ZLv9AzP/DZMuT32ff7V/YzfDtQZJcsmuBevjr p5nnJ7/8WLwvvpGndNo9hWlXjpm7GE3sufD4saKGYOW7T1ouikWy+f3HAs8+mjNViaU4I9FQ i7moOBEAQzHVCpkDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrIIsWRmVeSWpSXmKPExsVy+t9jQd0DJcciDG4dVrfobZrOZPHmOJC4 vGsOm8XtxhVsFj8PnWdyYPXY8Gg1q8e8k4Ee7/ddZfPo27KK0ePzJrkA1ig3m4zUxJTUIoXU vOT8lMy8dFul0BA3XQslhbzE3FRbpQhd35AgJYWyxJxSIM/IAA04OAe4Byvp2yW4ZSzYfZGt YL1gxYfdeQ2MHXxdjBwcEgImEme/eXYxcgKZYhIX7q1n62Lk4hASmMUosfXDBWaQBK+AoMSP yfdYQOqZBeQljlzKBgkzC6hLTJq3iBmi/gGjxJFj21kh6rUkTnTPZQSxWQRUJS53TWADsdmA 4vtf3ACz+QUUJa7+eMwIMlNUIEKi+0QliCkiUCDR960SYny4xM2Jt8EuEBaIlNh45TcLxKo+ RomD0+6BreIUsJTYf/Uu0wRGwVlILp2FcOksJJcuYGRexSiRWpBcUJyUnmuYl1quV5yYW1ya l66XnJ+7iREcXc+kdjAe3OV+iFGAg1GJh3fDrKMRQqyJZcWVuYcYJTiYlUR4dyYfixDiTUms rEotyo8vKs1JLT7EaAr06kRmKdHkfGDk55XEG5qYm5gbG1iYW1qaGCmJ8zbOfhYuJJCeWJKa nZpakFoE08fEwSnVwOhaN8ef26W/67h+9dwktonCLmxfsnQahdXttU3WdWvaO61d+t7obkFt 1/TNfg0LJ59w2LfeL0HaP7T6luiV/pLmT5dPz1SMt9zRtpBp/vTvE1err+Erq7v38MgDZlHN 0vD7y9Z2HlWcxyYek7Alyy5oU6zw1NuTdA5lhcfPOBHd9+GCoEh6hhJLcUaioRZzUXEiAI1h AOrEAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170313103024epcas1p22b9f80609b7f7f288ce2b59f3d21d018 X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170313084009epcas2p2c9790c6378225f66cc8cacbb82f2ba41 X-RootMTR: 20170313084009epcas2p2c9790c6378225f66cc8cacbb82f2ba41 References: <20170313084003.14416-1-hdegoede@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2017년 03월 13일 17:40, Hans de Goede wrote: > With the new more strict ACPI gpio code the dsdt's IoRestriction > flags are honored on gpiod_get, but in some dsdt's it is wrong, > so explicitly call gpiod_direction_input on the id gpio if > necessary. > > This fixes the following errors when the int3496 code is used > together with the new more strict ACPI gpio code: > > [ 2382.484415] gpio gpiochip1: (INT33FF:01): gpiochip_lock_as_irq: tried to flag a GPIO set as output for IRQ > [ 2382.484425] gpio gpiochip1: (INT33FF:01): unable to lock HW IRQ 3 for IRQ > [ 2382.484429] genirq: Failed to request resources for INT3496:00 (irq 174) on irqchip chv-gpio > [ 2382.484518] intel-int3496 INT3496:00: can't request IRQ for USB ID GPIO: -22 > [ 2382.500359] intel-int3496: probe of INT3496:00 failed with error -22 > > Cc: Andy Shevchenko > Signed-off-by: Hans de Goede > --- > Changes in v2: > -Warn about firmware bug when the dsdt's IoRestriction does not allow input > --- > drivers/extcon/extcon-intel-int3496.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/extcon/extcon-intel-int3496.c b/drivers/extcon/extcon-intel-int3496.c > index b8ac947..18801eb 100644 > --- a/drivers/extcon/extcon-intel-int3496.c > +++ b/drivers/extcon/extcon-intel-int3496.c > @@ -113,6 +113,10 @@ static int int3496_probe(struct platform_device *pdev) > dev_err(dev, "can't request USB ID GPIO: %d\n", ret); > return ret; > } Need to add one blank line at here. > + if (gpiod_get_direction(data->gpio_usb_id) != GPIOF_DIR_IN) { > + dev_warn(dev, "firmware bug USB ID GPIO not in input mode, fixing\n"); The length of warning comment is over 80 char. We need to reduce the length of comment. I modify the comment as following: If you ok, I'll apply it. "ID pin isn't in input mode due to firmware bug" Or if you make new comment under 80 char, please send v3 patch. > + gpiod_direction_input(data->gpio_usb_id); > + } > > data->usb_id_irq = gpiod_to_irq(data->gpio_usb_id); > if (data->usb_id_irq < 0) { > -- Best Regards, Chanwoo Choi Samsung Electronics