From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752705AbdCMLER (ORCPT ); Mon, 13 Mar 2017 07:04:17 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:47565 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752677AbdCMLEI (ORCPT ); Mon, 13 Mar 2017 07:04:08 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: b6c32a2d-f793d6d0000012b6-e8-58c67ca0588f Content-transfer-encoding: 8BIT Message-id: <58C67C9F.7010704@samsung.com> Date: Mon, 13 Mar 2017 20:03:59 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Hans de Goede , MyungJoo Ham , Chen-Yu Tsai Cc: linux-kernel@vger.kernel.org, Andy Shevchenko Subject: Re: [PATCH v2] extcon: int3496: Set the id pin to direction-input if necessary In-reply-to: <5a55cc63-335f-37c3-4a2f-9d2f60d8895b@redhat.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpjk+LIzCtJLcpLzFFi42LZdlhTU3dBzbEIg3uLtS16m6YzWbw5DiQu 75rDZnG7cQWbxc9D55kcWD02PFrN6jHvZKDH+31X2Tz6tqxi9Pi8SS6ANSrVJiM1MSW1SCE1 Lzk/JTMv3VbJOzjeOd7UzMBQ19DSwlxJIS8xN9VWycUnQNctMwdot5JCWWJOKVAoILG4WEnf zqYov7QkVSEjv7jEVina0NBIz9DAXM/IyEjPxDjWysgUqCQhNePgsg7GgnMSFf/m/mRrYLwk 3MXIwSEhYCJxdqpnFyMnkCkmceHeerYuRi4OIYGljBL975YxQTjtTBJ7by5lgqgykViy5h8r RGIOo8Su1zfAErwCghI/Jt9jAZnKLCAvceRSNkiYWUBT4sWXSSwgtpDAPUaJxWclIcq1JPZN bWUGsVkEVCWe/5kHZrMBxfe/uMEGYvMLKEpc/fGYEcQWFYiQ2Dn/GzuILSJQINH4YxsbxPxw iZfPtoD1CgtESrR++whmcwrYSVxv3wX2jYTAMnaJafP7GSE+lpXYdIAZwnSRWLUiFOItYYlX x7ewQ9jSEn+X3mKEaG1nlNg8B+QtEKeDUeL+ykZWiCpjifsP7jFDHMEn0fv7CRPEUF6JjjYh iBIPiVnLIG6TEHCU2PL6JyMk3O4zSlxpX806gVFhFlLQzUIE3SykoFvAyLyKUSy1oDg3PbXY tMBIrzgxt7g0L10vOT93EyM4DWrp7mD8ssD7EKMAB6MSD+8LsWMRQqyJZcWVuYcYJTiYlUR4 jaqBQrwpiZVVqUX58UWlOanFhxhNgUE/kVlKNDkfmKLzSuINTcwMTYwsgdDc0FxJnDfKYGKE kEB6YklqdmpqQWoRTB8TB6dUA6O+TY5PxNU2nrk9+7eq+7/4Xnl/ceT0bqa1dmf5C3quzJqn Pq1pdmj93f0ae7/3sF1/Zrxl0qxHPb95zC+82xcdmbBhV8Q08dtWpwxcNG6yrp2pwhAtH16a GXrhLmfDdt0rfZunudaGHzwVzHyoZs/f3/nOV/6nT8iPjH3/tY/j0AvOPPPjSv1KLMUZiYZa zEXFiQBhN543mQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrIIsWRmVeSWpSXmKPExsVy+t9jQd35NcciDNa8U7PobZrOZPHmOJC4 vGsOm8XtxhVsFj8PnWdyYPXY8Gg1q8e8k4Ee7/ddZfPo27KK0ePzJrkA1ig3m4zUxJTUIoXU vOT8lMy8dFul0BA3XQslhbzE3FRbpQhd35AgJYWyxJxSIM/IAA04OAe4Byvp2yW4ZRxc1sFY cE6i4t/cn2wNjJeEuxg5OSQETCSWrPnHCmGLSVy4t56ti5GLQ0hgFqPExHN72EESvAKCEj8m 32PpYuTgYBaQlzhyKRvCVJeYMiUXovwBo8Ssg6eZIMq1JPZNbWUGsVkEVCWe/5kHZrMBxfe/ uMEGYvMLKEpc/fGYEWSOqECERPeJShBTRKBAou9bJUgFs0C4xM2Jt8E6hQUiJTZe+c0Cseoh o8S6+S/BLuMUsJO43r6LbQKj4Cwkh85COHQWwqELGJlXMUqkFiQXFCel5xrlpZbrFSfmFpfm pesl5+duYgRH1zPpHYyHd7kfYhTgYFTi4Y2YcTRCiDWxrLgy9xCjBAezkgivUfWxCCHelMTK qtSi/Pii0pzU4kOMpkCfTmSWEk3OB0Z+Xkm8oYm5ibmxgYW5paWJkZI4b+PsZ+FCAumJJanZ qakFqUUwfUwcnFINjNJ83rfUDrZ922W+qdLrh7ZVY8SqSYttPkzntHCbqy6vKccSFfFH1On0 hWsclnoZvprlC75sdfg8qelzh+rZKeszkqynuRxYytY2xe283KOYbY9OPb/77krlF77/k/gX n/KWt5fLc8n33PSO2+zK1sxjzya19z+Re3sku23Rpo67Wkcm5HttDVJiKc5INNRiLipOBADw ew01xAIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170313110359epcas5p1ae6c79081b3ad98097c8afc2b8232baa X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170313084009epcas2p2c9790c6378225f66cc8cacbb82f2ba41 X-RootMTR: 20170313084009epcas2p2c9790c6378225f66cc8cacbb82f2ba41 References: <20170313084003.14416-1-hdegoede@redhat.com> <58C674C0.3010001@samsung.com> <5a55cc63-335f-37c3-4a2f-9d2f60d8895b@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017년 03월 13일 19:51, Hans de Goede wrote: > Hi, > > On 13-03-17 11:30, Chanwoo Choi wrote: >> Hi, >> >> On 2017년 03월 13일 17:40, Hans de Goede wrote: >>> With the new more strict ACPI gpio code the dsdt's IoRestriction >>> flags are honored on gpiod_get, but in some dsdt's it is wrong, >>> so explicitly call gpiod_direction_input on the id gpio if >>> necessary. >>> >>> This fixes the following errors when the int3496 code is used >>> together with the new more strict ACPI gpio code: >>> >>> [ 2382.484415] gpio gpiochip1: (INT33FF:01): gpiochip_lock_as_irq: tried to flag a GPIO set as output for IRQ >>> [ 2382.484425] gpio gpiochip1: (INT33FF:01): unable to lock HW IRQ 3 for IRQ >>> [ 2382.484429] genirq: Failed to request resources for INT3496:00 (irq 174) on irqchip chv-gpio >>> [ 2382.484518] intel-int3496 INT3496:00: can't request IRQ for USB ID GPIO: -22 >>> [ 2382.500359] intel-int3496: probe of INT3496:00 failed with error -22 >>> >>> Cc: Andy Shevchenko >>> Signed-off-by: Hans de Goede >>> --- >>> Changes in v2: >>> -Warn about firmware bug when the dsdt's IoRestriction does not allow input >>> --- >>> drivers/extcon/extcon-intel-int3496.c | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/drivers/extcon/extcon-intel-int3496.c b/drivers/extcon/extcon-intel-int3496.c >>> index b8ac947..18801eb 100644 >>> --- a/drivers/extcon/extcon-intel-int3496.c >>> +++ b/drivers/extcon/extcon-intel-int3496.c >>> @@ -113,6 +113,10 @@ static int int3496_probe(struct platform_device *pdev) >>> dev_err(dev, "can't request USB ID GPIO: %d\n", ret); >>> return ret; >>> } >> >> Need to add one blank line at here. > > I grouped it together with the earlier error check since it is still > checking the returned gpiodesc is valid, but if you prefer to add a line > that is fine by me. If you want to group them, you should add it as following: } else if (gpiod_get_direction(data->gpio_usb_id) != GPIOF_DIR_IN) { > >> >>> + if (gpiod_get_direction(data->gpio_usb_id) != GPIOF_DIR_IN) { >>> + dev_warn(dev, "firmware bug USB ID GPIO not in input mode, fixing\n"); >> >> The length of warning comment is over 80 char. > > Which is allowed, try running checkpatch.pl on the patch. log messages may > cross the 80 char limit, to avoid splitting them over multiple lines which > would make grepping for them hard. > >> We need to reduce the length of comment. > > Nope, not needed, as said this is allowed. > >> I modify the comment as following: If you ok, I'll apply it. >> "ID pin isn't in input mode due to firmware bug" > > I prefer my original text which better describes what is happening > and as said before, the text going over the 80 char limit is allowed. Right. The over the 80 char is possible. But, I prefer to write the comment under the 80 char. But if you want to use more detailed comment, I think that you can make your sentence more formal. [snip] -- Best Regards, Chanwoo Choi Samsung Electronics