From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754069AbdCMXYL (ORCPT ); Mon, 13 Mar 2017 19:24:11 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:59345 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751566AbdCMXYC (ORCPT ); Mon, 13 Mar 2017 19:24:02 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: b6c32a59-f79736d000001328-98-58c72a108280 Content-transfer-encoding: 8BIT Message-id: <58C72A0F.2050504@samsung.com> Date: Tue, 14 Mar 2017 08:23:59 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Hans de Goede , MyungJoo Ham , Chen-Yu Tsai Cc: linux-kernel@vger.kernel.org, Andy Shevchenko Subject: Re: [PATCH v3] extcon: int3496: Set the id pin to direction-input if necessary In-reply-to: <20170313112834.11006-1-hdegoede@redhat.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupgk+LIzCtJLcpLzFFi42LZdlhTU1dA63iEwfS1wha9TdOZLN4cBxKX d81hs7jduILN4ueh80wOrB4bHq1m9Zh3MtDj/b6rbB59W1YxenzeJBfAGpVqk5GamJJapJCa l5yfkpmXbqvkHRzvHG9qZmCoa2hpYa6kkJeYm2qr5OIToOuWmQO0W0mhLDGnFCgUkFhcrKRv Z1OUX1qSqpCRX1xiqxRtaGikZ2hgrmdkZKRnYhxrZWQKVJKQmnFl9gWWgutcFQ8upDYwXuDo YuTkkBAwkbi0eDYjhC0mceHeerYuRi4OIYGljBK9r1pYIZx2Jol7M9YywXS8WbMKKjGHUaLt x212kASvgKDEj8n3WLoYOTiYBeQljlzKBgkzC2hKbN29nh2i/h6jxJGO18wQ9VoS5zY/BFvN IqAqsbx7KpjNBhTf/+IGG4jNL6AocfXHY7C4qECExM7538B2iQgUSDT+2MYGsSBc4uWzLWAz hQUiJf5MuA5WzylgKbHx7GMmkMUSAsvYJeZemMEEcpyEgKzEpgPMEM+4SLzofgL1vrDEq+Nb 2CFsaYm/S28xQvS2M0psngPyGIjTwShxf2UjK0SVscT9B/eYIa7gk+j9/QRqAa9ER5sQRImH xOp376Eh5yjx9foBFkhI9DBKPHz8mn0Co8IspMCbhQi8WUiBt4CReRWjWGpBcW56arFpgale cWJucWleul5yfu4mRnAq1IrcwXhlZtAhRgEORiUe3hvzjkUIsSaWFVfmHmKU4GBWEuFdJXE8 Qog3JbGyKrUoP76oNCe1+BCjKTDsJzJLiSbnA9N0Xkm8oYmZoYmRJRCaG5orifNGGUyMEBJI TyxJzU5NLUgtgulj4uCUamAsTo9LXHSbXWROeGepQ6j7w+hApdUb83imL99ufeOL2uWGtpSp 56yO+yilbarnE9uz9pDe7qbt+ocM/8bxpvmyOTtqMVpnagkwid5XXPRYer/an1Xmy47rT914 92uwdcnsS698jx5w3fTJL3PPl7u2CebK/8/qe9w6PkuOcfvrzHrzGSkbZW8osRRnJBpqMRcV JwIABmcXUJsDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrIIsWRmVeSWpSXmKPExsVy+t9jQV1+reMRBus3mFn0Nk1nsnhzHEhc 3jWHzeJ24wo2i5+HzjM5sHpseLSa1WPeyUCP9/uusnn0bVnF6PF5k1wAa5SbTUZqYkpqkUJq XnJ+SmZeuq1SaIibroWSQl5ibqqtUoSub0iQkkJZYk4pkGdkgAYcnAPcg5X07RLcMq7MvsBS cJ2r4sGF1AbGCxxdjJwcEgImEm/WrGKFsMUkLtxbz9bFyMUhJDCLUeLe2wOMIAleAUGJH5Pv sXQxcnAwC8hLHLmUDRJmFlCXmDRvETOILSTwgFHi/scSiHItiXObH4K1sgioSizvngpmswHF 97+4wQZi8wsoSlz98ZgRZKSoQIRE94lKEFNEoECi71slxPRwiZsTb4NNFxaIlPgzdxMrxGV9 jBKvFtwCS3AKWEpsPPuYaQKj4Cwkh85COHQWkkMXMDKvYpRILUguKE5KzzXKSy3XK07MLS7N S9dLzs/dxAiOrmfSOxgP73I/xCjAwajEw3tj3rEIIdbEsuLK3EOMEhzMSiK8qySORwjxpiRW VqUW5ccXleakFh9iNAV6dSKzlGhyPjDy80riDU3MTcyNDSzMLS1NjJTEeRtnPwsXEkhPLEnN Tk0tSC2C6WPi4JRqYFTc5X318OZKpSdT9eat3+4WkljL8Eznsy3T+klqa7bf4PdMnB3SKL5G oLvkhbl9otDic8v/d12ujp3mHavBo1Dc3pfseeLY++5tTfb7/T5lvCn7685jc89OVzn0Bqv0 8UlzdX87VOwpnPbsvv+9IzG7fqe2bGNz3nT74CQmh6+vakN3Kts9s1BiKc5INNRiLipOBAB6 09zQxAIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170313232359epcas5p4f2bc3df808f0b2804b4da32b067917bf X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170313112840epcas2p3ee7547e586db83cb62e97975886028a5 X-RootMTR: 20170313112840epcas2p3ee7547e586db83cb62e97975886028a5 References: <20170313112834.11006-1-hdegoede@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2017년 03월 13일 20:28, Hans de Goede wrote: > With the new more strict ACPI gpio code the dsdt's IoRestriction > flags are honored on gpiod_get, but in some dsdt's it is wrong, > so explicitly call gpiod_direction_input on the id gpio if > necessary. > > This fixes the following errors when the int3496 code is used > together with the new more strict ACPI gpio code: > > [ 2382.484415] gpio gpiochip1: (INT33FF:01): gpiochip_lock_as_irq: tried to flag a GPIO set as output for IRQ > [ 2382.484425] gpio gpiochip1: (INT33FF:01): unable to lock HW IRQ 3 for IRQ > [ 2382.484429] genirq: Failed to request resources for INT3496:00 (irq 174) on irqchip chv-gpio > [ 2382.484518] intel-int3496 INT3496:00: can't request IRQ for USB ID GPIO: -22 > [ 2382.500359] intel-int3496: probe of INT3496:00 failed with error -22 > > Cc: Andy Shevchenko > Signed-off-by: Hans de Goede > --- > Changes in v2: > -Warn about firmware bug when the dsdt's IoRestriction does not allow input > Changes in v3: > -Use FW_BUG macro > -Group check together with gpiodesc error check > -Keep lines within 80 chars limit > --- > drivers/extcon/extcon-intel-int3496.c | 3 +++ > 1 file changed, 3 insertions(+) Applied it. Thanks. -- Best Regards, Chanwoo Choi Samsung Electronics