Re: [PATCH] drm/exynos/dsi: make te-gpios optional

[Inki Dae <inki.dae@samsung.com>]

2017년 03월 14일 00:30에 Andrzej Hajda 이(가) 쓴 글:
> In case of HW-TRIGGER te-gpios interrupt is not necessary. With this
> patch we can get rid of 60 interrupt callbacks per second.

Andrzej,

Sorry but above description is not clear.

If panel device node of command mode panel device doesn't provide te-gpios property then now the panel driver will fail to probe.
Seems this patch makes it to allow the panel driver probing is always ok even if gpio is invalid.

So how about handling this at top of this function like below?

if (!of_property_read_bool(node, "te-gpios"))
	return 0;

And I think the description should be modified properly including subject of this patch. 

Thanks,
Inki Dae

> 
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_dsi.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> index 812e2ec..f95fac5 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> @@ -1349,9 +1349,8 @@ static int exynos_dsi_register_te_irq(struct exynos_dsi *dsi)
>  
>  	dsi->te_gpio = of_get_named_gpio(dsi->panel_node, "te-gpios", 0);
>  	if (!gpio_is_valid(dsi->te_gpio)) {
> -		dev_err(dsi->dev, "no te-gpios specified\n");
> -		ret = dsi->te_gpio;
> -		goto out;
> +		dev_info(dsi->dev, "no te-gpios specified\n");
> +		return 0;
>  	}
>  
>  	ret = gpio_request(dsi->te_gpio, "te_gpio");
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel