From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Zhong Subject: Re: [PATCH 1/3] dt-bindings: add the grf clock for dw-mipi-dsi Date: Wed, 15 Mar 2017 17:55:23 +0800 Message-ID: <58C90F8B.7070102@rock-chips.com> References: <1489567352-3333-1-git-send-email-zyw@rock-chips.com> <3304582.Whtjx7Nypf@diego> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <3304582.Whtjx7Nypf@diego> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?UTF-8?Q?Heiko_St=c3=bcbner?= Cc: Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Rob Herring , linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org SGkgSGVpa28KCk9uIDAzLzE1LzIwMTcgMDU6MDMgUE0sIEhlaWtvIFN0w7xibmVyIHdyb3RlOgo+ IEFtIE1pdHR3b2NoLCAxNS4gTcOkcnogMjAxNywgMTY6NDI6MzAgQ0VUIHNjaHJpZWIgQ2hyaXMg Wmhvbmc6Cj4+IEZvciBSSzMzOTksIHRoZSBncmYgY2xvY2sgc2hvdWxkIGJlIGNvbnRyb2xsZWQg YnkgZHctbWlwaS1kc2kgZHJpdmVyLAo+PiBhZGQgdGhlIGRlc2NyaXB0aW9uIGZvciB0aGlzIGNs b2NrLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBaaG9uZyA8enl3QHJvY2stY2hpcHMuY29t Pgo+PiAtLS0KPj4KPj4gICAuLi4vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L3JvY2tjaGlw L2R3X21pcGlfZHNpX3JvY2tjaGlwLnR4dCAgICAgICB8IDIKPj4gKy0gMSBmaWxlIGNoYW5nZWQs IDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4+Cj4+IGRpZmYgLS1naXQKPj4gYS9Eb2N1 bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9yb2NrY2hpcC9kd19taXBpX2Rz aV9yb2NrY2hpcC50Cj4+IHh0Cj4+IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdz L2Rpc3BsYXkvcm9ja2NoaXAvZHdfbWlwaV9kc2lfcm9ja2NoaXAudAo+PiB4dCBpbmRleCAxODhm NmY3Li43ZTE3YTYwIDEwMDY0NAo+PiAtLS0KPj4gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUv YmluZGluZ3MvZGlzcGxheS9yb2NrY2hpcC9kd19taXBpX2RzaV9yb2NrY2hpcC50Cj4+IHh0ICsr Kwo+PiBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L3JvY2tjaGlw L2R3X21pcGlfZHNpX3JvY2tjaGlwLnQKPj4geHQgQEAgLTEwLDcgKzEwLDcgQEAgUmVxdWlyZWQg cHJvcGVydGllczoKPj4gICAtIGludGVycnVwdHM6IFJlcHJlc2VudCB0aGUgY29udHJvbGxlcidz IGludGVycnVwdCB0byB0aGUgQ1BVKHMpLgo+PiAgIC0gY2xvY2tzLCBjbG9jay1uYW1lczogUGhh bmRsZXMgdG8gdGhlIGNvbnRyb2xsZXIncyBwbGwgcmVmZXJlbmNlCj4+ICAgICBjbG9jayhyZWYp IGFuZCBBUEIgY2xvY2socGNsaykuIEZvciBSSzMzOTksIGEgcGh5IGNvbmZpZyBjbG9jawo+PiAt ICAocGh5X2NmZykgaXMgYWRkaXRpb25hbCByZXF1aXJlZC4gQXMgZGVzY3JpYmVkIGluIFsxXS4K Pj4gKyAgKHBoeV9jZmcpIGFuZCBhIGdyZiBjbG9jayhncmYpIGFyZSBhZGRpdGlvbmFsIHJlcXVp cmVkLiBBcyBkZXNjcmliZWQgaW4KPj4gWzFdLgo+IHlvdXIgImdyZiIgY2xvY2sgaXMgb3B0aW9u YWwsIGFzIGl0IGlzIG5vdCBwcmVzZW50IG9uIGFsbCBzb2NzIChsaWtlIHRoZQo+IHJrMzI4OCkg c28gc2hvdWxkIHByb2JhYmx5IG1vdmUgdG8gYSBzZXBhcmF0ZSBzZWN0aW9uIGFuZCBub3QgYmUg aW4gdGhlCj4gcmVxdWlyZWQgcHJvcGVydGllcwpGb3IgUkszMzk5LCB0aGUgZ3JmIGNsb2NrIGlz IHJlcXVpcmVkLCBhY2NvcmRpbmcgdG8gdGhlIGFkdmljZSBwcm92aWRlZCAKYnkgcm9iWzBdLApw dXQgaXQgaW50byAicmVxdWlyZWQgcHJvcGVydGllcyAiIGlzIGJldHRlci4KWzBdIGh0dHBzOi8v cGF0Y2h3b3JrLmtlcm5lbC5vcmcvcGF0Y2gvOTIyMDE4Ny8KPgo+IEhlaWtvCj4KPgo+CgotLSAK Q2hyaXMgWmhvbmcKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: zyw@rock-chips.com (Chris Zhong) Date: Wed, 15 Mar 2017 17:55:23 +0800 Subject: [PATCH 1/3] dt-bindings: add the grf clock for dw-mipi-dsi In-Reply-To: <3304582.Whtjx7Nypf@diego> References: <1489567352-3333-1-git-send-email-zyw@rock-chips.com> <3304582.Whtjx7Nypf@diego> Message-ID: <58C90F8B.7070102@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Heiko On 03/15/2017 05:03 PM, Heiko St?bner wrote: > Am Mittwoch, 15. M?rz 2017, 16:42:30 CET schrieb Chris Zhong: >> For RK3399, the grf clock should be controlled by dw-mipi-dsi driver, >> add the description for this clock. >> >> Signed-off-by: Chris Zhong >> --- >> >> .../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 2 >> +- 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git >> a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.t >> xt >> b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.t >> xt index 188f6f7..7e17a60 100644 >> --- >> a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.t >> xt +++ >> b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.t >> xt @@ -10,7 +10,7 @@ Required properties: >> - interrupts: Represent the controller's interrupt to the CPU(s). >> - clocks, clock-names: Phandles to the controller's pll reference >> clock(ref) and APB clock(pclk). For RK3399, a phy config clock >> - (phy_cfg) is additional required. As described in [1]. >> + (phy_cfg) and a grf clock(grf) are additional required. As described in >> [1]. > your "grf" clock is optional, as it is not present on all socs (like the > rk3288) so should probably move to a separate section and not be in the > required properties For RK3399, the grf clock is required, according to the advice provided by rob[0], put it into "required properties " is better. [0] https://patchwork.kernel.org/patch/9220187/ > > Heiko > > > -- Chris Zhong From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752610AbdCOJzz (ORCPT ); Wed, 15 Mar 2017 05:55:55 -0400 Received: from regular1.263xmail.com ([211.150.99.138]:52987 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751962AbdCOJzx (ORCPT ); Wed, 15 Mar 2017 05:55:53 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: zyw@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: zyw@rock-chips.com X-UNIQUE-TAG: <0dc48aee240f1a3402a4ec454586df3b> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 1/3] dt-bindings: add the grf clock for dw-mipi-dsi To: =?UTF-8?Q?Heiko_St=c3=bcbner?= References: <1489567352-3333-1-git-send-email-zyw@rock-chips.com> <3304582.Whtjx7Nypf@diego> Cc: linux-rockchip@lists.infradead.org, Mark Yao , David Airlie , Rob Herring , Mark Rutland , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Chris Zhong Message-ID: <58C90F8B.7070102@rock-chips.com> Date: Wed, 15 Mar 2017 17:55:23 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <3304582.Whtjx7Nypf@diego> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiko On 03/15/2017 05:03 PM, Heiko Stübner wrote: > Am Mittwoch, 15. März 2017, 16:42:30 CET schrieb Chris Zhong: >> For RK3399, the grf clock should be controlled by dw-mipi-dsi driver, >> add the description for this clock. >> >> Signed-off-by: Chris Zhong >> --- >> >> .../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 2 >> +- 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git >> a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.t >> xt >> b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.t >> xt index 188f6f7..7e17a60 100644 >> --- >> a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.t >> xt +++ >> b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.t >> xt @@ -10,7 +10,7 @@ Required properties: >> - interrupts: Represent the controller's interrupt to the CPU(s). >> - clocks, clock-names: Phandles to the controller's pll reference >> clock(ref) and APB clock(pclk). For RK3399, a phy config clock >> - (phy_cfg) is additional required. As described in [1]. >> + (phy_cfg) and a grf clock(grf) are additional required. As described in >> [1]. > your "grf" clock is optional, as it is not present on all socs (like the > rk3288) so should probably move to a separate section and not be in the > required properties For RK3399, the grf clock is required, according to the advice provided by rob[0], put it into "required properties " is better. [0] https://patchwork.kernel.org/patch/9220187/ > > Heiko > > > -- Chris Zhong