From mboxrd@z Thu Jan 1 00:00:00 1970 From: "zhichang.yuan" Subject: Re: [PATCH V7 5/7] ACPI: Delay the enumeration on the devices whose dependency has not met Date: Thu, 16 Mar 2017 10:21:58 +0800 Message-ID: <58C9F6C6.4090700@hisilicon.com> References: <1489372963-9000-1-git-send-email-yuanzhichang@hisilicon.com> <1489372963-9000-6-git-send-email-yuanzhichang@hisilicon.com> <4600523.rWNiWKrYZC@aspire.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4600523.rWNiWKrYZC-yvgW3jdyMHm1GS7QM15AGw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Rafael J. Wysocki" Cc: catalin.marinas-5wv7dgnIgG8@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, rafael-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org, benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linuxarm-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, minyard-HInyCGIudOg@public.gmane.org, liviu.dudau-5wv7dgnIgG8@public.gmane.org, zourongrong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, john.garry-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, gabriele.paoloni-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, zhichang.yuan02-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, kantyzc-9Onoh4P/yGk@public.gmane.org, xuwei5-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org List-Id: linux-acpi@vger.kernel.org Hi, Rafael, Thanks for your review! On 2017/3/14 5:24, Rafael J. Wysocki wrote: > On Monday, March 13, 2017 10:42:41 AM zhichang.yuan wrote: >> In commit 40e7fcb1929(ACPI: Add _DEP support to fix battery issue on Asus >> T100TA), the '_DEP' was supported to solve the dependency of Asus battery. But >> this patch is specific to Asus battery device. >> In the real world, there are other devices which need the dependency to play the >> role on the enumeration order. For example, all the Hip06 LPC >> periperals(IPMI-BT, uart, etc) must be scanned after the LPC host driver >> finished the probing. So, it makes sense to add a checking whether the ACPI >> device meet all the dependencies during its enumeration slot, if not, the >> enumeration will be delayed till all dependency master finish their work. >> >> This patch adds the dependency checking in ACPI enumeration, also the >> corresponding handling to retrigger the Hip06 LPC peripherals' scanning. > > AFAICS, _DEP is generally abused in the wild and cannot be made generic. Sorry. > >>From the ACPI specification, _DEP is for operation region accesses. You are right... How about we add a ACPI handler for our LPC bus?? Just like amba. In this way, we also can solve the issue about LPC enumeration order. Thanks, Zhichang > Thanks, > Rafael > > > . > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Subject: Re: [PATCH V7 5/7] ACPI: Delay the enumeration on the devices whose dependency has not met To: "Rafael J. Wysocki" References: <1489372963-9000-1-git-send-email-yuanzhichang@hisilicon.com> <1489372963-9000-6-git-send-email-yuanzhichang@hisilicon.com> <4600523.rWNiWKrYZC@aspire.rjw.lan> From: "zhichang.yuan" Message-ID: <58C9F6C6.4090700@hisilicon.com> Date: Thu, 16 Mar 2017 10:21:58 +0800 MIME-Version: 1.0 In-Reply-To: <4600523.rWNiWKrYZC@aspire.rjw.lan> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, benh@kernel.crashing.org, gabriele.paoloni@huawei.com, rafael@kernel.org, linux-pci@vger.kernel.org, will.deacon@arm.com, linuxarm@huawei.com, frowand.list@gmail.com, lorenzo.pieralisi@arm.com, arnd@arndb.de, xuwei5@hisilicon.com, linux-acpi@vger.kernel.org, linux-serial@vger.kernel.org, catalin.marinas@arm.com, devicetree@vger.kernel.org, minyard@acm.org, liviu.dudau@arm.com, john.garry@huawei.com, robh+dt@kernel.org, bhelgaas@google.com, kantyzc@163.com, zhichang.yuan02@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, zourongrong@gmail.com Content-Type: text/plain; charset="us-ascii" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: Hi, Rafael, Thanks for your review! On 2017/3/14 5:24, Rafael J. Wysocki wrote: > On Monday, March 13, 2017 10:42:41 AM zhichang.yuan wrote: >> In commit 40e7fcb1929(ACPI: Add _DEP support to fix battery issue on Asus >> T100TA), the '_DEP' was supported to solve the dependency of Asus battery. But >> this patch is specific to Asus battery device. >> In the real world, there are other devices which need the dependency to play the >> role on the enumeration order. For example, all the Hip06 LPC >> periperals(IPMI-BT, uart, etc) must be scanned after the LPC host driver >> finished the probing. So, it makes sense to add a checking whether the ACPI >> device meet all the dependencies during its enumeration slot, if not, the >> enumeration will be delayed till all dependency master finish their work. >> >> This patch adds the dependency checking in ACPI enumeration, also the >> corresponding handling to retrigger the Hip06 LPC peripherals' scanning. > > AFAICS, _DEP is generally abused in the wild and cannot be made generic. Sorry. > >>From the ACPI specification, _DEP is for operation region accesses. You are right... How about we add a ACPI handler for our LPC bus?? Just like amba. In this way, we also can solve the issue about LPC enumeration order. Thanks, Zhichang > Thanks, > Rafael > > > . > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: yuanzhichang@hisilicon.com (zhichang.yuan) Date: Thu, 16 Mar 2017 10:21:58 +0800 Subject: [PATCH V7 5/7] ACPI: Delay the enumeration on the devices whose dependency has not met In-Reply-To: <4600523.rWNiWKrYZC@aspire.rjw.lan> References: <1489372963-9000-1-git-send-email-yuanzhichang@hisilicon.com> <1489372963-9000-6-git-send-email-yuanzhichang@hisilicon.com> <4600523.rWNiWKrYZC@aspire.rjw.lan> Message-ID: <58C9F6C6.4090700@hisilicon.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, Rafael, Thanks for your review! On 2017/3/14 5:24, Rafael J. Wysocki wrote: > On Monday, March 13, 2017 10:42:41 AM zhichang.yuan wrote: >> In commit 40e7fcb1929(ACPI: Add _DEP support to fix battery issue on Asus >> T100TA), the '_DEP' was supported to solve the dependency of Asus battery. But >> this patch is specific to Asus battery device. >> In the real world, there are other devices which need the dependency to play the >> role on the enumeration order. For example, all the Hip06 LPC >> periperals(IPMI-BT, uart, etc) must be scanned after the LPC host driver >> finished the probing. So, it makes sense to add a checking whether the ACPI >> device meet all the dependencies during its enumeration slot, if not, the >> enumeration will be delayed till all dependency master finish their work. >> >> This patch adds the dependency checking in ACPI enumeration, also the >> corresponding handling to retrigger the Hip06 LPC peripherals' scanning. > > AFAICS, _DEP is generally abused in the wild and cannot be made generic. Sorry. > >>From the ACPI specification, _DEP is for operation region accesses. You are right... How about we add a ACPI handler for our LPC bus?? Just like amba. In this way, we also can solve the issue about LPC enumeration order. Thanks, Zhichang > Thanks, > Rafael > > > . > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751271AbdCPCWj (ORCPT ); Wed, 15 Mar 2017 22:22:39 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:4413 "EHLO dggrg03-dlp.huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751137AbdCPCWf (ORCPT ); Wed, 15 Mar 2017 22:22:35 -0400 Subject: Re: [PATCH V7 5/7] ACPI: Delay the enumeration on the devices whose dependency has not met To: "Rafael J. Wysocki" References: <1489372963-9000-1-git-send-email-yuanzhichang@hisilicon.com> <1489372963-9000-6-git-send-email-yuanzhichang@hisilicon.com> <4600523.rWNiWKrYZC@aspire.rjw.lan> CC: , , , , , , , , , , , , , , , , , , , , , , , , From: "zhichang.yuan" Message-ID: <58C9F6C6.4090700@hisilicon.com> Date: Thu, 16 Mar 2017 10:21:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <4600523.rWNiWKrYZC@aspire.rjw.lan> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.57.79.81] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020206.58C9F6D1.018B,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: d13ba66d32df66f220852e3bf8c77419 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Rafael, Thanks for your review! On 2017/3/14 5:24, Rafael J. Wysocki wrote: > On Monday, March 13, 2017 10:42:41 AM zhichang.yuan wrote: >> In commit 40e7fcb1929(ACPI: Add _DEP support to fix battery issue on Asus >> T100TA), the '_DEP' was supported to solve the dependency of Asus battery. But >> this patch is specific to Asus battery device. >> In the real world, there are other devices which need the dependency to play the >> role on the enumeration order. For example, all the Hip06 LPC >> periperals(IPMI-BT, uart, etc) must be scanned after the LPC host driver >> finished the probing. So, it makes sense to add a checking whether the ACPI >> device meet all the dependencies during its enumeration slot, if not, the >> enumeration will be delayed till all dependency master finish their work. >> >> This patch adds the dependency checking in ACPI enumeration, also the >> corresponding handling to retrigger the Hip06 LPC peripherals' scanning. > > AFAICS, _DEP is generally abused in the wild and cannot be made generic. Sorry. > >>From the ACPI specification, _DEP is for operation region accesses. You are right... How about we add a ACPI handler for our LPC bus?? Just like amba. In this way, we also can solve the issue about LPC enumeration order. Thanks, Zhichang > Thanks, > Rafael > > > . >