From mboxrd@z Thu Jan 1 00:00:00 1970 From: Seung-Woo Kim Subject: Re: [PATCH libdrm] tests/exynos: fix memory issues of error path in g2d test Date: Mon, 20 Mar 2017 09:14:39 +0900 Message-ID: <58CF1EEF.80009@samsung.com> References: <1489629604-10811-1-git-send-email-sw0312.kim@samsung.com> Reply-To: sw0312.kim@samsung.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id B8E9F6E06E for ; Mon, 20 Mar 2017 00:14:28 +0000 (UTC) Received: from epcas1p1.samsung.com (unknown [182.195.41.45]) by mailout1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0ON300DW37C27P70@mailout1.samsung.com> for dri-devel@lists.freedesktop.org; Mon, 20 Mar 2017 09:14:26 +0900 (KST) In-reply-to: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Emil Velikov Cc: Seung-Woo Kim , Rob Clark , ML dri-devel List-Id: dri-devel@lists.freedesktop.org SGVsbG8gRW1pbCwKClRoYW5rcyBmb3IgY29tbWVudC4KCk9uIDIwMTfrhYQgMDPsm5QgMjDsnbwg MDk6MDgsIEVtaWwgVmVsaWtvdiB3cm90ZToKPiBIaSBTZXVuZy1Xb28gS2ltLAo+IAo+IE9uIDE2 IE1hcmNoIDIwMTcgYXQgMDI6MDAsIFNldW5nLVdvbyBLaW0gPHN3MDMxMi5raW1Ac2Ftc3VuZy5j b20+IHdyb3RlOgo+PiBUaGlzIHBhdGNoIGZpeGVzIG1lbW9yeSBpc3N1ZXMgaW5jbHVkaW5nIE5V TEwgZGVmZXJlbmNlIGFuZCBsZWFrCj4+IGluIGcyZCB0ZXN0IGluIGVycm9yIHBhdGguCj4+Cj4+ IFNpZ25lZC1vZmYtYnk6IFNldW5nLVdvbyBLaW0gPHN3MDMxMi5raW1Ac2Ftc3VuZy5jb20+Cj4+ IC0tLQo+PiAgdGVzdHMvZXh5bm9zL2V4eW5vc19maW1nMmRfdGVzdC5jIHwgICAxMyArKysrKysr LS0tLS0tCj4+ICAxIGZpbGVzIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMo LSkKPj4KPj4gZGlmZiAtLWdpdCBhL3Rlc3RzL2V4eW5vcy9leHlub3NfZmltZzJkX3Rlc3QuYyBi L3Rlc3RzL2V4eW5vcy9leHlub3NfZmltZzJkX3Rlc3QuYwo+PiBpbmRleCA3OTdmYjZlLi4yMTc3 ZTA4IDEwMDY0NAo+PiAtLS0gYS90ZXN0cy9leHlub3MvZXh5bm9zX2ZpbWcyZF90ZXN0LmMKPj4g KysrIGIvdGVzdHMvZXh5bm9zL2V4eW5vc19maW1nMmRfdGVzdC5jCj4+IEBAIC01OSw3ICs1OSw2 IEBAIHN0YXRpYyB2b2lkIGNvbm5lY3Rvcl9maW5kX21vZGUoaW50IGZkLCBzdHJ1Y3QgY29ubmVj dG9yICpjLAo+PiAgICAgICAgICAgICAgICAgaWYgKCFjb25uZWN0b3IpIHsKPj4gICAgICAgICAg ICAgICAgICAgICAgICAgZnByaW50ZihzdGRlcnIsICJjb3VsZCBub3QgZ2V0IGNvbm5lY3RvciAl aTogJXNcbiIsCj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVzb3VyY2VzLT5j b25uZWN0b3JzW2ldLCBzdHJlcnJvcihlcnJubykpOwo+PiAtICAgICAgICAgICAgICAgICAgICAg ICBkcm1Nb2RlRnJlZUNvbm5lY3Rvcihjb25uZWN0b3IpOwo+PiAgICAgICAgICAgICAgICAgICAg ICAgICBjb250aW51ZTsKPj4gICAgICAgICAgICAgICAgIH0KPj4KPj4gQEAgLTk4LDcgKzk3LDYg QEAgc3RhdGljIHZvaWQgY29ubmVjdG9yX2ZpbmRfbW9kZShpbnQgZmQsIHN0cnVjdCBjb25uZWN0 b3IgKmMsCj4+ICAgICAgICAgICAgICAgICBpZiAoIWMtPmVuY29kZXIpIHsKPj4gICAgICAgICAg ICAgICAgICAgICAgICAgZnByaW50ZihzdGRlcnIsICJjb3VsZCBub3QgZ2V0IGVuY29kZXIgJWk6 ICVzXG4iLAo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJlc291cmNlcy0+ZW5j b2RlcnNbaV0sIHN0cmVycm9yKGVycm5vKSk7Cj4+IC0gICAgICAgICAgICAgICAgICAgICAgIGRy bU1vZGVGcmVlRW5jb2RlcihjLT5lbmNvZGVyKTsKPj4gICAgICAgICAgICAgICAgICAgICAgICAg Y29udGludWU7Cj4+ICAgICAgICAgICAgICAgICB9Cj4+Cj4+IEBAIC0yNjQsNyArMjYyLDggQEAg c3RhdGljIGludCBnMmRfY29weV90ZXN0KHN0cnVjdCBleHlub3NfZGV2aWNlICpkZXYsIHN0cnVj dCBleHlub3NfYm8gKnNyYywKPj4gICAgICAgICAgICAgICAgIHVzZXJwdHIgPSAodW5zaWduZWQg bG9uZyltYWxsb2Moc2l6ZSk7Cj4+ICAgICAgICAgICAgICAgICBpZiAoIXVzZXJwdHIpIHsKPj4g ICAgICAgICAgICAgICAgICAgICAgICAgZnByaW50ZihzdGRlcnIsICJmYWlsZWQgdG8gYWxsb2Nh dGUgdXNlcnB0ci5cbiIpOwo+PiAtICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gLUVGQVVM VDsKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgcmV0ID0gLUVGQVVMVDsKPj4gKyAgICAgICAg ICAgICAgICAgICAgICAgZ290byBmYWlsOwo+IEV2ZW4gaWYgeW91IGhhdmUgdGhlIGJlc3Qgb2Yg aW50ZW50aW9ucywgYnV0IHRoZXJlJ3MgeWV0IGFub3RoZXIgYnVnCj4gaW4gdGhlIGV4aXN0aW5n IGNvZGUgOi1cCj4gCj4gTmFtZWx5OiB3ZSBhbHdheXMgcmV0dXJuIDAgZXZlbiBvbiBlcnJvciAt IGkuZS4gdGhlICJyZXR1cm4gMCIsIGFmdGVyCj4gdGhlIGcyZF9maW5pKCkgbXVzdCBiZSAicmV0 dXJuIHJldCIKPiBUaGlzIGFwcGxpZXMgdG8gYWxsIHRoZSB0ZXN0cywgYWZhaWNzLgoKWW91IGFy ZSByaWdodC4gSSB3aWxsIGZpeCBpdC4KCj4gCj4gCj4+IEBAIC03NTUsNyArNzU2LDcgQEAgaW50 IG1haW4oaW50IGFyZ2MsIGNoYXIgKiphcmd2KQo+Pgo+PiAgICAgICAgIGRldiA9IGV4eW5vc19k ZXZpY2VfY3JlYXRlKGZkKTsKPj4gICAgICAgICBpZiAoIWRldikgewo+PiAtICAgICAgICAgICAg ICAgZHJtQ2xvc2UoZGV2LT5mZCk7Cj4+ICsgICAgICAgICAgICAgICBkcm1DbG9zZShmZCk7Cj4g U2VlbXMgY29ycmVjdCwgYnV0IGFuIGFsdGVybmF0aXZlIChiZXR0ZXIgSU1ITykgc29sdXRpb24g aXMgdG86Cj4gIC0gZmxpcC9maXggdGhlIGNhbGwgZHJtQ2xvc2UoKSA8PiBleHlub3NfZGV2aWNl X2Rlc3Ryb3koKSBvcmRlciBpbgo+IGVycl9kcm1fY2xvc2UuCj4gIC0gdXNlICJmZCIgaW4gZXh5 bm9zX2RldmljZV9kZXN0cm95J3MgZHJtQ2xvc2UuCj4gIC0gYWRkIHNlcGFyYXRlIGxhYmVsIGFu ZCB1c2UgaXQgaW4gdGhlIGFib3ZlIGNhc2UuCgpPaywgSSB3aWxsIGFkZCBlcnJvciBsYWJlbC4K Cj4gCj4gQ2FuIHlvdSBnaXZlIHRoaXMgYSB0cnksIHBsZWFzZSA/CgpBZnRlciBmaXhpbmcgYXMg eW91ciBjb21tZW50LCBJIHdpbGwgc2VuZCB2Mi4KClJlZ2FyZHMsCi0gU2V1bmctV29vIEtpbQoK PiAKPiBUaGFua3MKPiBFbWlsCj4gCj4gCj4gCgotLSAKU2V1bmctV29vIEtpbQpTYW1zdW5nIFNv ZnR3YXJlIFImRCBDZW50ZXIKLS0KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2RyaS1kZXZlbAo=