From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?6ZmI5Lqu?= Subject: Re: [PATCH v2 4/6] arm64: dts: rockchip: add core dtsi file for RK3328 SoCs Date: Thu, 23 Mar 2017 10:15:20 +0800 Message-ID: <58D32FB8.9070909@rock-chips.com> References: <1489670244-13328-1-git-send-email-cl@rock-chips.com> <1489670244-13328-5-git-send-email-cl@rock-chips.com> <7240249b-690a-5800-0b46-fb93a49e2af1@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <7240249b-690a-5800-0b46-fb93a49e2af1@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Sudeep Holla , heiko@sntech.de Cc: mark.rutland@arm.com, wsa@the-dreams.de, linux-iio@vger.kernel.org, catalin.marinas@arm.com, shawn.lin@rock-chips.com, will.deacon@arm.com, kever.yang@rock-chips.com, linux-kernel@vger.kernel.org, yamada.masahiro@socionext.com, tony.xie@rock-chips.com, linux-i2c@vger.kernel.org, pmeerw@pmeerw.net, david.wu@rock-chips.com, lars@metafoo.de, zhengxing@rock-chips.com, khilman@baylibre.com, linux-rockchip@lists.infradead.org, jay.xu@rock-chips.com, wxt@rock-chips.com, huangtao@rock-chips.com, devicetree@vger.kernel.org, paweljarosz3691@gmail.com, arnd@arndb.de, yhx@rock-chips.com, zhangqing@rock-chips.com, robh+dt@kernel.org, matthias.bgg@gmail.com, akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org, dianders@chromium.org, knaack.h@gmx.de, fabio.estevam@nxp.com, andy.yan@rock-chips.com, rocky.hao@rock-chips.com, shawnguo@kernel.org, afaerber@suse.de, jic23@kernel. List-Id: linux-i2c@vger.kernel.org SGksCgrlnKggMjAxN+W5tDAz5pyIMjPml6UgMDI6MDksIFN1ZGVlcCBIb2xsYSDlhpnpgZM6Cj4K PiBPbiAxNi8wMy8xNyAxMzoxNywgY2xAcm9jay1jaGlwcy5jb20gd3JvdGU6Cj4+IEZyb206IExp YW5nIENoZW4gPGNsQHJvY2stY2hpcHMuY29tPgo+Pgo+PiBUaGlzIHBhdGNoIGFkZHMgY29yZSBk dHNpIGZpbGUgZm9yIFJvY2tjaGlwIFJLMzMyOCBTb0NzLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBM aWFuZyBDaGVuIDxjbEByb2NrLWNoaXBzLmNvbT4KPj4gLS0tCj4+ICAgYXJjaC9hcm02NC9ib290 L2R0cy9yb2NrY2hpcC9yazMzMjguZHRzaSB8IDEzNjIgKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrCj4+ICAgMSBmaWxlIGNoYW5nZWQsIDEzNjIgaW5zZXJ0aW9ucygrKQo+PiAgIGNyZWF0 ZSBtb2RlIDEwMDY0NCBhcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzMyOC5kdHNpCj4+ Cj4+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzMyOC5kdHNp IGIvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazMzMjguZHRzaQo+PiBuZXcgZmlsZSBt b2RlIDEwMDY0NAo+PiBpbmRleCAwMDAwMDAwLi5hOTI5NTVjCj4+IC0tLSAvZGV2L251bGwKPj4g KysrIGIvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazMzMjguZHRzaQo+IFsuLi5dCj4K Pj4gKwljcHVzIHsKPj4gKwkJI2FkZHJlc3MtY2VsbHMgPSA8Mj47Cj4+ICsJCSNzaXplLWNlbGxz ID0gPDA+Owo+PiArCj4+ICsJCWNwdTA6IGNwdUAwIHsKPj4gKwkJCWRldmljZV90eXBlID0gImNw dSI7Cj4+ICsJCQljb21wYXRpYmxlID0gImFybSxjb3J0ZXgtYTUzIiwgImFybSxhcm12OCI7Cj4+ ICsJCQlyZWcgPSA8MHgwIDB4MD47Cj4+ICsJCQllbmFibGUtbWV0aG9kID0gInBzY2kiOwo+PiAr CQkJY2xvY2tzID0gPCZjcnUgQVJNQ0xLPjsKPiBXaHkgImNsb2NrcyIgcHJvcGVydHkgaXMgcHJl c2VudCBvbmx5IGZvciBjcHUwID8KPgpJIHdpbGwgYWRkICJjbG9ja3MiIHByb3BlcnR5IGZvciBl YWNoIGNwdSBub2RlIG5leHQgdmVyc2lvbiwgdGhhbmtzIGZvciAKdGhlIGNvbW1lbnQuCgoKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1r ZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJu ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from regular1.263xmail.com ([211.150.99.134]:44408 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752778AbdCWCQ2 (ORCPT ); Wed, 22 Mar 2017 22:16:28 -0400 Subject: Re: [PATCH v2 4/6] arm64: dts: rockchip: add core dtsi file for RK3328 SoCs To: Sudeep Holla , heiko@sntech.de References: <1489670244-13328-1-git-send-email-cl@rock-chips.com> <1489670244-13328-5-git-send-email-cl@rock-chips.com> <7240249b-690a-5800-0b46-fb93a49e2af1@arm.com> Cc: mark.rutland@arm.com, wsa@the-dreams.de, linux-iio@vger.kernel.org, catalin.marinas@arm.com, shawn.lin@rock-chips.com, will.deacon@arm.com, kever.yang@rock-chips.com, dianders@chromium.org, yamada.masahiro@socionext.com, tony.xie@rock-chips.com, linux-i2c@vger.kernel.org, pmeerw@pmeerw.net, lars@metafoo.de, zhengxing@rock-chips.com, khilman@baylibre.com, linux-rockchip@lists.infradead.org, jay.xu@rock-chips.com, wxt@rock-chips.com, huangtao@rock-chips.com, devicetree@vger.kernel.org, zhangqing@rock-chips.com, paweljarosz3691@gmail.com, arnd@arndb.de, yhx@rock-chips.com, knaack.h@gmx.de, robh+dt@kernel.org, matthias.bgg@gmail.com, rocky.hao@rock-chips.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, david.wu@rock-chips.com, fabio.estevam@nxp.com, andy.yan@rock-chips.com, akpm@linux-foundation.org, shawnguo@kernel.org, afaerber@suse.de, jic23@kernel.org From: =?UTF-8?B?6ZmI5Lqu?= Message-ID: <58D32FB8.9070909@rock-chips.com> Date: Thu, 23 Mar 2017 10:15:20 +0800 MIME-Version: 1.0 In-Reply-To: <7240249b-690a-5800-0b46-fb93a49e2af1@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org Hi, 在 2017年03月23日 02:09, Sudeep Holla 写道: > > On 16/03/17 13:17, cl@rock-chips.com wrote: >> From: Liang Chen >> >> This patch adds core dtsi file for Rockchip RK3328 SoCs. >> >> Signed-off-by: Liang Chen >> --- >> arch/arm64/boot/dts/rockchip/rk3328.dtsi | 1362 ++++++++++++++++++++++++++++++ >> 1 file changed, 1362 insertions(+) >> create mode 100644 arch/arm64/boot/dts/rockchip/rk3328.dtsi >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi >> new file mode 100644 >> index 0000000..a92955c >> --- /dev/null >> +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi > [...] > >> + cpus { >> + #address-cells = <2>; >> + #size-cells = <0>; >> + >> + cpu0: cpu@0 { >> + device_type = "cpu"; >> + compatible = "arm,cortex-a53", "arm,armv8"; >> + reg = <0x0 0x0>; >> + enable-method = "psci"; >> + clocks = <&cru ARMCLK>; > Why "clocks" property is present only for cpu0 ? > I will add "clocks" property for each cpu node next version, thanks for the comment. From mboxrd@z Thu Jan 1 00:00:00 1970 From: cl@rock-chips.com (=?UTF-8?B?6ZmI5Lqu?=) Date: Thu, 23 Mar 2017 10:15:20 +0800 Subject: [PATCH v2 4/6] arm64: dts: rockchip: add core dtsi file for RK3328 SoCs In-Reply-To: <7240249b-690a-5800-0b46-fb93a49e2af1@arm.com> References: <1489670244-13328-1-git-send-email-cl@rock-chips.com> <1489670244-13328-5-git-send-email-cl@rock-chips.com> <7240249b-690a-5800-0b46-fb93a49e2af1@arm.com> Message-ID: <58D32FB8.9070909@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, ? 2017?03?23? 02:09, Sudeep Holla ??: > > On 16/03/17 13:17, cl at rock-chips.com wrote: >> From: Liang Chen >> >> This patch adds core dtsi file for Rockchip RK3328 SoCs. >> >> Signed-off-by: Liang Chen >> --- >> arch/arm64/boot/dts/rockchip/rk3328.dtsi | 1362 ++++++++++++++++++++++++++++++ >> 1 file changed, 1362 insertions(+) >> create mode 100644 arch/arm64/boot/dts/rockchip/rk3328.dtsi >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi >> new file mode 100644 >> index 0000000..a92955c >> --- /dev/null >> +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi > [...] > >> + cpus { >> + #address-cells = <2>; >> + #size-cells = <0>; >> + >> + cpu0: cpu at 0 { >> + device_type = "cpu"; >> + compatible = "arm,cortex-a53", "arm,armv8"; >> + reg = <0x0 0x0>; >> + enable-method = "psci"; >> + clocks = <&cru ARMCLK>; > Why "clocks" property is present only for cpu0 ? > I will add "clocks" property for each cpu node next version, thanks for the comment.