From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754238AbdCXEiO (ORCPT ); Fri, 24 Mar 2017 00:38:14 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:46549 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751503AbdCXEiI (ORCPT ); Fri, 24 Mar 2017 00:38:08 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: b6c32a37-f796f6d000001a35-23-58d4a2ac770b Content-transfer-encoding: 8BIT Message-id: <58D4A2AB.6030904@samsung.com> Date: Fri, 24 Mar 2017 13:38:03 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Hans de Goede , MyungJoo Ham Cc: Takashi Iwai , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] extcon: intel-cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver In-reply-to: <20170323160142.15266-1-hdegoede@redhat.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrNKsWRmVeSWpSXmKPExsWy7bCmnu6aRVciDBo75SzeHJ/OZHF51xw2 i9uNK9gsXm5+w+TA4vF+31U2j74tqxg9Np+u9vi8SS6AJSrVJiM1MSW1SCE1Lzk/JTMv3VbJ OzjeOd7UzMBQ19DSwlxJIS8xN9VWycUnQNctMwdoo5JCWWJOKVAoILG4WEnfzqYov7QkVSEj v7jEVina0NBIz9DAXM/IyEjPxDjWysgUqCQhNePuRLGCVoGKuyt3MDcwPuTpYuTgkBAwkfj1 J7eLkRPIFJO4cG89G4gtJLCDUeLQEt8uRi4gu51Jor/vEyNEkYnE6y8LmCEScxgltl34yA6S 4BUQlPgx+R4LyFBmAXmJI5eyQcLMApoSW3evZ4cYeo9R4scqAYhyLYmeF63MIDaLgKrEjrlL wGrYgOL7X9wAO4JfQFHi6o/HYHtFBSIkds7/BlYjIhAkceP7ClaI+XYSl35NBrOFBdIkPjWB nMDJwSlgKfFx7XQ2kDslBKazS1w/fI4d4mFZiU0HmCF+cZF4c+UO1F/CEq+Ob2GHsKUlVv27 xQTR284osXkOyFAQp4NR4v7KRlaIKmOJ+w/uMUNcwSfx7msPK8QCXomONiGIEg+JR6t3MUHY jhJvPjayQQKuh1Gi6XEH2wRGhVlIYTcLEXazkMJuASPzKkax1ILi3PTUYsMCY73ixNzi0rx0 veT83E2M4ISnZb6DccM5n0OMAhyMSjy8G+ouRQixJpYVV+YeYpTgYFYS4f0680qEEG9KYmVV alF+fFFpTmrxIUZTYNhPZJYSTc4HJuO8knhDEzNDEyMTQ0NzIwMjJXFeVoOJEUIC6Yklqdmp qQWpRTB9TBycUg2MDNMOz1sQezIt7t2t1O9NdYevNQVUH9w9Le6HwJ+5999uKz409e2629+V egVmnX1ttrr4w/Fg7Qe1yhP+zzq5eb34G8Gg572ffFXSuwNn+oixqfi8SpJ/FfZur0GWz1PZ 790xS1+7BZ0wPvL4i9qV3kmrNIImFEUtWLbza+2GG13XC02DaxjKNiqxFGckGmoxFxUnAgDm aE10jgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrJIsWRmVeSWpSXmKPExsVy+t9jQd3Vi65EGKyarm/x5vh0JovLu+aw WdxuXMFm8XLzGyYHFo/3+66yefRtWcXosfl0tcfnTXIBLFFuNhmpiSmpRQqpecn5KZl56bZK oSFuuhZKCnmJuam2ShG6viFBSgpliTmlQJ6RARpwcA5wD1bSt0twy7g7UaygVaDi7sodzA2M D3m6GDk5JARMJF5/WcAMYYtJXLi3nq2LkYtDSGAWo8SJqS/ZQRK8AoISPybfY+li5OBgFpCX OHIpGyTMLKAuMWneImaI+geMEjs+f2eDqNeS6HnRCjaURUBVYsfcJWBz2IDi+1/cAKvhF1CU uPrjMSPITFGBCInuE5UgYRGBAImfp/rZIebbSVz6NZkVxBYWSJP41ARyAsiuPkaJU8suMoEk OAUsJT6unc42gVFwFpJTZyGcOgvJqQsYmVcxSqQWJBcUJ6XnGuallusVJ+YWl+al6yXn525i BEfTM6kdjAd3uR9iFOBgVOLhjai5FCHEmlhWXJl7iFGCg1lJhPfrzCsRQrwpiZVVqUX58UWl OanFhxhNgX6dyCwlmpwPjPS8knhDE3MTc2MDC3NLSxMjJXHextnPwoUE0hNLUrNTUwtSi2D6 mDg4pRoYFc3//l7DtWDL28s/3xWqJQmk3/1V+G1OeMfTqvbLhzdt7pbPXMfsF3P25sSSPTsv f+QLWlp6gr28LHyrbB9/tKXztqDDh6W+HnRf0PvnU/6WK3/jV0VGG2Xuu3ijU2RNq7KC//+4 95eE4gKf8W9+kHVzp4d4qe+qUu4CeZ1w0TlHVJ9bzq3lVGIpzkg01GIuKk4EABauIKa8AgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170324043803epcas1p28c79168b7f6e4145f0632233456a6874 X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170323160156epcas5p434cdd4234cd3646683de8c7fda9913a5 X-RootMTR: 20170323160156epcas5p434cdd4234cd3646683de8c7fda9913a5 References: <20170323160142.15266-1-hdegoede@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2017년 03월 24일 01:01, Hans de Goede wrote: > Add a driver for charger detection / control on the Intel Cherrytrail > Whiskey Cove PMIC. > > Signed-off-by: Hans de Goede > --- > Changes in v2: > -Improve wait for charger detection loop, use jiffies to get an accurate timeout > -Sort registers by address, remove duplicate definition > -Return IRQ_NONE on interrupt handling errors > -Various small style cleanups > -Fix reporting no charger cable being present when detecting the same > charger type 2 times in a row > -Reset to autonomous / hw-mode on probe-error and on remove > Changes in v3: > -Add intel prefix to Kconfig symbol and filename > -Clarified "Unhandled charger type" warning msg > -Dropped usb_id sysfs attribute > --- > drivers/extcon/Kconfig | 7 + > drivers/extcon/Makefile | 1 + > drivers/extcon/extcon-intel-cht-wc.c | 352 +++++++++++++++++++++++++++++++++++ > 3 files changed, 360 insertions(+) > create mode 100644 drivers/extcon/extcon-intel-cht-wc.c > Applied it on extcon-next branch. [snip] > + usbsrc = (usbsrc & CHT_WC_USBSRC_TYPE_MASK) >> CHT_WC_USBSRC_TYPE_SHIFT; > + switch (usbsrc) { > + default: > + dev_warn(ext->dev, "Unhandled charger type %d, defaulting to SDP\n", Nit: This line is over length 80. So, I changed it as following dev_warn(ext->dev, "Unhandled charger type %d, defaulting to SDP\n", > + ret); > + /* Fall through, treat as SDP */ > + case CHT_WC_USBSRC_TYPE_SDP: > + case CHT_WC_USBSRC_TYPE_FLOAT_DP_DN: > + case CHT_WC_USBSRC_TYPE_OTHER: > + return EXTCON_CHG_USB_SDP; > + case CHT_WC_USBSRC_TYPE_CDP: > + return EXTCON_CHG_USB_CDP; > + case CHT_WC_USBSRC_TYPE_DCP: > + case CHT_WC_USBSRC_TYPE_DCP_EXTPHY: > + case CHT_WC_USBSRC_TYPE_MHL: /* MHL2+ delivers upto 2A, treat as DCP */ > + return EXTCON_CHG_USB_DCP; > + case CHT_WC_USBSRC_TYPE_ACA: > + return EXTCON_CHG_USB_ACA; > + } > +} -- Best Regards, Chanwoo Choi Samsung Electronics