From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757017AbdCXLDh (ORCPT ); Fri, 24 Mar 2017 07:03:37 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:34805 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751832AbdCXLD2 (ORCPT ); Fri, 24 Mar 2017 07:03:28 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: b6c32a2d-f793d6d0000012b6-9d-58d4fcf8628f Content-transfer-encoding: 8BIT Message-id: <58D4FCF8.9010509@samsung.com> Date: Fri, 24 Mar 2017 20:03:20 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Andy Shevchenko , linux-kernel@vger.kernel.org, MyungJoo Ham Cc: Lu Baolu Subject: Re: [PATCH v1] Revert "extcon: usb-gpio: add support for ACPI gpio interface" In-reply-to: <1490188199.19767.164.camel@linux.intel.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrJKsWRmVeSWpSXmKPExsWy7bCmlu6PP1ciDCZNVLPobZrOZLF54lY2 i8u75rBZ3G5cwebA4jHvZKBH35ZVjB6fN8kFMEel2mSkJqakFimk5iXnp2TmpdsqeQfHO8eb mhkY6hpaWpgrKeQl5qbaKrn4BOi6ZeYALVNSKEvMKQUKBSQWFyvp29kU5ZeWpCpk5BeX2CpF Gxoa6RkamOsZGRnpmRjHWhmZApUkpGa837mLsWCBVMXGlTsYGxini3YxcnJICJhIzD3bywhh i0lcuLeerYuRi0NIYCmjxItdO1lBEkIC7UwSl7rVYRqeXHrEClG0nFFizdQdYEW8AoISPybf Y+li5OBgFpCXOHIpGyTMLKAp8eLLJBaI+nuMEkffzWaHqNeS+LjwKpjNIqAq8Xn7Q2YQmw0o vv/FDTYQm19AUeLqj8dg14kKREjsnP+NHWSQiEADo8SdB8dZIDaoSzR3QxQJAxUd2HyOCcTm FLCUmHaunwXi6m52idWdxiDHSQjISmw6wAwRdpH4tXYrK4QtLPHq+BZ2CFta4u/SW4wguyQE 2hklNs+5xwLhdDBK3F/ZCNVhLHH/wT1miCP4JHp/P2GCWMAr0dEmBFHiIXHh+m8mCNtR4t2L u4yQkHjGKHHzwivmCYwKs5ACbxYi8GYhBd4CRuZVjGKpBcW56anFpgVGesWJucWleel6yfm5 mxjByU5LdwfjlwXehxgFOBiVeHhPvL4SIcSaWFZcmXuIUYKDWUmEd9dvoBBvSmJlVWpRfnxR aU5q8SFGU2DYT2SWEk3OBybivJJ4QxMzQxMjSyA0NzRXEueNMpgYISSQnliSmp2aWpBaBNPH xMEp1cA4782m+/e8ZsSuXWYd01vTxtXGynmmZ6V8EXNe+b63nWymM6pzrvOXSSoU/7GxbJuq WRIgoeoycVV5hV+Escm9k5rxPTfe7PAWs2WvPtf0UFa5JeCXf/zp/IUFfpbszz9+CjnRUjJ1 fvesam+rj29ibhlo+LCGs/yQq2pIM13K+zvreOj1SCWW4oxEQy3mouJEAMHIEbeMAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrCIsWRmVeSWpSXmKPExsVy+t9jAd0ff65EGJy/JmHR2zSdyWLzxK1s Fpd3zWGzuN24gs2BxWPeyUCPvi2rGD0+b5ILYI5ys8lITUxJLVJIzUvOT8nMS7dVCg1x07VQ UshLzE21VYrQ9Q0JUlIoS8wpBfKMDNCAg3OAe7CSvl2CW8b7nbsYCxZIVWxcuYOxgXG6aBcj J4eEgInEk0uPWCFsMYkL99azdTFycQgJLGWU2Nx4FizBKyAo8WPyPZYuRg4OZgF5iSOXsiFM dYkpU3Ihyh8wSpxctgmqXEvi48Kr7CA2i4CqxOftD5lBbDag+P4XN9hAbH4BRYmrPx4zgswR FYiQ6D5RCTJHRKCBUWL2sv+MIDUg85u7H4PZwkA1BzafY4JY9oJR4uvBr2ALOAUsJaad62eZ wCg4C8mpsxBOnYVw6gJG5lWMEqkFyQXFSem5Rnmp5XrFibnFpXnpesn5uZsYwTH0THoH4+Fd 7ocYBTgYlXh4T7y+EiHEmlhWXJl7iFGCg1lJhHfXb6AQb0piZVVqUX58UWlOavEhRlOgXycy S4km5wPjO68k3tDE3MTc2MDC3NLSxEhJnLdx9rNwIYH0xJLU7NTUgtQimD4mDk6pBsYd6VXP lJ3trVa3XO6b/H5DQeW9qa5dQSteBk8QuDxTOqr4nsUZQbddwaw+Z3k6tp7+6fc0vEGyTPLN qi/iV8S47rcwpoq+vO1+wNGA48kVA0OLaDYHtVkmV5+f3+P3f/nE5cecvlyovHpfrn/fklmC Zma3flQ6bfzhnPaiuOzrUrnS22v7SvyUWIozEg21mIuKEwEwRMkstwIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170324110320epcas5p2d01260c2e7e02f578f7f541ecaadb3e8 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170321183839epcas2p1de828034e7360ea8ea365861b9335626 X-RootMTR: 20170321183839epcas2p1de828034e7360ea8ea365861b9335626 References: <20170321183747.32450-1-andriy.shevchenko@linux.intel.com> <58D1D00F.40300@samsung.com> <1490188199.19767.164.camel@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2017년 03월 22일 22:09, Andy Shevchenko wrote: > On Wed, 2017-03-22 at 10:14 +0900, Chanwoo Choi wrote: >> Hi, >> >> On 2017년 03월 22일 03:37, Andy Shevchenko wrote: >>> The commit 942c7924a51e introduced a check for ACPI handle for the >>> device that never appears on any ACPI-enabled platform so far. It >>> seems >>> a confusion with extcon-intel-int3496 which does support ACPI- >>> enabled >>> platforms. >> >> Only for the reason that there is no any usecase until now, >> and remove the confusion between extcon-usb-gpio and extcon-intel- >> int3496. >> Should we revert it? > > >> >> I think that both extcon-usb-gpio and extcon-intel-int3496 >> driver are not same operation perfectly. Also, the filename >> of extcon-intel-int3496 has specific name. Instead, extcon-usb-gpio.c >> is more common device driver. >> >> Can the extcon-intel-int3496.c support the everything on acpi side? > > For my understanding we have the only driver for now for USB mux in the > kernel for ACPI-enabled platforms. > > Besides confusion, it makes harder to fix a real bugs in at least GPIO > ACPI library since we need to amend any user of it first. While > confusion is here, I can't do anything to not possible break the > functionality of the driver in a real use case if any (I doubt there is > any in this particular case). > > So, my opinion here is "yes, we should revert it until we have a > confirmation that there is a product which is using this among with > ACPI" (which I doubt ever exists). Because you told me there was not any use case of extcon-usb-gpioc.c on acpi side. But, I think that it is not enough as the reason. Because I already mentioned, 1. "The both extcon-usb-gpio and extcon-intel-int3496 driver are not same operation perfectly." It two driver are same operation and there is no use case on acpi side, I may agree your suggestion. But, in this case, they are different between two drivers. 2. Also, extcon-intel-int3496 has the specific name 'int3496'. I think that it only depends on the specific device driver on acpi side. I don't think it cover all of use case on acpi side. > >> >>> >>> Revert commit 942c7924a51e to avoid any confusion in the future. >>> >>> Cc: Lu Baolu >>> Signed-off-by: Andy Shevchenko >>> --- >>> drivers/extcon/extcon-usb-gpio.c | 3 +-- >>> 1 file changed, 1 insertion(+), 2 deletions(-) >>> >>> diff --git a/drivers/extcon/extcon-usb-gpio.c >>> b/drivers/extcon/extcon-usb-gpio.c >>> index d47573a31e17..9c925b05b7aa 100644 >>> --- a/drivers/extcon/extcon-usb-gpio.c >>> +++ b/drivers/extcon/extcon-usb-gpio.c >>> @@ -26,7 +26,6 @@ >>> #include >>> #include >>> #include >>> -#include >>> #include >>> >>> #define USB_GPIO_DEBOUNCE_MS 20 /* ms */ >>> @@ -111,7 +110,7 @@ static int usb_extcon_probe(struct >>> platform_device *pdev) >>> struct usb_extcon_info *info; >>> int ret; >>> >>> - if (!np && !ACPI_HANDLE(dev)) >>> + if (!np) >>> return -EINVAL; >>> >>> info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL); >>> >> >> > -- Best Regards, Chanwoo Choi Samsung Electronics