All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Fastabend <john.fastabend@gmail.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v7 0/2] XDP support for ixgbe
Date: Sat, 25 Mar 2017 16:55:37 -0700	[thread overview]
Message-ID: <58D70379.3030802@gmail.com> (raw)
In-Reply-To: <CALDO+SYA4a37ePhzSPwbqqnCngU6uudeiCGvGoXMPU3MbX4W2g@mail.gmail.com>

On 17-03-24 03:22 PM, William Tu wrote:
> On Thu, Mar 23, 2017 at 9:30 PM, John Fastabend
> <john.fastabend@gmail.com> wrote:
>> This version fixes a couple issues with q_vector allocation and query on XDP
>> program.
>>
>> ---
>>
>> John Fastabend (2):
>>       ixgbe: add XDP support for pass and drop actions
>>       ixgbe: add support for XDP_TX action
>>
>>
>>  drivers/net/ethernet/intel/ixgbe/ixgbe.h         |   23 +
>>  drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c |   29 +
>>  drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c     |   78 +++-
>>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c    |  434 +++++++++++++++++++---
>>  4 files changed, 490 insertions(+), 74 deletions(-)
>>
>> --
>> Signature
> 
> Thanks. I tested using samples/bpf/xdp1 and xdp2 using ping and dpdk
> pktgen. Both work OK.
> 
> When enabling xdp, dmesg shows:
> [12270.610462] pps pps0: new PPS source ptp6
> [12270.610465] ixgbe 0000:05:00.0: registered PHC device on enp5s0f0
> [12271.619018] ixgbe 0000:05:00.0: removed PHC on enp5s0f0
> [12271.943334] ixgbe 0000:05:00.0: Multiqueue Enabled: Rx Queue count
> = 16, Tx Queue count = 16 XDP Queue count = 0
> [12272.011324] pps pps0: new PPS source ptp6
> [12272.011326] ixgbe 0000:05:00.0: registered PHC device on enp5s0f0
> [12276.477066] ixgbe 0000:05:00.0 enp5s0f0: NIC Link is Up 10 Gbps,
> Flow Control: None
> 
> I'm not sure it's important or not.
> Regards,
> William
> 

Well that is a bit odd. When you load the XDP program we should see a
"XDP Queue count" equal to the cpu count from /proc/cpuinfo. But if this
is from either after unloading a XDP program or from initial loading the
module before an XDP program is loaded than zero is expected. The queues
are only added after the XDP program is loaded.

Thanks,
John


  reply	other threads:[~2017-03-25 23:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-24  4:30 [Intel-wired-lan] [PATCH v7 0/2] XDP support for ixgbe John Fastabend
2017-03-24  4:31 ` [Intel-wired-lan] [PATCH v7 1/2] ixgbe: add XDP support for pass and drop actions John Fastabend
2017-03-25  2:23   ` Jeff Kirsher
2017-03-25 19:04     ` John Fastabend
2017-03-26  0:58       ` Jeff Kirsher
2017-03-28 23:10   ` Bowers, AndrewX
2017-04-11 20:31   ` Tantilov, Emil S
2017-03-24  4:31 ` [Intel-wired-lan] [PATCH v7 2/2] ixgbe: add support for XDP_TX action John Fastabend
2017-03-28 23:11   ` Bowers, AndrewX
2017-03-29  1:39   ` Dmitry Popov
2017-03-24 22:22 ` [Intel-wired-lan] [PATCH v7 0/2] XDP support for ixgbe William Tu
2017-03-25 23:55   ` John Fastabend [this message]
2017-03-27 18:38     ` William Tu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58D70379.3030802@gmail.com \
    --to=john.fastabend@gmail.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.