From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhang, Jerry (Junwei)" Subject: Re: [PATCH 3/3] drm/amdgpu: Fix multi-level page table bugs for large BOs Date: Wed, 29 Mar 2017 10:54:03 +0800 Message-ID: <58DB21CB.4090800@amd.com> References: <1490749231-16157-1-git-send-email-Felix.Kuehling@amd.com> <1490749231-16157-4-git-send-email-Felix.Kuehling@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1490749231-16157-4-git-send-email-Felix.Kuehling-5C7GfCeVMHo@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Felix Kuehling , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Christian.Koenig-5C7GfCeVMHo@public.gmane.org, David1.Zhou-5C7GfCeVMHo@public.gmane.org Cc: Alexander.Deucher-5C7GfCeVMHo@public.gmane.org, Kent.Russell-5C7GfCeVMHo@public.gmane.org T24gMDMvMjkvMjAxNyAwOTowMCBBTSwgRmVsaXggS3VlaGxpbmcgd3JvdGU6Cj4gRml4IHRoZSBz dGFydC9lbmQgYWRkcmVzcyBjYWxjdWxhdGlvbiBmb3IgYWRkcmVzcyByYW5nZXMgdGhhdCBzcGFu Cj4gbXVsdGlwbGUgcGFnZSBkaXJlY3RvcmllcyBpbiBhbWRncHVfdm1fYWxsb2NfbGV2ZWxzLgo+ Cj4gQWRkIFdBUk5fT05zIGlmIHBhZ2UgdGFibGVzIGFyZW4ndCBmb3VuZC4gT3RoZXJ3aXNlIHRo ZSBwYWdlIHRhYmxlCj4gdXBkYXRlIHdvdWxkIGp1c3QgZmFpbCBzaWxlbnRseS4KPgo+IFNpZ25l ZC1vZmYtYnk6IEZlbGl4IEt1ZWhsaW5nIDxGZWxpeC5LdWVobGluZ0BhbWQuY29tPgo+IC0tLQo+ ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3ZtLmMgfCAxMyArKysrKysrKysr LS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkK Pgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdm0uYyBi L2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV92bS5jCj4gaW5kZXggODE4NzQ3Zi4u NDRhYTAzOSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVf dm0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV92bS5jCj4gQEAg LTI3OCw2ICsyNzgsOCBAQCBzdGF0aWMgaW50IGFtZGdwdV92bV9hbGxvY19sZXZlbHMoc3RydWN0 IGFtZGdwdV9kZXZpY2UgKmFkZXYsCj4gICAJZnJvbSA9IChzYWRkciA+PiBzaGlmdCkgJSBhbWRn cHVfdm1fbnVtX2VudHJpZXMoYWRldiwgbGV2ZWwpOwo+ICAgCXRvID0gKGVhZGRyID4+IHNoaWZ0 KSAlIGFtZGdwdV92bV9udW1fZW50cmllcyhhZGV2LCBsZXZlbCk7Cj4KPiArCVdBUk5fT04oZnJv bSA+IHRvKTsKPiArCj4gICAJaWYgKHRvID4gcGFyZW50LT5sYXN0X2VudHJ5X3VzZWQpCj4gICAJ CXBhcmVudC0+bGFzdF9lbnRyeV91c2VkID0gdG87Cj4KPiBAQCAtMzEyLDggKzMxNCwxMSBAQCBz dGF0aWMgaW50IGFtZGdwdV92bV9hbGxvY19sZXZlbHMoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFk ZXYsCj4gICAJCX0KPgo+ICAgCQlpZiAobGV2ZWwgPCBhZGV2LT52bV9tYW5hZ2VyLm51bV9sZXZl bCkgewo+IC0JCQlyID0gYW1kZ3B1X3ZtX2FsbG9jX2xldmVscyhhZGV2LCB2bSwgZW50cnksIHNh ZGRyLAo+IC0JCQkJCQkgICBlYWRkciwgbGV2ZWwpOwo+ICsJCQl1aW50NjRfdCBzdWJfc2FkZHIg PSAocHRfaWR4ID09IGZyb20pID8gc2FkZHIgOiAwOwo+ICsJCQl1aW50NjRfdCBzdWJfZWFkZHIg PSAocHRfaWR4ID09IHRvKSA/IGVhZGRyIDoKPiArCQkJCSgoMSA8PCBzaGlmdCkgLSAxKTsKPiAr CQkJciA9IGFtZGdwdV92bV9hbGxvY19sZXZlbHMoYWRldiwgdm0sIGVudHJ5LCBzdWJfc2FkZHIs Cj4gKwkJCQkJCSAgIHN1Yl9lYWRkciwgbGV2ZWwpOwoKRG8geW91IG1lYW4gdG8gY3JlYXRlIGEg ZnVsbCBzdWItcHQgaWYgcHRfaWR4ICE9IGZyb20gYW5kICE9IHRvPwpJIGRpZG4ndCBjYXRjaCBp dCB1cCBjbGVhci4KCkluIG15IHBlcnNwZWN0aXZlLCB3ZSBtYXkgbmVlZCB0byBjbGVhciB0aGUg c2FkZHIgYW5kIGVhZGRyIHVwcGVyIGxldmVsIGJpdCAKYmVmb3JlIGdvaW5nIG9uIHRvIGFsbG9j YXRlIHRoZSBuZXh0IGxldmVsIFBULgpPdGhlcndpc2UsIHRoZSBudW1iZXIgb2YgbmV4dCBQVCBl bnRyeSB3aWxsIGJlIGluY29ycmVjdCwgbW9yZSB0aGFuIG51bV9lbnRyaWVzIAphcyB0aGUgdXBw ZXIgbGV2ZWwgUFQgbnVtYmVyIGNhbGN1bGF0ZWQgaW4uCgplLmcuCnRoZXJlIGlzIGEgYWRkcmVz cyBjb250YWlucwpQRCArIFBUMSArIFBUMiArIFBUMwoKZm9yIHRoZSBmaXJzdCByb3VuZCwgd2Ug Y291bGQgZ2V0IGNvcnJlY3QgImZyb20iIGFuZCAidG8iIGFkZHJlc3Mgd2l0aCByaWdodCAKInNo aWZ0IigzIGJsb2NrcyksIHRoZW4gd2FsayBvdmVyIHRoZSBhZGRyZXNzIHNwYWNlIGluIFBEIHJh bmdlLgoKVGhlbiBmb3IgdGhlIDJuZCByb3VuZCwgd2UgY2Fubm90IGdldCB0aGUgZXhwZWN0ZWQg ImZyb20iIGFuZCAidG8iIGFkZHJlc3Mgd2l0aCAKInNoaWZ0IigyIGJsb2NrcyksIGFzIGl0IHdh bGtzIG92ZXIgdGhlIGFkZHJlc3Mgc3BhY2UgaW4gUEQgKyBQVDEgcmFuZ2UuCldoaWxlIHdlJ2Qg bGlrZSBpdCdzIGluIHJhbmdlIFBUMSBpbmRlZWQuCgpUaGUgZmF1bHQgd2F5IGdvZXMgb24gd2l0 aCBsYXRlciByb3VuZC4KClBlcmhhcHMsIHRoYXQncyB0aGUgcm9vdCBjYXVzZSBhYm91dCB0aGUg aXNzdWUgeW91IGZhY2UuCgpKZXJyeS4KCj4gICAJCQlpZiAocikKPiAgIAkJCQlyZXR1cm4gcjsK PiAgIAkJfQo+IEBAIC05NTcsOSArOTYyLDExIEBAIHN0YXRpYyBzdHJ1Y3QgYW1kZ3B1X2JvICph bWRncHVfdm1fZ2V0X3B0KHN0cnVjdCBhbWRncHVfcHRlX3VwZGF0ZV9wYXJhbXMgKnAsCj4gICAJ CWVudHJ5ID0gJmVudHJ5LT5lbnRyaWVzW2lkeF07Cj4gICAJfQo+Cj4gLQlpZiAobGV2ZWwpCj4g KwlpZiAoV0FSTl9PTihsZXZlbCkpCj4gICAJCXJldHVybiBOVUxMOwo+Cj4gKwlXQVJOX09OKCFl bnRyeS0+Ym8pOwo+ICsKPiAgIAlyZXR1cm4gZW50cnktPmJvOwo+ICAgfQo+Cj4KX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxp c3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==