From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhang, Jerry (Junwei)" Subject: Re: [PATCH 3/3] drm/amdgpu: Fix multi-level page table bugs for large BOs Date: Wed, 29 Mar 2017 15:18:19 +0800 Message-ID: <58DB5FBB.8010309@amd.com> References: <1490749231-16157-1-git-send-email-Felix.Kuehling@amd.com> <1490749231-16157-4-git-send-email-Felix.Kuehling@amd.com> <58DB21CB.4090800@amd.com> <58DB4D02.7020903@amd.com> <8acdbd65-f99d-3e0e-b61b-318cf27d7a3b@vodafone.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <8acdbd65-f99d-3e0e-b61b-318cf27d7a3b-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= , "Kuehling, Felix" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "Koenig, Christian" , "Zhou, David(ChunMing)" Cc: "Deucher, Alexander" , "Russell, Kent" T24gMDMvMjkvMjAxNyAwMjo1MiBQTSwgQ2hyaXN0aWFuIEvDtm5pZyB3cm90ZToKPiBBbSAyOS4w My4yMDE3IHVtIDA3OjU4IHNjaHJpZWIgWmhhbmcsIEplcnJ5IChKdW53ZWkpOgo+PiBIaSBGZWxp eCwKPj4KPj4gVGhhbmtzIGZvciB5b3VyIGlsbHVzdHJhdGlvbiB3aXRoIHBhdGllbmNlLgo+PiBJ IGdvdCB5b3VyIG1lYW5pbmcgdGhlbiwgYW5kIHRoYW5rcyB0byBmaXggdGhhdC4KPj4KPj4gPiBJ IHRoaW5rIHlvdSdyZSByaWdodCwgdGhlcmUgYXJlIHNvbWUgZXh0cmEgaGlnaCBiaXRzIGluIHNh ZGRyIGFuZCBlYWRkciwgYnV0Cj4+ID4gdGhleSBnZXQgZGlzY2FyZGVkIGJ5IHRoZSBtb2R1bG8t ZGl2aXNpb24gaW4gdGhlIG5leHQgcmVjdXJzaW9uIGxldmVsLiBGb3IKPj4gPiBhZGRlZCBjbGFy aXR5IHRoZSBtb2R1bG8gZGl2aXNpb24gKG9yIG1hc2tpbmcgb2YgaGlnaCBiaXRzKSBjb3VsZCBi ZSBtb3ZlZCB1cAo+PiA+IHRvIHRoZSBjYWxsZXIuCj4+Cj4+IEl0IG1heSBiZSBtb3JlIGNsZWFy IGlmIG1vZHVsby1kaXZpc2lvbiBjYWxsZWQgYmVmb3JlIHRoZSBjYWxsZXIuCj4KPiBZZWFoLCBp bmRlZWQgdGhhdCBpc24ndCBlYXN5IHRvIGdldCBvbiBmaXJzdCBnbGFuY2UuCgpVbmRlcnN0YW5k aW5nIDopCgo+Cj4gUGxlYXNlIGNsZWFuIHRoYXQgdXAgYW5kIGFsc28gcmVtb3ZlIGFsbCB0aG9z ZSBXQVJOX09OKCksIHdlIGRvbid0IHdhbnQgdG8gc3BhbQo+IHRoZSBzeXN0ZW0gbG9nIHdpdGgg YmFja3RyYWNlcyBsaWtlIHRoaXMuCj4KPiBSZWdhcmRzLAo+IENocmlzdGlhbi4KPgo+PiBBbnl3 YXksCj4+IFJldmlld2VkLWJ5OiBKdW53ZWkgWmhhbmcgPEplcnJ5LlpoYW5nQGFtZC5jb20+Cj4+ Cj4+Cj4+IE9uIDAzLzI5LzIwMTcgMTE6MjQgQU0sIEt1ZWhsaW5nLCBGZWxpeCB3cm90ZToKPj4+ IEhpIEplcnJ5LAo+Pj4KPj4+IExldCBtZSBjbGFyaWZ5IG15IHVuZGVyc3RhbmRpbmcgb2YgdGhl IHByb2JsZW0gYW5kIHRoZSBpbnRlbnRpb24gb2YgdGhlIGZpeC4KPj4+Cj4+PiBBZGRyZXNzIHJh bmdlIHBlciBwYWdlOiA0S0IKPj4+IEFkZHJlc3MgcmFuZ2UgcGVyIFBUIChsZXZlbCAzKTogMk1C Cj4+PiBBZGRyZXNzIHJhbmdlIHBlciBQRCAobGV2ZWwgMik6IDFHQgo+Pj4gQWRkcmVzcyByYW5n ZSBwZXIgUEQgKGxldmVsIDEpOiA1MTJHQgo+Pj4gQWRkcmVzcyByYW5nZSBwZXIgUEQgKGxldmVs IDApOiAyNTZUQgo+Pj4KPj4+IEltYWdpbmUgZm9yIGV4YW1wbGUgYSBtYXBwaW5nIHRoYXQgc3Bh bnMgbXVsdGlwbGUgbGV2ZWwgMiBwYWdlIGRpcmVjdG9yaWVzLiBTYXkKPj4+IGZyb20gMC41R0Ig dG8gMi41R0IuCj4+Pgo+Pj4gQXQgbGV2ZWwgMDoKPj4+IGZyb20gPSAwCj4+PiB0byA9IDAKPj4+ Cj4+PiBBdCBsZXZlbCAxOgo+Pj4gZnJvbSA9IDAKPj4+IHRvID0gMgo+Pj4KPj4+IFNvIGZvciBs ZXZlbCAyIGFtZGdwdV92bV9hbGxvY19sZXZlbHMgZ2V0cyBjYWxsZWQgMyB0aW1lcyAocHRfaWR4 ID0gWzAuLjJdKS4KPj4+IFdpdGhvdXQgbXkgY2hhbmdlLCBpdCBnZXRzIGNhbGxlZCB3aXRoIHRo ZSBzYW1lIHNhZGRyIGFuZCBlYWRkciAzIHRpbWVzLiBTbyBpdAo+Pj4gY2FsY3VsYXRlcyB0aGUg c2FtZSAiZnJvbSIgYW5kICJ0byIgZWFjaCB0aW1lOgo+Pj4gZnJvbSA9IDI1NiAlIDUxMiA9IDI1 Ngo+Pj4gdG8gPSA3NjcgJSA1MTIgPSAyNTUKPj4+Cj4+PiBPYnZpb3VzbHkgdGhhdCBkb2Vzbid0 IHdvcmsuIFdoYXQgd2UgcmVhbGx5IHdhbnQgaXMgdGhpcyAoZnJvbS4udG8gaW4gbGV2ZWwgMgo+ Pj4gd2hlbiBjYWxsZWQgZm9yIHB0X2lkeCB2YWx1ZXMgZnJvbSBsZXZlbCAxKToKPj4+Cj4+PiBG b3IgcHRfaWR4PTAgd2Ugd2FudCB0byBmaWxsIHRoZSBzZWNvbmQgaGFsZiBvZiB0aGUgbGV2ZWwg MiBwYWdlIGRpcmVjdG9yeSB3aXRoCj4+PiBwYWdlIHRhYmxlczoKPj4+IGZyb20gPSAyNTYKPj4+ IHRvID0gNTExCj4+Pgo+Pj4gRm9yIHB0X2lkeD0xIHdlIG5lZWQgdG8gZmlsbCB0aGUgZW50aXJl IGxldmVsIDIgcGFnZSBkaXJlY3RvcmllcyB3aXRoIHBhZ2UKPj4+IHRhYmxlczoKPj4+IGZyb20g PSAwCj4+PiB0byA9IDUxMQo+Pj4KPj4+IEZvciBwdF9pZHg9MiB3ZSB3YW50IHRvIGZpbGwgdGhl IGZpcnN0IGhhbGYgb2YgdGhlIGxldmVsIDIgcGFnZSBkaXJlY3Rvcnkgd2l0aAo+Pj4gcGFnZSB0 YWJsZXM6Cj4+PiBmcm9tID0gMAo+Pj4gdG8gPSAyNTUKPj4+Cj4+PiBUaGlzIGNyZWF0ZXMgYSBj b250aWd1b3VzIHJhbmdlIG9mIHBhZ2UgdGFibGVzIGFjcm9zcyB0aGUgdGhyZWUgbGV2ZWwgMiBw YWdlCj4+PiBkaXJlY3RvcmllcyB0aGF0IGFyZSBzcGFubmVkIGJ5IHRoZSBhbGxvY2F0aW9uLiBN eSBjaGFuZ2UgYWNoaWV2ZXMgdGhhdC4KPj4+Cj4+PiBJIHRoaW5rIHlvdSdyZSByaWdodCwgdGhl cmUgYXJlIHNvbWUgZXh0cmEgaGlnaCBiaXRzIGluIHNhZGRyIGFuZCBlYWRkciwgYnV0Cj4+PiB0 aGV5IGdldCBkaXNjYXJkZWQgYnkgdGhlIG1vZHVsby1kaXZpc2lvbiBpbiB0aGUgbmV4dCByZWN1 cnNpb24gbGV2ZWwuIEZvcgo+Pj4gYWRkZWQgY2xhcml0eSB0aGUgbW9kdWxvIGRpdmlzaW9uIChv ciBtYXNraW5nIG9mIGhpZ2ggYml0cykgY291bGQgYmUgbW92ZWQgdXAKPj4+IHRvIHRoZSBjYWxs ZXIuCj4+Pgo+Pj4gUmVnYXJkcywKPj4+ICAgIEZlbGl4Cj4+Pgo+Pj4KPj4+IC0tCj4+PiBGIGUg bCBpIHggICBLIHUgZSBoIGwgaSBuIGcKPj4+IFNNVFMgU29mdHdhcmUgRGV2ZWxvcG1lbnQgRW5n aW5lZXIgfCBWZXJ0aWNhbCBXb3Jrc3RhdGlvbi9Db21wdXRlCj4+PiAxIENvbW1lcmNlIFZhbGxl eSBEci4gRWFzdCwgTWFya2hhbSwgT04gTDNUIDdYNiBDYW5hZGEKPj4+IChPKSArMSgyODkpNjk1 LTE1OTcKPj4+ICAgICBfICAgICBfICAgXyAgIF9fX19fICAgX19fX18KPj4+ICAgIC8gXCAgIHwg XCAvIHwgfCAgXyAgXCAgXCBfICB8Cj4+PiAgIC8gQSBcICB8IFxNLyB8IHwgfEQpICkgIC98X3wg fAo+Pj4gL18vIFxfXCB8X3wgfF98IHxfX19fXy8gfF9fLyBcfCAgIGZhY2Vib29rLmNvbS9BTUQg fCBhbWQuY29tCj4+PiAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4+PiAqRnJvbToqIFpoYW5nLCBK ZXJyeQo+Pj4gKlNlbnQ6KiBUdWVzZGF5LCBNYXJjaCAyOCwgMjAxNyAxMDo1NDowMyBQTQo+Pj4g KlRvOiogS3VlaGxpbmcsIEZlbGl4OyBhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZzsgS29l bmlnLCBDaHJpc3RpYW47IFpob3UsCj4+PiBEYXZpZChDaHVuTWluZykKPj4+ICpDYzoqIERldWNo ZXIsIEFsZXhhbmRlcjsgUnVzc2VsbCwgS2VudAo+Pj4gKlN1YmplY3Q6KiBSZTogW1BBVENIIDMv M10gZHJtL2FtZGdwdTogRml4IG11bHRpLWxldmVsIHBhZ2UgdGFibGUgYnVncyBmb3IKPj4+IGxh cmdlIEJPcwo+Pj4gT24gMDMvMjkvMjAxNyAwOTowMCBBTSwgRmVsaXggS3VlaGxpbmcgd3JvdGU6 Cj4+Pj4gRml4IHRoZSBzdGFydC9lbmQgYWRkcmVzcyBjYWxjdWxhdGlvbiBmb3IgYWRkcmVzcyBy YW5nZXMgdGhhdCBzcGFuCj4+Pj4gbXVsdGlwbGUgcGFnZSBkaXJlY3RvcmllcyBpbiBhbWRncHVf dm1fYWxsb2NfbGV2ZWxzLgo+Pj4+Cj4+Pj4gQWRkIFdBUk5fT05zIGlmIHBhZ2UgdGFibGVzIGFy ZW4ndCBmb3VuZC4gT3RoZXJ3aXNlIHRoZSBwYWdlIHRhYmxlCj4+Pj4gdXBkYXRlIHdvdWxkIGp1 c3QgZmFpbCBzaWxlbnRseS4KPj4+Pgo+Pj4+IFNpZ25lZC1vZmYtYnk6IEZlbGl4IEt1ZWhsaW5n IDxGZWxpeC5LdWVobGluZ0BhbWQuY29tPgo+Pj4+IC0tLQo+Pj4+ICAgZHJpdmVycy9ncHUvZHJt L2FtZC9hbWRncHUvYW1kZ3B1X3ZtLmMgfCAxMyArKysrKysrKysrLS0tCj4+Pj4gICAxIGZpbGUg Y2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPj4+Pgo+Pj4+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdm0uYwo+Pj4+IGIvZHJp dmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3ZtLmMKPj4+PiBpbmRleCA4MTg3NDdmLi40 NGFhMDM5IDEwMDY0NAo+Pj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdw dV92bS5jCj4+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3ZtLmMK Pj4+PiBAQCAtMjc4LDYgKzI3OCw4IEBAIHN0YXRpYyBpbnQgYW1kZ3B1X3ZtX2FsbG9jX2xldmVs cyhzdHJ1Y3QgYW1kZ3B1X2RldmljZQo+Pj4+ICphZGV2LAo+Pj4+ICAgICAgICBmcm9tID0gKHNh ZGRyID4+IHNoaWZ0KSAlIGFtZGdwdV92bV9udW1fZW50cmllcyhhZGV2LCBsZXZlbCk7Cj4+Pj4g ICAgICAgIHRvID0gKGVhZGRyID4+IHNoaWZ0KSAlIGFtZGdwdV92bV9udW1fZW50cmllcyhhZGV2 LCBsZXZlbCk7Cj4+Pj4KPj4+PiArICAgICBXQVJOX09OKGZyb20gPiB0byk7Cj4+Pj4gKwo+Pj4+ ICAgICAgICBpZiAodG8gPiBwYXJlbnQtPmxhc3RfZW50cnlfdXNlZCkKPj4+PiAgICAgICAgICAg ICAgICBwYXJlbnQtPmxhc3RfZW50cnlfdXNlZCA9IHRvOwo+Pj4+Cj4+Pj4gQEAgLTMxMiw4ICsz MTQsMTEgQEAgc3RhdGljIGludCBhbWRncHVfdm1fYWxsb2NfbGV2ZWxzKHN0cnVjdCBhbWRncHVf ZGV2aWNlCj4+Pj4gKmFkZXYsCj4+Pj4gICAgICAgICAgICAgICAgfQo+Pj4+Cj4+Pj4gICAgICAg ICAgICAgICAgaWYgKGxldmVsIDwgYWRldi0+dm1fbWFuYWdlci5udW1fbGV2ZWwpIHsKPj4+PiAt ICAgICAgICAgICAgICAgICAgICAgciA9IGFtZGdwdV92bV9hbGxvY19sZXZlbHMoYWRldiwgdm0s IGVudHJ5LCBzYWRkciwKPj4+PiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgZWFkZHIsIGxldmVsKTsKPj4+PiArICAgICAgICAgICAgICAgICAgICAgdWlu dDY0X3Qgc3ViX3NhZGRyID0gKHB0X2lkeCA9PSBmcm9tKSA/IHNhZGRyIDogMDsKPj4+PiArICAg ICAgICAgICAgICAgICAgICAgdWludDY0X3Qgc3ViX2VhZGRyID0gKHB0X2lkeCA9PSB0bykgPyBl YWRkciA6Cj4+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKCgxIDw8IHNoaWZ0KSAt IDEpOwo+Pj4+ICsgICAgICAgICAgICAgICAgICAgICByID0gYW1kZ3B1X3ZtX2FsbG9jX2xldmVs cyhhZGV2LCB2bSwgZW50cnksIHN1Yl9zYWRkciwKPj4+PiArICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgc3ViX2VhZGRyLCBsZXZlbCk7Cj4+Pgo+Pj4gRG8g eW91IG1lYW4gdG8gY3JlYXRlIGEgZnVsbCBzdWItcHQgaWYgcHRfaWR4ICE9IGZyb20gYW5kICE9 IHRvPwo+Pj4gSSBkaWRuJ3QgY2F0Y2ggaXQgdXAgY2xlYXIuCj4+Pgo+Pj4gSW4gbXkgcGVyc3Bl Y3RpdmUsIHdlIG1heSBuZWVkIHRvIGNsZWFyIHRoZSBzYWRkciBhbmQgZWFkZHIgdXBwZXIgbGV2 ZWwgYml0Cj4+PiBiZWZvcmUgZ29pbmcgb24gdG8gYWxsb2NhdGUgdGhlIG5leHQgbGV2ZWwgUFQu Cj4+PiBPdGhlcndpc2UsIHRoZSBudW1iZXIgb2YgbmV4dCBQVCBlbnRyeSB3aWxsIGJlIGluY29y cmVjdCwgbW9yZSB0aGFuIG51bV9lbnRyaWVzCj4+PiBhcyB0aGUgdXBwZXIgbGV2ZWwgUFQgbnVt YmVyIGNhbGN1bGF0ZWQgaW4uCj4+Pgo+Pj4gZS5nLgo+Pj4gdGhlcmUgaXMgYSBhZGRyZXNzIGNv bnRhaW5zCj4+PiBQRCArIFBUMSArIFBUMiArIFBUMwo+Pj4KPj4+IGZvciB0aGUgZmlyc3Qgcm91 bmQsIHdlIGNvdWxkIGdldCBjb3JyZWN0ICJmcm9tIiBhbmQgInRvIiBhZGRyZXNzIHdpdGggcmln aHQKPj4+ICJzaGlmdCIoMyBibG9ja3MpLCB0aGVuIHdhbGsgb3ZlciB0aGUgYWRkcmVzcyBzcGFj ZSBpbiBQRCByYW5nZS4KPj4+Cj4+PiBUaGVuIGZvciB0aGUgMm5kIHJvdW5kLCB3ZSBjYW5ub3Qg Z2V0IHRoZSBleHBlY3RlZCAiZnJvbSIgYW5kICJ0byIgYWRkcmVzcyB3aXRoCj4+PiAic2hpZnQi KDIgYmxvY2tzKSwgYXMgaXQgd2Fsa3Mgb3ZlciB0aGUgYWRkcmVzcyBzcGFjZSBpbiBQRCArIFBU MSByYW5nZS4KPj4+IFdoaWxlIHdlJ2QgbGlrZSBpdCdzIGluIHJhbmdlIFBUMSBpbmRlZWQuCj4+ Pgo+Pj4gVGhlIGZhdWx0IHdheSBnb2VzIG9uIHdpdGggbGF0ZXIgcm91bmQuCj4+Pgo+Pj4gUGVy aGFwcywgdGhhdCdzIHRoZSByb290IGNhdXNlIGFib3V0IHRoZSBpc3N1ZSB5b3UgZmFjZS4KPj4+ Cj4+PiBKZXJyeS4KPj4+Cj4+Pj4gICAgICAgICAgICAgICAgICAgICAgICBpZiAocikKPj4+PiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIHI7Cj4+Pj4gICAgICAgICAgICAg ICAgfQo+Pj4+IEBAIC05NTcsOSArOTYyLDExIEBAIHN0YXRpYyBzdHJ1Y3QgYW1kZ3B1X2JvICph bWRncHVfdm1fZ2V0X3B0KHN0cnVjdAo+Pj4+IGFtZGdwdV9wdGVfdXBkYXRlX3BhcmFtcyAqcCwK Pj4+PiAgICAgICAgICAgICAgICBlbnRyeSA9ICZlbnRyeS0+ZW50cmllc1tpZHhdOwo+Pj4+ICAg ICAgICB9Cj4+Pj4KPj4+PiAtICAgICBpZiAobGV2ZWwpCj4+Pj4gKyAgICAgaWYgKFdBUk5fT04o bGV2ZWwpKQo+Pj4+ICAgICAgICAgICAgICAgIHJldHVybiBOVUxMOwo+Pj4+Cj4+Pj4gKyAgICAg V0FSTl9PTighZW50cnktPmJvKTsKPj4+PiArCj4+Pj4gICAgICAgIHJldHVybiBlbnRyeS0+Ym87 Cj4+Pj4gICB9Cj4+Pj4KPj4+Pgo+PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwo+PiBhbWQtZ2Z4IG1haWxpbmcgbGlzdAo+PiBhbWQtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwo+PiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2FtZC1nZngKPgo+Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdm eAo=