From: "Zhang, Jerry (Junwei)" <Jerry.Zhang-5C7GfCeVMHo@public.gmane.org>
To: "Deucher,
Alexander" <Alexander.Deucher-5C7GfCeVMHo@public.gmane.org>,
"amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH v2] drm/amdgpu: fix vm pte pde flags to 64-bit for sdma (v2)
Date: Thu, 30 Mar 2017 10:12:09 +0800 [thread overview]
Message-ID: <58DC6979.20801@amd.com> (raw)
In-Reply-To: <BN6PR12MB1652349B54D5658B4864EB17F7350-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
On 03/29/2017 11:24 PM, Deucher, Alexander wrote:
>> -----Original Message-----
>> From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf
>> Of Junwei Zhang
>> Sent: Wednesday, March 29, 2017 3:19 AM
>> To: amd-gfx@lists.freedesktop.org
>> Cc: Zhang, Jerry
>> Subject: [PATCH v2] drm/amdgpu: fix vm pte pde flags to 64-bit for sdma (v2)
>>
>> v2: fix for all sdma engines
>
> What about cik_sdma.c and si_dma.c?
Errr, missed that.
I will fix it in another patch.
Please squash them together for upstream if possible.
Jerry
>
> Alex
>
>>
>> Change-Id: I15f8f429009058ba36c7340031c9fa178d716aef
>> Signed-off-by: Junwei Zhang <Jerry.Zhang@amd.com>
>> ---
>> drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c | 4 ++--
>> drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 4 ++--
>> drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 4 ++--
>> 3 files changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c
>> b/drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c
>> index bcc14ed..702fa5f 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c
>> @@ -804,8 +804,8 @@ static void sdma_v2_4_vm_set_pte_pde(struct
>> amdgpu_ib *ib, uint64_t pe,
>> ib->ptr[ib->length_dw++] =
>> SDMA_PKT_HEADER_OP(SDMA_OP_GEN_PTEPDE);
>> ib->ptr[ib->length_dw++] = lower_32_bits(pe); /* dst addr */
>> ib->ptr[ib->length_dw++] = upper_32_bits(pe);
>> - ib->ptr[ib->length_dw++] = flags; /* mask */
>> - ib->ptr[ib->length_dw++] = 0;
>> + ib->ptr[ib->length_dw++] = lower_32_bits(flags); /* mask */
>> + ib->ptr[ib->length_dw++] = upper_32_bits(flags);
>> ib->ptr[ib->length_dw++] = lower_32_bits(addr); /* value */
>> ib->ptr[ib->length_dw++] = upper_32_bits(addr);
>> ib->ptr[ib->length_dw++] = incr; /* increment size */
>> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
>> b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
>> index 085cf63..cfd968e 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
>> @@ -1013,8 +1013,8 @@ static void sdma_v3_0_vm_set_pte_pde(struct
>> amdgpu_ib *ib, uint64_t pe,
>> ib->ptr[ib->length_dw++] =
>> SDMA_PKT_HEADER_OP(SDMA_OP_GEN_PTEPDE);
>> ib->ptr[ib->length_dw++] = lower_32_bits(pe); /* dst addr */
>> ib->ptr[ib->length_dw++] = upper_32_bits(pe);
>> - ib->ptr[ib->length_dw++] = flags; /* mask */
>> - ib->ptr[ib->length_dw++] = 0;
>> + ib->ptr[ib->length_dw++] = lower_32_bits(flags); /* mask */
>> + ib->ptr[ib->length_dw++] = upper_32_bits(flags);
>> ib->ptr[ib->length_dw++] = lower_32_bits(addr); /* value */
>> ib->ptr[ib->length_dw++] = upper_32_bits(addr);
>> ib->ptr[ib->length_dw++] = incr; /* increment size */
>> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
>> b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
>> index dcbef50..6cfb100 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
>> @@ -968,8 +968,8 @@ static void sdma_v4_0_vm_set_pte_pde(struct
>> amdgpu_ib *ib,
>> ib->ptr[ib->length_dw++] =
>> SDMA_PKT_HEADER_OP(SDMA_OP_PTEPDE);
>> ib->ptr[ib->length_dw++] = lower_32_bits(pe); /* dst addr */
>> ib->ptr[ib->length_dw++] = upper_32_bits(pe);
>> - ib->ptr[ib->length_dw++] = flags; /* mask */
>> - ib->ptr[ib->length_dw++] = 0;
>> + ib->ptr[ib->length_dw++] = lower_32_bits(flags); /* mask */
>> + ib->ptr[ib->length_dw++] = upper_32_bits(flags);
>> ib->ptr[ib->length_dw++] = lower_32_bits(addr); /* value */
>> ib->ptr[ib->length_dw++] = upper_32_bits(addr);
>> ib->ptr[ib->length_dw++] = incr; /* increment size */
>> --
>> 1.9.1
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>>https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2017-03-30 2:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 7:19 [PATCH v2] drm/amdgpu: fix vm pte pde flags to 64-bit for sdma (v2) Junwei Zhang
[not found] ` <1490771963-31598-1-git-send-email-Jerry.Zhang-5C7GfCeVMHo@public.gmane.org>
2017-03-29 7:20 ` Christian König
2017-03-29 15:24 ` Deucher, Alexander
[not found] ` <BN6PR12MB1652349B54D5658B4864EB17F7350-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-03-30 2:12 ` Zhang, Jerry (Junwei) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58DC6979.20801@amd.com \
--to=jerry.zhang-5c7gfcevmho@public.gmane.org \
--cc=Alexander.Deucher-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.