From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752572AbdDDGTN (ORCPT ); Tue, 4 Apr 2017 02:19:13 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:25938 "EHLO epoutp02.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751002AbdDDGTM (ORCPT ); Tue, 4 Apr 2017 02:19:12 -0400 X-AuditID: b6c32a2c-f79be6d0000051f7-64-58e33adc7ba7 MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="UTF-8" Message-id: <58E33ADC.1000005@samsung.com> Date: Tue, 04 Apr 2017 15:19:08 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Hans de Goede , MyungJoo Ham Cc: Takashi Iwai , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] extcon: intel-cht-wc: Make error messages consistent In-reply-to: <20170403112630.30625-1-hdegoede@redhat.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrDKsWRmVeSWpSXmKPExsWy7bCmlu4dq8cRBvtfGlu8OT6dyeLyrjls FrcbV7BZvNz8hsmBxeP9vqtsHn1bVjF6bD5d7fF5k1wAS1SqTUZqYkpqkUJqXnJ+SmZeuq2S d3C8c7ypmYGhrqGlhbmSQl5ibqqtkotPgK5bZg7QRiWFssScUqBQQGJxsZK+nU1RfmlJqkJG fnGJrVK0oaGRnqGBuZ6RkZGeiXGslZEpUElCakbHt5CCDuGKKzNOMjUw7uTvYuTgkBAwkeia 4NjFyAlkiklcuLeerYuRi0NIYCmjxKzTx5kgnHYmiaVfW9ghqkwkdl45xQpiCwnMYZToPc8P YvMKCEr8mHyPBWQos4C8xJFL2SBhZgFNia2717NDzLnHKPHh/wY2iHotiQXPHoLZLAKqEqdm nAGbzwYU3//iBlicX0BR4uqPx4wgtqhAhMTO+d/AakQEgiRufF/BCrHATuLSr8lgtrCAv8ST +0eYQWxOAUuJdx9nMYIslhCYzi5xYfsBRoiPZSU2HWCG+MVFou/3dRYIW1ji1fEtUD9KS/xd eguqt51RYvMckMdAnA5GifsrG1khqowl7j+4xwxxBZ9E7+8nTBALeCU62oQgSjwk5vz/xAZh O0rM/rkZGrw9jBL3tm1imsCoMAsp8GYhAm8WUuAtYGRexSiWWlCcm55abFpgqFecmFtcmpeu l5yfu4kRnPK0dHYw3lvgfYhRgINRiYe34/CjCCHWxLLiytxDjBIczEoivN8UHkcI8aYkVlal FuXHF5XmpBYfYjQFhv1EZinR5HxgOs4riTc0sTQwMTUzNjA2tLBUEufVWHktQkggPbEkNTs1 tSC1CKaPiYNTqoFRbOLbtS7fmMxWva/bs3E9Q2f20Uv5kXNuHtrC9z7/zkvNB3lP9yelGK/2 n3VvzfLm/jVrrKZf9OerVDCP3pMjfGnu7v23jExc99ec+pmhaL102dsjG48qtmzQfL78tuOK D/tnX67cNlm8xInbbmb4F4kpj3aw9v8sv2Y1Vf/gq4U7XKTPPWdyeqbEUpyRaKjFXFScCAD5 fujrjwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrJIsWRmVeSWpSXmKPExsVy+t9jQd07Vo8jDI7vUrB4c3w6k8XlXXPY LG43rmCzeLn5DZMDi8f7fVfZPPq2rGL02Hy62uPzJrkAlig3m4zUxJTUIoXUvOT8lMy8dFul 0BA3XQslhbzE3FRbpQhd35AgJYWyxJxSIM/IAA04OAe4Byvp2yW4ZXR8CynoEK64MuMkUwPj Tv4uRk4OCQETiZ1XTrFC2GISF+6tZ+ti5OIQEpjFKNE/8Sk7SIJXQFDix+R7LF2MHBzMAvIS Ry5lg4SZBdQlJs1bxAxR/4BRounTU1aIei2JBc8esoHYLAKqEqdmnAGbwwYU3//iBlicX0BR 4uqPx4wgM0UFIiS6T1SChEUEAiR+nupnh5hvJ3Hp12SwkcICvhJXlv1khNjVxyhx7c17FpAE p4ClxLuPsxgnMArOQnLqLIRTZyE5dQEj8ypGidSC5ILipPRco7zUcr3ixNzi0rx0veT83E2M 4Gh6Jr2D8fAu90OMAhyMSjy8C5weRQixJpYVV+YeYpTgYFYS4f2m8DhCiDclsbIqtSg/vqg0 J7X4EKMp0K8TmaVEk/OBkZ5XEm9oYm5ibmxgYW5paWKkJM7bOPtZuJBAemJJanZqakFqEUwf EwenVAOj5AwZJ3eb+BlHPfawLGfSsyo4J5c4l3vGiUkTDmlt/Mi3LvfzD+1EV769btvdLz5d MjV3o0Bd1NEHN1v9yqO1T9c86tWxvG22/Nz1uC1tb775qC/dwpwusMo/cO32K5dZ7OZOMF2z +JO4rNXSfovbB5lrLhwr/Sel2njpyONKrdi2suzeUo9jSizFGYmGWsxFxYkAKsgsfbwCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170404061908epcas5p4d5ced3a0ac4acdf7c3ab29755b53a822 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20170403112709epcas3p331d80584db95bebe4d0ce2a020ffdbf0 X-RootMTR: 20170403112709epcas3p331d80584db95bebe4d0ce2a020ffdbf0 References: <20170403112630.30625-1-hdegoede@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, The intel-cht-wc.c[1] was merged on only extcon-next branch. I think that this patch better to be squashed with patch[1]. [1] commit 6786e42f31637 ("extcon: intel-cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver") How about it? On 2017년 04월 03일 20:26, Hans de Goede wrote: > Before this commit the error messages were a mix of "Failed to ..." and > "Error ...ing ...". > > This commit makes all the error messages consistently use "Error ...ing". > > Signed-off-by: Hans de Goede > --- > drivers/extcon/extcon-intel-cht-wc.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/extcon/extcon-intel-cht-wc.c b/drivers/extcon/extcon-intel-cht-wc.c > index 0a05cc3..f1c43af 100644 > --- a/drivers/extcon/extcon-intel-cht-wc.c > +++ b/drivers/extcon/extcon-intel-cht-wc.c > @@ -252,7 +252,7 @@ static int cht_wc_extcon_sw_control(struct cht_wc_extcon_data *ext, bool enable) > val = enable ? mask : 0; > ret = regmap_update_bits(ext->regmap, CHT_WC_CHGRCTRL0, mask, val); > if (ret) > - dev_err(ext->dev, "Failed setting sw control: %d\n", ret); > + dev_err(ext->dev, "Error setting sw control: %d\n", ret); > > return ret; > } > @@ -288,7 +288,7 @@ static int cht_wc_extcon_probe(struct platform_device *pdev) > /* Register extcon device */ > ret = devm_extcon_dev_register(ext->dev, ext->edev); > if (ret) { > - dev_err(ext->dev, "Failed to register extcon device\n"); > + dev_err(ext->dev, "Error registering extcon device: %d\n", ret); > goto disable_sw_control; > } > > @@ -301,7 +301,7 @@ static int cht_wc_extcon_probe(struct platform_device *pdev) > ret = devm_request_threaded_irq(ext->dev, irq, NULL, cht_wc_extcon_isr, > IRQF_ONESHOT, pdev->name, ext); > if (ret) { > - dev_err(ext->dev, "Failed to request interrupt\n"); > + dev_err(ext->dev, "Error requesting interrupt: %d\n", ret); > goto disable_sw_control; > } > > @@ -310,7 +310,7 @@ static int cht_wc_extcon_probe(struct platform_device *pdev) > (int)~(CHT_WC_PWRSRC_VBUS | CHT_WC_PWRSRC_ID_GND | > CHT_WC_PWRSRC_ID_FLOAT)); > if (ret) { > - dev_err(ext->dev, "Failed to write the irq-mask: %d\n", ret); > + dev_err(ext->dev, "Error writing irq-mask: %d\n", ret); > goto disable_sw_control; > } > -- Best Regards, Chanwoo Choi Samsung Electronics