Re: [PATCH] drm/amdgpu: fix "fix 64bit division"

From: "Zhang, Jerry (Junwei)" <Jerry.Zhang-5C7GfCeVMHo@public.gmane.org>
To: "Christian König"
	<deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] drm/amdgpu: fix "fix 64bit division"
Date: Fri, 7 Apr 2017 16:55:50 +0800	[thread overview]
Message-ID: <58E75416.3010201@amd.com> (raw)
In-Reply-To: <1491554650-9691-1-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>


On 04/07/2017 04:44 PM, Christian König wrote:
> From: Christian König <christian.koenig@amd.com>
>
> The offset must be 64bit and add back the accidential dropped line.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Junwei Zhang <Jerry.Zhang@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> index c91f13b..ba11ff254 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> @@ -551,9 +551,10 @@ static unsigned long amdgpu_ttm_io_mem_pfn(struct ttm_buffer_object *bo,
>   {
>   	struct drm_mm_node *mm = bo->mem.mm_node;
>   	uint64_t size = mm->size;
> -	unsigned long offset = page_offset;
> +	uint64_t offset = page_offset;
>
>   	page_offset = do_div(offset, size);
> +	mm += offset;
>   	return (bo->mem.bus.base >> PAGE_SHIFT) + mm->start + page_offset;
>   }
>
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx