All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrey Konovalov <andrey.konovalov@linaro.org>
To: openembedded-devel <openembedded-devel@lists.openembedded.org>
Subject: Re: [meta-browser] [PATCH] chromium: fix null pointer dereference in V8 with gcc-6
Date: Fri, 7 Apr 2017 22:16:00 +0300	[thread overview]
Message-ID: <58E7E570.6070406@linaro.org> (raw)
In-Reply-To: <1491590447-19476-1-git-send-email-andrey.konovalov@linaro.org>

On 04/07/2017 09:40 PM, Andrey Konovalov wrote:
> This patch prevents "Aw Snap" error when loading a page with JavaScript.
>
> Tested by running:
> - chromium-wayland on Beagle X15
> - chromium-wayland on HiKey (with a separate patch to enable aarch64 build)
> - cromium on dragonboard-410c (with a separate patch to enable aarch64 build)
>
> Based on the fix for Gentoo's bug 588596:
> https://bugs.gentoo.org/show_bug.cgi?id=588596#c10
>
> Signed-off-by: Andrey Konovalov <andrey.konovalov@linaro.org>
> ---
>   recipes-browser/chromium/chromium.inc | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/recipes-browser/chromium/chromium.inc b/recipes-browser/chromium/chromium.inc
> index 60edccb..7e057ec 100644
> --- a/recipes-browser/chromium/chromium.inc
> +++ b/recipes-browser/chromium/chromium.inc
> @@ -15,7 +15,8 @@ CHROMIUM_BUILD_TYPE ??= "Release"
>   inherit gettext pythonnative
>
>   ARMFPABI_armv7a = "${@bb.utils.contains('TUNE_FEATURES', 'callconvention-hard', 'arm_float_abi=hard', 'arm_float_abi=softfp', d)}"
> -GYP_DEFINES += "${ARMFPABI} release_extra_cflags='-Wno-error=unused-local-typedefs' sysroot=''"
> +GYP_DEFINES += " ${ARMFPABI} release_extra_cflags='-Wno-error=unused-local-typedefs' sysroot='' \

Oops, by occasion I've added an extra space before ${ARMFPABI}. I updated the pull request in github, and
can send an updated patch to the list if needed.

Thanks,
Andrey

> +	${@bb.utils.contains("AVAILTUNES", "mips", "", "release_extra_cflags='-fno-delete-null-pointer-checks'", d)}"
>   GYP_DEFINES_append_x86 = " generate_character_data=0"
>
>   do_configure() {
>



  reply	other threads:[~2017-04-07 19:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-07 18:40 [meta-browser] [PATCH] chromium: fix null pointer dereference in V8 with gcc-6 Andrey Konovalov
2017-04-07 19:16 ` Andrey Konovalov [this message]
2017-04-11  0:40 ` Andre McCurdy
2017-04-11 13:02   ` Andrey Konovalov
2017-04-11 18:51     ` Andre McCurdy
2017-04-11 19:42       ` Andrey Konovalov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58E7E570.6070406@linaro.org \
    --to=andrey.konovalov@linaro.org \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.