Re: [Qemu-devel] [PATCH v2 0/5] Disable hotplug during migration

[Hailiang Zhang <zhang.zhanghailiang@huawei.com>]

On 2017/4/6 21:13, Juan Quintela wrote:
> Hi
>
> This updates patches with all the comments received.
> I move qdev_unplug() to make linux-user compile.
>
> Please, review.
>
>
> [RFC - v1]
> This series disable hotplug/unplug during migration.  Thank to Markus
> for explaining where I had to put the checks.  Why?  Because during
> migration we will fail if there are changes.  For instance, in
> postcopy, if we add a memory region, we would failing.  Same for other
> devices if they are not setup exactly the same on destination.
>
> Iidea would be to disable it, andthen enable for the thing that we know that work.
>
> This series are on top of my previous RAMState v2 serie.
>
> Commets, please?

Make sense, this will benefit COLO too :)

After the types found by Eric be fixed in patch 5,
Reviewed-by: zhanghailiang <zhang.zhanghailiang@huawei.com>

> Thanks, Juan.
>
>
> *** BLURB HERE ***
>
> Juan Quintela (5):
>    qdev: qdev_hotplug is really a bool
>    qdev: Export qdev_hot_removed
>    qdev: Move qdev_unplug() to qdev-monitor.c
>    migration: Disable hotplug/unplug during migration
>    ram: Remove migration_bitmap_extend()
>
>   exec.c                  |  1 -
>   hw/core/qdev.c          | 40 +++-------------------------------------
>   include/exec/ram_addr.h |  2 --
>   include/hw/qdev-core.h  |  3 ++-
>   migration/ram.c         | 34 ----------------------------------
>   qdev-monitor.c          | 45 +++++++++++++++++++++++++++++++++++++++++++++
>   6 files changed, 50 insertions(+), 75 deletions(-)
>