From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=zwFSZy9BHRJmJjh1y+4SmwnwNZvB+wdo8+VHNYEJo0g=; b=ICC7mZMXlnbLlItL1yTYFzWKcOYjfLc/rYkozrZlS3bNJV9MIi+NA5ute5/r2o1XVj 8j+9xlEcXnXyRFxqq/ZV0kEHYiALUJ40wIwekx/iPOnt60HGQkwk3/SU21908zoWcQMP ZXOEL5myHYkktHH3x7VFOxQZ8mDZtw4rFtFXJfIddj6jGUuJdVyTKlpp3OOqaEuL1Nbp Lf/bBK4sMB8xfcSFHcv0C131CRCY26LDQWprYdsHkcph0AlZyXCfzpXZ5fL82fVJfJdk jPxJR3eMYUeALCi744P4GFyr708EFQ6/NQOR4Ly5cwwTIP4JcV0116MGSSCY8vCVkwGa s5+w== References: From: Frank Rowand Message-ID: <58EFE873.7090009@gmail.com> Date: Thu, 13 Apr 2017 14:06:59 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Fuego] [PATCH] Add support for full device paths (with slashes and colons) to sercp List-Id: Mailing list for the Fuego test framework List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Bird, Timothy" , "monstr@monstr.eu" , "fuego@lists.linuxfoundation.org" On 04/13/17 11:48, Bird, Timothy wrote: >> -----Original Message----- >> From: Bird, Timothy on Thursday, April 13, 2017 11:36 AM > > Just some commentary on the patch... > > This patch solves the problem we were discussing earlier. > With the feature, I can do any of the following, which are all equivalent: > $ sercp foo ttyACM1:/tmp > $ sercp -d /dev/ttyACM1 foo serial:/tmp > $ sercp -d /dev/serial/by-path/pci-0000:08:00.0-usb-0:3:1.4 foo serial:/tmp > All of these copy file 'foo' to the host at the other end of the serial port. > > You can use 'serial' as the placeholder for the device path in either the source > or destination file arguments. So this works also: > $ sercp -d /dev/serial/by-path/pci-0000:08:00.0-usb-0:3:1.4 serial:/tmp/foo bar > (copy the file 'foo' from the remove host back to the local filesystem, as 'bar'). > > Let me know what you think. I like it. > BTW - what's up with the unused "user@" parameters? Why are those supported? > Fuego does not need them or use them. Was there some plan to use them in the future? The intent was to allow a drop in replacement for scp and ssh, with the only change to the command being that a serial device name replaces the host name. So having a "user@" would not result in an error. At the moment the user name is just ignored. The user name could possibly be used in the future: sercp -- If user specified for the target, try to 'chown user' after copying -- If user specified for the source, try to 'su user' before reading the file. This is likely to fail due to passwords. sersh -- If user specified, try to 'su user' to execute the command as user. This is likely to fail due to passwords. It seems like the 'chown user' might be a good idea, but the other changes look like feature creep to me. > > -- Tim >