All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: Wolfgang Bumiller <w.bumiller@proxmox.com>, netdev@vger.kernel.org
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
	"David S. Miller" <davem@davemloft.net>,
	Cong Wang <xiyou.wangcong@gmail.com>
Subject: Re: [PATCH v2 net 1/2] net sched actions: fix access to uninitialized data
Date: Wed, 19 Apr 2017 11:02:58 +0200	[thread overview]
Message-ID: <58F727C2.70100@iogearbox.net> (raw)
In-Reply-To: <20170418101322.27666-1-w.bumiller@proxmox.com>

Hi Wolfgang,

On 04/18/2017 12:13 PM, Wolfgang Bumiller wrote:
[...]

Since this patch goes to -net tree and is a bug fix, please
also add a proper analysis into the commit log instead of
just an empty commit message.

A Fixes tag to your bug fix would also be appropriate, so
that this helps tracking follow-ups to the original commit
that introduced the code. For this one, should be:

Fixes: 1045ba77a596 ("net sched actions: Add support for user cookies")

> Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
> Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
> Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>

Thanks,
Daniel

      parent reply	other threads:[~2017-04-19  9:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-18 10:13 [PATCH v2 net 1/2] net sched actions: fix access to uninitialized data Wolfgang Bumiller
2017-04-18 10:13 ` [PATCH v2 net 2/2] net sched actions: decrement module refcount earlier Wolfgang Bumiller
2017-04-18 13:03   ` Jamal Hadi Salim
2017-04-18 17:03   ` Cong Wang
2017-04-19  2:21     ` Jamal Hadi Salim
2017-04-19  6:23       ` Cong Wang
2017-04-19  8:09         ` Wolfgang Bumiller
2017-04-19 11:32           ` Jamal Hadi Salim
2017-04-19 15:03             ` Wolfgang Bumiller
2017-04-19 21:32               ` Cong Wang
2017-04-20 10:24               ` Jamal Hadi Salim
2017-04-19 17:25             ` Cong Wang
2017-04-20 10:28               ` Jamal Hadi Salim
2017-04-18 12:51 ` [PATCH v2 net 1/2] net sched actions: fix access to uninitialized data Jamal Hadi Salim
2017-04-19  9:02 ` Daniel Borkmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58F727C2.70100@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=jhs@mojatatu.com \
    --cc=netdev@vger.kernel.org \
    --cc=w.bumiller@proxmox.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.