From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jennifer Herbert Subject: Re: [PATCH 2/4] hvm/dmop: Implement copy_{to, from}_guest_buf() in terms of raw accessors Date: Fri, 21 Apr 2017 11:11:40 +0100 Message-ID: <58F9DADC.1020706@citrix.com> References: <1492711189-2857-1-git-send-email-jennifer.herbert@citrix.com> <1492711189-2857-2-git-send-email-jennifer.herbert@citrix.com> <58F9D09B0200007800152B61@prv-mh.provo.novell.com> <58F9F0FC0200007800152CF2@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <58F9F0FC0200007800152CF2@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich , Andrew Cooper Cc: Julien Grall , Paul Durrant , Xen-devel List-Id: xen-devel@lists.xenproject.org CgpPbiAyMS8wNC8xNyAxMDo0NiwgSmFuIEJldWxpY2ggd3JvdGU6Cj4+Pj4gT24gMjEuMDQuMTcg YXQgMTE6MTEsIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPiB3cm90ZToKPj4gT24gMjEvMDQv MjAxNyAwOTo1NCwgQW5kcmV3IENvb3BlciB3cm90ZToKPj4+IE9uIDIxLzA0LzIwMTcgMDg6Mjcs IEphbiBCZXVsaWNoIHdyb3RlOgo+Pj4+Pj4+IE9uIDIwLjA0LjE3IGF0IDE5OjU5LCA8amVubmlm ZXIuaGVyYmVydEBjaXRyaXguY29tPiB3cm90ZToKPj4+Pj4gRnJvbTogSmVubmlmZXIgSGVyYmVy dCA8SmVubmlmZXIuSGVyYmVydEBjaXRyaXguY29tPgo+Pj4+IElzIHRoaXMgY29ycmVjdCwgY29u c2lkZXJpbmcgdGhhdCBpaXJjIHRoZSBwYXRjaCB3YXMgbmV3IGluIHY1IGFuZCAuLi4KPj4+Pgo+ Pj4+PiBUaGlzIGFsc28gYWxsb3dzIHRoZSB1c3VhbCBjYXNlcyB0byBiZSBzaW1wbGlmaWVkLCBi eSBvbWl0dGluZyBhbgo+Pj4+PiB1bm5lY2Vzc2FyeQo+Pj4+PiBidWYgcGFyYW1ldGVycywgYW5k IGJlY2F1c2UgdGhlIG1hY3JvcyBjYW4gYXBwcm9wcmlhdGVseSBzaXplIHRoZSBvYmplY3QuCj4+ Pj4+Cj4+Pj4+IFRoaXMgbWFrZXMgY29weWluZyB0byBvciBmcm9tIGEgYnVmIHRoYXQgaXNuJ3Qg YmlnIGVub3VnaCBhbiBlcnJvci4KPj4+Pj4gSWYgdGhlIGJ1ZmZlciBpc250IGJpZyBlbm91Z2gs IHRyeWluZyB0byBjYXJyeSBvbiByZWdhcmRsZXNzCj4+Pj4+IGNhbiBvbmx5IGNhdXNlIHRyb3Vi bGUgbGF0ZXIgb24uCj4+Pj4+Cj4+Pj4+IFNpZ25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFu ZHJldy5jb29wZXIzQGNpdHJpeC5jb20+Cj4+Pj4+IFNpZ25lZC1vZmYtYnk6IEplbm5pZmVyIEhl cmJlcnQgPEplbm5pZmVyLkhlcmJlcnRAY2l0cml4LmNvbT4KPj4+PiAuLi4gdGhpcyBzZXF1ZW5j ZSBvZiBTLW8tYi1zPwo+Pj4+Cj4+Pj4+IC0tLSBhL3hlbi9hcmNoL3g4Ni9odm0vZG0uYwo+Pj4+ PiArKysgYi94ZW4vYXJjaC94ODYvaHZtL2RtLmMKPj4+Pj4gQEAgLTMyLDM2ICszMiw0NyBAQCBz dHJ1Y3QgZG1vcF9hcmdzIHsKPj4+Pj4gICAgICAgc3RydWN0IHhlbl9kbV9vcF9idWYgYnVmWzJd Owo+Pj4+PiAgIH07Cj4+Pj4+ICAgCj4+Pj4+IC1zdGF0aWMgYm9vbCBjb3B5X2J1Zl9mcm9tX2d1 ZXN0KGNvbnN0IHhlbl9kbV9vcF9idWZfdCBidWZzW10sCj4+Pj4+IC0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBucl9idWZzLCB2b2lkICpkc3QsCj4+Pj4+IC0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBpZHgsIHNpemVfdCBk c3Rfc2l6ZSkKPj4+Pj4gK3N0YXRpYyBib29sIF9yYXdfY29weV9mcm9tX2d1ZXN0X2J1Zih2b2lk ICpkc3QsCj4+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qg c3RydWN0IGRtb3BfYXJncyAqYXJncywKPj4+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICB1bnNpZ25lZCBpbnQgYnVmX2lkeCwKPj4+Pj4gKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBzaXplX3QgZHN0X2J5dGVzKQo+Pj4+PiAgIHsKPj4+Pj4gLSAg ICBzaXplX3Qgc2l6ZTsKPj4+Pj4gKyAgICBzaXplX3QgYnVmX2J5dGVzOwo+Pj4+PiAgIAo+Pj4+ PiAtICAgIGlmICggaWR4ID49IG5yX2J1ZnMgKQo+Pj4+PiArICAgIGlmICggYnVmX2lkeCA+PSBh cmdzLT5ucl9idWZzICkKPj4+Pj4gICAgICAgICAgIHJldHVybiBmYWxzZTsKPj4+Pj4gICAKPj4+ Pj4gLSAgICBtZW1zZXQoZHN0LCAwLCBkc3Rfc2l6ZSk7Cj4+Pj4+ICsgICAgYnVmX2J5dGVzID0g IGFyZ3MtPmJ1ZltidWZfaWR4XS5zaXplOwo+Pj4+PiAgIAo+Pj4+PiAtICAgIHNpemUgPSBtaW5f dChzaXplX3QsIGRzdF9zaXplLCBidWZzW2lkeF0uc2l6ZSk7Cj4+Pj4+ICsgICAgaWYgKCBkc3Rf Ynl0ZXMgPiBidWZfYnl0ZXMgKQo+Pj4+PiArICAgICAgICByZXR1cm4gZmFsc2U7Cj4+Pj4gV2hp bGUgdGhpcyBiZWhhdmlvcmFsIGNoYW5nZSBpcyBub3cgYmVpbmcgbWVudGlvbmVkIGluIHRoZQo+ Pj4+IGRlc2NyaXB0aW9uLCBJJ20gbm90IHN1cmUgSSBidXkgdGhlIGFyZ3VtZW50IG9mIGJhc2lj YWxseSBiZWluZwo+Pj4+IGd1YXJhbnRlZWQgdG8gY2F1c2UgdHJvdWJsZSBkb3duIHRoZSByb2Fk LiBEaWQgeW91IGNvbnNpZGVyIHRoZQo+Pj4+IGZvcndhcmQgY29tcGF0aWJpbGl0eSBhc3BlY3Qg aGVyZSwgYWxsb3dpbmcgdXMgdG8gZXh0ZW5kIGludGVyZmFjZQo+Pj4+IHN0cnVjdHVyZXMgYnkg YWRkaW5nIGZpZWxkcyB0byB0aGVpciBlbmRzIHdpdGhvdXQgYnJlYWtpbmcgb2xkCj4+Pj4gY2Fs bGVycz8gUGF1bCwgd2hhdCBhcmUgeW91ciB0aG91Z2h0cyBoZXJlPwo+Pj4gRE1PUCBpcyBhIHN0 YWJsZSBBQkkuICBUaGVyZSBpcyBubyBsZWdhbCBleHRlbmRpbmcgb2YgYW55IG9iamVjdHMuCj4+ Pgo+Pj4gVGhlIHByZXZpb3VzIHNlbWFudGljcyBhcmUgZ3VhcmFudGVlZCB0byBicmVhayB0aGUg QUJJIHdpdGggZnV0dXJlCj4+PiBzdWJvcHMsIHdoaWNoIGlzIHdoeSBJIHJlbW92ZWQgaXQuICBJ biB0aGUgY2FzZSB0aGF0IHRoZSBndWVzdAo+Pj4gb3JpZ2luYWxseSBwYXNzZWQgYW4gb3Zlcmx5 IGxvbmcgYnVmZmVyLCBhbmQgc29tZW9uZSB0cmllZCBiZSAiY2xldmVyIgo+Pj4gaGVyZSBwYXNz aW5nIHRoZSBzYW1lIG9iamVjdCBoZXJlIGV4cGVjdGluZyBfcmF3X2NvcHlfZnJvbV9ndWVzdF9i dWYoKQo+Pj4gdG8gRFRSVCwgdGhlIGZ1bmN0aW9uIHdpbGwgZW5kIHVwIGNvcHlpbmcgdG9vIG11 Y2ggZGF0YSBmcm9tIHRoZSBndWVzdCwKPj4+IGFuZCB5b3Ugd2lsbCBlbmQgdXAgd2l0aCBzb21l dGhpbmcgdGhlIGd1ZXN0IHdhc24ndCBpbnRlbmRpbmcgdG8gYmUgcGFydAo+Pj4gb2YgdGhlIHN0 cnVjdHVyZSByZXBsYWNpbmcgdGhlIHplcm8gZXh0ZW5zaW9uLgo+Pj4KPj4+IE5ldyBzdWJvcHMg d2hpY2ggdGFrZSBhIGxvbmdlciBvYmplY3Qgc2hvdWxkIHVzZSBhIGJyYW5kIG5ldyBvYmplY3Qu Cj4+Pgo+Pj4gJE1BR0lDIGNvbXBhdGliaWxpdHkgbG9naWMgbGlrZSB5b3Ugd2FudCBoYXMgbm8g YnVzaW5lc3MgbGl2aW5nIGluIHRoZQo+Pj4gY29weSBoZWxwZXIuICBIYWQgSSBzcG90dGVkIHRo ZSBpbnRlbnRpb24gZHVyaW5nIHRoZSBvcmlnaW5hbCBkbW9wCj4+PiBzZXJpZXMsIEkgd291bGQg aGF2ZSByZWplY3RlZCBpdCBkdXJpbmcgcmV2aWV3Lgo+PiBBY3R1YWxseSwgdGhlIGV4aXN0aW5n IGJlaGF2aW91ciBpcyBhbHJlYWR5IGJyb2tlbi4gIElmIGEgZ3Vlc3QgcGFzc2VzCj4+IGFuIG92 ZXJseSBzaG9ydCBidWZbMF0sIHRoZSBkbW9wIGxvZ2ljIHdvbid0IGdldCBhIGZhaWx1cmUsIGFu ZCBpbnN0ZWFkCj4+IGdldCBhIHRydW5jYXRlZCBzdHJ1Y3R1cmUgd2hpY2ggaGFzIGJlZW4gemVy byBleHRlbmRlZC4KPj4KPj4gVGhpcyBpcyB2ZXJ5IGRlZmluaXRlbHkgdGhlIHdyb25nIHRoaW5n IHRvIGRvLCBiZWNhdXNlIHN1Y2ggYSB0cnVuY2F0ZWQKPj4gc3RydWN0dXJlIG1pZ2h0IGFjdHVh bGx5IGNvbnRhaW4gc29tZSBsZWdpdGltYXRlIG9wZXJhdGlvbnMuCj4gU28gd2hhdCwgaWYgdGhh dCdzIHdoYXQgdGhlIGNhbGxlciBtZWFudCB0byBoYXBwZW4/Cj4KPiBDb25zaWRlcmluZyB0aGlz IGlzIGEgY29udHJvdmVyc2lhbCBjaGFuZ2UsIEkgdGhpbmsgaXQgaXMgYSBiYWQgaWRlYQo+IHRv IG1lcmdlIHRoaXMgaW50byB0aGUgb3RoZXJ3aXNlIHVuY29udHJvdmVyc2lhbCBjaGFuZ2UgaGVy ZS4KCkhvdyBhYm91dCB3ZSBtb3ZlIHRoZSBtaW4oLi4pIGFuZCBtZW1zZXQgb3V0IG9mIHRoZSBo ZWxwZXIgZnVuY3Rpb24sIGFuZCAKaW50byBkbV9vcD8KCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZl bEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK