From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jennifer Herbert Subject: Re: [PATCH 2/4] hvm/dmop: Implement copy_{to, from}_guest_buf() in terms of raw accessors Date: Fri, 21 Apr 2017 12:03:17 +0100 Message-ID: <58F9E6F5.2080105@citrix.com> References: <1492711189-2857-1-git-send-email-jennifer.herbert@citrix.com> <1492711189-2857-2-git-send-email-jennifer.herbert@citrix.com> <58F9D09B0200007800152B61@prv-mh.provo.novell.com> <58F9F0FC0200007800152CF2@prv-mh.provo.novell.com> <58F9DADC.1020706@citrix.com> <58F9FD3D0200007800152E0A@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <58F9FD3D0200007800152E0A@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: Andrew Cooper , Julien Grall , Paul Durrant , Xen-devel List-Id: xen-devel@lists.xenproject.org CgpPbiAyMS8wNC8xNyAxMTozOCwgSmFuIEJldWxpY2ggd3JvdGU6Cj4+Pj4gT24gMjEuMDQuMTcg YXQgMTI6MTEsIDxKZW5uaWZlci5IZXJiZXJ0QGNpdHJpeC5jb20+IHdyb3RlOgo+PiBPbiAyMS8w NC8xNyAxMDo0NiwgSmFuIEJldWxpY2ggd3JvdGU6Cj4+Pj4+PiBPbiAyMS4wNC4xNyBhdCAxMTox MSwgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+IHdyb3RlOgo+Pj4+IE9uIDIxLzA0LzIwMTcg MDk6NTQsIEFuZHJldyBDb29wZXIgd3JvdGU6Cj4+Pj4+IE9uIDIxLzA0LzIwMTcgMDg6MjcsIEph biBCZXVsaWNoIHdyb3RlOgo+Pj4+Pj4+Pj4gT24gMjAuMDQuMTcgYXQgMTk6NTksIDxqZW5uaWZl ci5oZXJiZXJ0QGNpdHJpeC5jb20+IHdyb3RlOgo+Pj4+Pj4+IEZyb206IEplbm5pZmVyIEhlcmJl cnQgPEplbm5pZmVyLkhlcmJlcnRAY2l0cml4LmNvbT4KPj4+Pj4+IElzIHRoaXMgY29ycmVjdCwg Y29uc2lkZXJpbmcgdGhhdCBpaXJjIHRoZSBwYXRjaCB3YXMgbmV3IGluIHY1IGFuZCAuLi4KPj4+ Pj4+Cj4+Pj4+Pj4gVGhpcyBhbHNvIGFsbG93cyB0aGUgdXN1YWwgY2FzZXMgdG8gYmUgc2ltcGxp ZmllZCwgYnkgb21pdHRpbmcgYW4KPj4+Pj4+PiB1bm5lY2Vzc2FyeQo+Pj4+Pj4+IGJ1ZiBwYXJh bWV0ZXJzLCBhbmQgYmVjYXVzZSB0aGUgbWFjcm9zIGNhbiBhcHByb3ByaWF0ZWx5IHNpemUgdGhl IG9iamVjdC4KPj4+Pj4+Pgo+Pj4+Pj4+IFRoaXMgbWFrZXMgY29weWluZyB0byBvciBmcm9tIGEg YnVmIHRoYXQgaXNuJ3QgYmlnIGVub3VnaCBhbiBlcnJvci4KPj4+Pj4+PiBJZiB0aGUgYnVmZmVy IGlzbnQgYmlnIGVub3VnaCwgdHJ5aW5nIHRvIGNhcnJ5IG9uIHJlZ2FyZGxlc3MKPj4+Pj4+PiBj YW4gb25seSBjYXVzZSB0cm91YmxlIGxhdGVyIG9uLgo+Pj4+Pj4+Cj4+Pj4+Pj4gU2lnbmVkLW9m Zi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4KPj4+Pj4+PiBT aWduZWQtb2ZmLWJ5OiBKZW5uaWZlciBIZXJiZXJ0IDxKZW5uaWZlci5IZXJiZXJ0QGNpdHJpeC5j b20+Cj4+Pj4+PiAuLi4gdGhpcyBzZXF1ZW5jZSBvZiBTLW8tYi1zPwo+Pj4+Pj4KPj4+Pj4+PiAt LS0gYS94ZW4vYXJjaC94ODYvaHZtL2RtLmMKPj4+Pj4+PiArKysgYi94ZW4vYXJjaC94ODYvaHZt L2RtLmMKPj4+Pj4+PiBAQCAtMzIsMzYgKzMyLDQ3IEBAIHN0cnVjdCBkbW9wX2FyZ3Mgewo+Pj4+ Pj4+ICAgICAgICBzdHJ1Y3QgeGVuX2RtX29wX2J1ZiBidWZbMl07Cj4+Pj4+Pj4gICAgfTsKPj4+ Pj4+PiAgICAKPj4+Pj4+PiAtc3RhdGljIGJvb2wgY29weV9idWZfZnJvbV9ndWVzdChjb25zdCB4 ZW5fZG1fb3BfYnVmX3QgYnVmc1tdLAo+Pj4+Pj4+IC0gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHVuc2lnbmVkIGludCBucl9idWZzLCB2b2lkICpkc3QsCj4+Pj4+Pj4gLSAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IGlkeCwgc2l6ZV90IGRzdF9zaXpl KQo+Pj4+Pj4+ICtzdGF0aWMgYm9vbCBfcmF3X2NvcHlfZnJvbV9ndWVzdF9idWYodm9pZCAqZHN0 LAo+Pj4+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3Ry dWN0IGRtb3BfYXJncyAqYXJncywKPj4+Pj4+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHVuc2lnbmVkIGludCBidWZfaWR4LAo+Pj4+Pj4+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgc2l6ZV90IGRzdF9ieXRlcykKPj4+Pj4+PiAgICB7Cj4+Pj4+ Pj4gLSAgICBzaXplX3Qgc2l6ZTsKPj4+Pj4+PiArICAgIHNpemVfdCBidWZfYnl0ZXM7Cj4+Pj4+ Pj4gICAgCj4+Pj4+Pj4gLSAgICBpZiAoIGlkeCA+PSBucl9idWZzICkKPj4+Pj4+PiArICAgIGlm ICggYnVmX2lkeCA+PSBhcmdzLT5ucl9idWZzICkKPj4+Pj4+PiAgICAgICAgICAgIHJldHVybiBm YWxzZTsKPj4+Pj4+PiAgICAKPj4+Pj4+PiAtICAgIG1lbXNldChkc3QsIDAsIGRzdF9zaXplKTsK Pj4+Pj4+PiArICAgIGJ1Zl9ieXRlcyA9ICBhcmdzLT5idWZbYnVmX2lkeF0uc2l6ZTsKPj4+Pj4+ PiAgICAKPj4+Pj4+PiAtICAgIHNpemUgPSBtaW5fdChzaXplX3QsIGRzdF9zaXplLCBidWZzW2lk eF0uc2l6ZSk7Cj4+Pj4+Pj4gKyAgICBpZiAoIGRzdF9ieXRlcyA+IGJ1Zl9ieXRlcyApCj4+Pj4+ Pj4gKyAgICAgICAgcmV0dXJuIGZhbHNlOwo+Pj4+Pj4gV2hpbGUgdGhpcyBiZWhhdmlvcmFsIGNo YW5nZSBpcyBub3cgYmVpbmcgbWVudGlvbmVkIGluIHRoZQo+Pj4+Pj4gZGVzY3JpcHRpb24sIEkn bSBub3Qgc3VyZSBJIGJ1eSB0aGUgYXJndW1lbnQgb2YgYmFzaWNhbGx5IGJlaW5nCj4+Pj4+PiBn dWFyYW50ZWVkIHRvIGNhdXNlIHRyb3VibGUgZG93biB0aGUgcm9hZC4gRGlkIHlvdSBjb25zaWRl ciB0aGUKPj4+Pj4+IGZvcndhcmQgY29tcGF0aWJpbGl0eSBhc3BlY3QgaGVyZSwgYWxsb3dpbmcg dXMgdG8gZXh0ZW5kIGludGVyZmFjZQo+Pj4+Pj4gc3RydWN0dXJlcyBieSBhZGRpbmcgZmllbGRz IHRvIHRoZWlyIGVuZHMgd2l0aG91dCBicmVha2luZyBvbGQKPj4+Pj4+IGNhbGxlcnM/IFBhdWws IHdoYXQgYXJlIHlvdXIgdGhvdWdodHMgaGVyZT8KPj4+Pj4gRE1PUCBpcyBhIHN0YWJsZSBBQkku ICBUaGVyZSBpcyBubyBsZWdhbCBleHRlbmRpbmcgb2YgYW55IG9iamVjdHMuCj4+Pj4+Cj4+Pj4+ IFRoZSBwcmV2aW91cyBzZW1hbnRpY3MgYXJlIGd1YXJhbnRlZWQgdG8gYnJlYWsgdGhlIEFCSSB3 aXRoIGZ1dHVyZQo+Pj4+PiBzdWJvcHMsIHdoaWNoIGlzIHdoeSBJIHJlbW92ZWQgaXQuICBJbiB0 aGUgY2FzZSB0aGF0IHRoZSBndWVzdAo+Pj4+PiBvcmlnaW5hbGx5IHBhc3NlZCBhbiBvdmVybHkg bG9uZyBidWZmZXIsIGFuZCBzb21lb25lIHRyaWVkIGJlICJjbGV2ZXIiCj4+Pj4+IGhlcmUgcGFz c2luZyB0aGUgc2FtZSBvYmplY3QgaGVyZSBleHBlY3RpbmcgX3Jhd19jb3B5X2Zyb21fZ3Vlc3Rf YnVmKCkKPj4+Pj4gdG8gRFRSVCwgdGhlIGZ1bmN0aW9uIHdpbGwgZW5kIHVwIGNvcHlpbmcgdG9v IG11Y2ggZGF0YSBmcm9tIHRoZSBndWVzdCwKPj4+Pj4gYW5kIHlvdSB3aWxsIGVuZCB1cCB3aXRo IHNvbWV0aGluZyB0aGUgZ3Vlc3Qgd2Fzbid0IGludGVuZGluZyB0byBiZSBwYXJ0Cj4+Pj4+IG9m IHRoZSBzdHJ1Y3R1cmUgcmVwbGFjaW5nIHRoZSB6ZXJvIGV4dGVuc2lvbi4KPj4+Pj4KPj4+Pj4g TmV3IHN1Ym9wcyB3aGljaCB0YWtlIGEgbG9uZ2VyIG9iamVjdCBzaG91bGQgdXNlIGEgYnJhbmQg bmV3IG9iamVjdC4KPj4+Pj4KPj4+Pj4gJE1BR0lDIGNvbXBhdGliaWxpdHkgbG9naWMgbGlrZSB5 b3Ugd2FudCBoYXMgbm8gYnVzaW5lc3MgbGl2aW5nIGluIHRoZQo+Pj4+PiBjb3B5IGhlbHBlci4g IEhhZCBJIHNwb3R0ZWQgdGhlIGludGVudGlvbiBkdXJpbmcgdGhlIG9yaWdpbmFsIGRtb3AKPj4+ Pj4gc2VyaWVzLCBJIHdvdWxkIGhhdmUgcmVqZWN0ZWQgaXQgZHVyaW5nIHJldmlldy4KPj4+PiBB Y3R1YWxseSwgdGhlIGV4aXN0aW5nIGJlaGF2aW91ciBpcyBhbHJlYWR5IGJyb2tlbi4gIElmIGEg Z3Vlc3QgcGFzc2VzCj4+Pj4gYW4gb3Zlcmx5IHNob3J0IGJ1ZlswXSwgdGhlIGRtb3AgbG9naWMg d29uJ3QgZ2V0IGEgZmFpbHVyZSwgYW5kIGluc3RlYWQKPj4+PiBnZXQgYSB0cnVuY2F0ZWQgc3Ry dWN0dXJlIHdoaWNoIGhhcyBiZWVuIHplcm8gZXh0ZW5kZWQuCj4+Pj4KPj4+PiBUaGlzIGlzIHZl cnkgZGVmaW5pdGVseSB0aGUgd3JvbmcgdGhpbmcgdG8gZG8sIGJlY2F1c2Ugc3VjaCBhIHRydW5j YXRlZAo+Pj4+IHN0cnVjdHVyZSBtaWdodCBhY3R1YWxseSBjb250YWluIHNvbWUgbGVnaXRpbWF0 ZSBvcGVyYXRpb25zLgo+Pj4gU28gd2hhdCwgaWYgdGhhdCdzIHdoYXQgdGhlIGNhbGxlciBtZWFu dCB0byBoYXBwZW4/Cj4+Pgo+Pj4gQ29uc2lkZXJpbmcgdGhpcyBpcyBhIGNvbnRyb3ZlcnNpYWwg Y2hhbmdlLCBJIHRoaW5rIGl0IGlzIGEgYmFkIGlkZWEKPj4+IHRvIG1lcmdlIHRoaXMgaW50byB0 aGUgb3RoZXJ3aXNlIHVuY29udHJvdmVyc2lhbCBjaGFuZ2UgaGVyZS4KPj4gSG93IGFib3V0IHdl IG1vdmUgdGhlIG1pbiguLikgYW5kIG1lbXNldCBvdXQgb2YgdGhlIGhlbHBlciBmdW5jdGlvbiwg YW5kCj4+IGludG8gZG1fb3A/Cj4gV291bGRuJ3QgdGhhdCByZXN1bHQgaW4gZGlmZmVyZW50IGJ1 ZmZlcnMgYmVpbmcgdHJlYXRlZCBkaWZmZXJlbnRseSwKPiB3aGljaCBJJ2QgcmF0aGVyIG5vdCBz ZWUgaGFwcGVuaW5nPwoKSSB0aGluayBpbiB0aGUgZ2VuZXJhbCBjYXNlLCBpdHMgd3JvbmcgdG8g YXNzdW1lIHRoYXQgaXRzIG9rIHRvIHRydW5jYXRlIAphIGJ1ZmZlci4KSW4gc3BlY2lmaWMgY2Fz ZXMsIHN1Y2ggYXMgYnVmWzBdLCB3ZSBkb24ndCByZWFsbHkga25vdyBob3cgYmlnIHRoZSBidWYg Cm5lZWRzIHRvIGJlIHVudGlsIHdlIHN0YXJ0IHBhcnNpbmcgaXQuIEluIHRoaXMgY2FzZSwgd2Ug d2FudCB0byBzYXkgCidnaXZlIG1lIHdoYXQgeW91IGhhdmUsIHVwdG8gdGhpcyBtYXhpbXVtJy4g IFRoaXMgaXMgdGhlIHNwZWNpYWwgY2FzZSwgCm5vdCB0aGUgZ2VuZXJhbCBvbmUsIGFuIGFzIHN1 Y2ggZG9lcyBub3QgYmVsb25nIGluIHRoZSBnZW5lcmFsIGNhc2UgCmFjY2Vzc2VyIGhlbHBlci4K Q2VydGFpbmx5IHdoZW4gd2UgZ2V0IHRvIHVwZGF0aW5nIHRoZSBhY2Nlc3NlciBoZWxwZXIgdG8g ZGVhbCB3aXRoIApvZmZzZXRzLCBpdHMgZ2V0IG1vcmUgY29uZnVzZWQuICBJZiB3ZSBnaXZlIGl0 IGFuIG9mZnNldCBncmVhdGVyIHRoZW4gCnRoZSBzaXplIG9mIHRoZSBidWZmZXIsIGRvIHdlIGp1 c3QgbWVtc2V0PyAgVGhhdCB3b3VsZCBzZWVtIHdyb25nLiAgV2l0aCAKYW4gb2Zmc2V0IG9mIDAs IHdlIHdhbnQgaXQgdG8gZG8gdGhlIG1lbXNldCB0aGluZywgdG8gZGVhbCB3aXRoIGJ1ZlswXS4g IApCdXQgd2hhdCBhYm91dCBpZiB3ZSBoYXZlIGFuIG9mZnNldC4gIEknZCB0aGluayB0aGUgY2Fs bGluZyBmdW5jdGlvbiAKd291bGQgcmVhbGx5IHdhbnQgdG8ga25vdyBpZiBpdHMgZ290IG5vbnNl bnNlLgoKQW5vdGhlciBzb2x1dGlvbiB3b3VsZCBiZSB0byBoYXZlIHR3byB2YXJpYW50cyBvZiB0 aGUgaGVscGVyIGZ1bmN0aW9uLiBBIAonbm9ybWFsJyBvbmUsIGFuZCB0aGUgYmVzdCBlZmZvcnQg b25lLgoKLWplbm55CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRw czovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==