From: Varsha Rao <rvarsha016@gmail.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Teddy Wang <teddy.wang@siliconmotion.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: outreachy-kernel@googlegroups.com
Subject: [PATCH 6/7] staging: sm750fb: Replace NULL comparison.
Date: Sun, 26 Feb 2017 18:23:35 +0530 [thread overview]
Message-ID: <58b2cfd1.90c6620a.ef358.4e58@mx.google.com> (raw)
In-Reply-To: <cover.1488112339.git.varshar186@gmail.com>
Replaced NULL comparison with pCurrentDviCtrl->pfnInit. This patch fixes
the following checkpatch issue:
CHECK: Comparison to NULL could be written "pCurrentDviCtrl->pfnInit"
Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
---
drivers/staging/sm750fb/ddk750_dvi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
index 42c753f..171ae06 100644
--- a/drivers/staging/sm750fb/ddk750_dvi.c
+++ b/drivers/staging/sm750fb/ddk750_dvi.c
@@ -45,7 +45,7 @@ int dviInit(
dvi_ctrl_device_t *pCurrentDviCtrl;
pCurrentDviCtrl = g_dcftSupportedDviController;
- if (pCurrentDviCtrl->pfnInit != NULL) {
+ if (pCurrentDviCtrl->pfnInit) {
return pCurrentDviCtrl->pfnInit(edgeSelect, busSelect, dualEdgeClkSelect, hsyncEnable,
vsyncEnable, deskewEnable, deskewSetting, continuousSyncEnable,
pllFilterEnable, pllFilterValue);
--
2.9.3
next prev parent reply other threads:[~2017-02-26 12:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1488112339.git.varshar186@gmail.com>
2017-02-26 12:45 ` [PATCH 1/7] staging: sm750fb: Add braces around if statement Varsha Rao
2017-02-26 12:45 ` [PATCH 2/7] staging: sm750fb: Fix line over 80 characters Varsha Rao
2017-02-26 12:50 ` [PATCH 3/7] staging: sm750fb: Add identifier to function definition argument Varsha Rao
2017-02-26 12:50 ` [PATCH 4/7] staging: sm750fb: Remove unnecessary blank lines Varsha Rao
2017-02-26 12:50 ` [PATCH 5/7] staging: sm750fb: Added spaces around arithmetic operators Varsha Rao
2017-02-26 12:53 ` Varsha Rao [this message]
2017-02-26 12:57 ` [PATCH v3 7/7] staging: sm750fb: Remove blank lines after { and before } braces Varsha Rao
[not found] <cover.1488045682.git.varshar186@gmail.com>
2017-02-25 18:35 ` [PATCH 6/7] staging: sm750fb: Replace NULL comparison Varsha Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58b2cfd1.90c6620a.ef358.4e58@mx.google.com \
--to=rvarsha016@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.