From: Varsha Rao <rvarsha016@gmail.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: outreachy-kernel <outreachy-kernel@googlegroups.com>
Subject: [PATCH v2 5/9] staging : media: atomisp: Fix block comments warning.
Date: Sat, 4 Mar 2017 20:11:44 +0530 [thread overview]
Message-ID: <58bad22b.4ea7630a.6e3a5.0643@mx.google.com> (raw)
In-Reply-To: <cover.1488636852.git.varshar186@gmail.com>
Used kernel preferred block commenting style, to fix the following
checkpatch issue:
WARNING: Block comments use a trailing */ on a separate line
Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
---
Changes in v2:
- No changes.
drivers/staging/media/atomisp/i2c/gc0310.c | 3 ++-
drivers/staging/media/atomisp/i2c/gc2235.c | 3 ++-
drivers/staging/media/atomisp/i2c/ov2680.c | 7 ++++---
drivers/staging/media/atomisp/i2c/ov2722.c | 6 ++++--
.../pci/atomisp2/css2400/isp/kernels/bnlm/ia_css_bnlm.host.c | 6 +++---
5 files changed, 15 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/media/atomisp/i2c/gc0310.c b/drivers/staging/media/atomisp/i2c/gc0310.c
index bae55d3..e122cde 100644
--- a/drivers/staging/media/atomisp/i2c/gc0310.c
+++ b/drivers/staging/media/atomisp/i2c/gc0310.c
@@ -538,7 +538,8 @@ static long gc0310_ioctl(struct v4l2_subdev *sd, unsigned int cmd, void *arg)
}
/* This returns the exposure time being used. This should only be used
- for filling in EXIF data, not for actual image processing. */
+ * for filling in EXIF data, not for actual image processing.
+ */
static int gc0310_q_exposure(struct v4l2_subdev *sd, s32 *value)
{
struct i2c_client *client = v4l2_get_subdevdata(sd);
diff --git a/drivers/staging/media/atomisp/i2c/gc2235.c b/drivers/staging/media/atomisp/i2c/gc2235.c
index c04dcfb..0f23ba9 100644
--- a/drivers/staging/media/atomisp/i2c/gc2235.c
+++ b/drivers/staging/media/atomisp/i2c/gc2235.c
@@ -427,7 +427,8 @@ static long gc2235_ioctl(struct v4l2_subdev *sd, unsigned int cmd, void *arg)
return 0;
}
/* This returns the exposure time being used. This should only be used
- for filling in EXIF data, not for actual image processing. */
+ * for filling in EXIF data, not for actual image processing.
+ */
static int gc2235_q_exposure(struct v4l2_subdev *sd, s32 *value)
{
struct i2c_client *client = v4l2_get_subdevdata(sd);
diff --git a/drivers/staging/media/atomisp/i2c/ov2680.c b/drivers/staging/media/atomisp/i2c/ov2680.c
index 5730fe5..df1e336 100644
--- a/drivers/staging/media/atomisp/i2c/ov2680.c
+++ b/drivers/staging/media/atomisp/i2c/ov2680.c
@@ -554,7 +554,8 @@ static long ov2680_ioctl(struct v4l2_subdev *sd, unsigned int cmd, void *arg)
}
/* This returns the exposure time being used. This should only be used
- for filling in EXIF data, not for actual image processing. */
+ * for filling in EXIF data, not for actual image processing.
+ */
static int ov2680_q_exposure(struct v4l2_subdev *sd, s32 *value)
{
struct i2c_client *client = v4l2_get_subdevdata(sd);
@@ -1135,8 +1136,8 @@ static int ov2680_set_fmt(struct v4l2_subdev *sd,
v4l2_info(client, "\n%s idx %d \n", __func__, dev->fmt_idx);
/*ret = startup(sd);
- if (ret)
- dev_err(&client->dev, "ov2680 startup err\n");
+ * if (ret)
+ * dev_err(&client->dev, "ov2680 startup err\n");
*/
err:
mutex_unlock(&dev->input_lock);
diff --git a/drivers/staging/media/atomisp/i2c/ov2722.c b/drivers/staging/media/atomisp/i2c/ov2722.c
index cfcf14b..4a7dd20 100644
--- a/drivers/staging/media/atomisp/i2c/ov2722.c
+++ b/drivers/staging/media/atomisp/i2c/ov2722.c
@@ -505,7 +505,8 @@ static long ov2722_ioctl(struct v4l2_subdev *sd, unsigned int cmd, void *arg)
}
/* This returns the exposure time being used. This should only be used
- for filling in EXIF data, not for actual image processing. */
+ * for filling in EXIF data, not for actual image processing.
+ */
static int ov2722_q_exposure(struct v4l2_subdev *sd, s32 *value)
{
struct i2c_client *client = v4l2_get_subdevdata(sd);
@@ -687,7 +688,8 @@ static int gpio_ctrl(struct v4l2_subdev *sd, bool flag)
return dev->platform_data->gpio_ctrl(sd, flag);
/* Note: the GPIO order is asymmetric: always RESET#
- * before PWDN# when turning it on or off. */
+ * before PWDN# when turning it on or off.
+ */
ret = dev->platform_data->gpio0_ctrl(sd, flag);
/*
*ov2722 PWDN# active high when pull down,opposite to the convention
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/bnlm/ia_css_bnlm.host.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/bnlm/ia_css_bnlm.host.c
index 46b702e..6184019 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/bnlm/ia_css_bnlm.host.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/bnlm/ia_css_bnlm.host.c
@@ -39,7 +39,7 @@ static const int32_t div_lut_intercepts[BNLM_DIV_LUT_SIZE] = {
* lut_thr : array containing threshold values for lut
* lut_val : array containing output values related to lut_thr
* lut_size: Size of lut_val array
- * */
+ */
static inline void
bnlm_lut_encode(struct bnlm_lut *lut, const int32_t *lut_thr, const int32_t *lut_val, const uint32_t lut_size)
{
@@ -56,7 +56,7 @@ bnlm_lut_encode(struct bnlm_lut *lut, const int32_t *lut_thr, const int32_t *lut
* Then these elements are copied into other groups inside the same
* vector. If the LUT size is less than 16, then remaining elements are
* set to 0.
- * */
+ */
assert((lut_size >= 2) && (lut_size <= block_size));
/* array lut_thr has (lut_size-1) entries */
for (i = 0; i < lut_size-2; i++) {
@@ -90,7 +90,7 @@ bnlm_lut_encode(struct bnlm_lut *lut, const int32_t *lut_thr, const int32_t *lut
/*
* - Encodes BNLM public parameters into VMEM parameters
* - Generates VMEM parameters which will needed internally ISP
- * */
+ */
void
ia_css_bnlm_vmem_encode(
struct bnlm_vmem_params *to,
--
2.9.3
next prev parent reply other threads:[~2017-03-04 14:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1488636852.git.varshar186@gmail.com>
2017-03-04 14:34 ` [PATCH v2 1/9] staging: media: atomisp: Removed unnecessary parentheses Varsha Rao
2017-03-04 14:34 ` [PATCH v2 2/9] staging: media: atomisp: Fix line over 80 characters Varsha Rao
2017-03-04 14:37 ` [PATCH v2 3/9] staging: media: atomisp: Added spaces around arithmetic and bitwise operators Varsha Rao
2017-03-04 14:40 ` [PATCH v2 4/9] staging: media: atomisp: Replace 'uint32_t' with kernel type u32 Varsha Rao
2017-03-04 14:41 ` Varsha Rao [this message]
2017-03-04 14:46 ` [PATCH v2 6/9] staging: media: atomisp: Removes the FSF mailing address Varsha Rao
2017-03-04 14:46 ` [PATCH v2 7/9] staging: media: atomisp: Use unsigned int instead of unsigned Varsha Rao
2017-03-04 14:48 ` [PATCH v2 8/9] staging: media: atomisp: Fixed typo Varsha Rao
2017-03-04 14:50 ` [PATCH v2 9/9] staging: media: atomisp: Replace NULL comparison Varsha Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58bad22b.4ea7630a.6e3a5.0643@mx.google.com \
--to=rvarsha016@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=mchehab@kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.