From: Varsha Rao <rvarsha016@gmail.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: outreachy-kernel <outreachy-kernel@googlegroups.com>
Subject: [PATCH v3 1/9] staging: media: atomisp: Removed unnecessary parentheses.
Date: Sat, 4 Mar 2017 22:34:02 +0530 [thread overview]
Message-ID: <58baf38a.930e620a.3fcd0.d50c@mx.google.com> (raw)
In-Reply-To: <cover.1488642821.git.varshar186@gmail.com>
Removed parentheses on the right hand side of assignment, as they are
not required. The following coccinelle script is used to fix this issue:
@@
binary operator op = {<<,>>,+,/};
local idexpression id;
expression e1, e2;
@@
id =
-(
e1 op e2
-)
Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
---
Changes in v2:
- No Changes.
Changes in v3:
- Added change log message for previous version.
drivers/staging/media/atomisp/i2c/gc0310.c | 4 ++--
drivers/staging/media/atomisp/i2c/gc2235.c | 4 ++--
drivers/staging/media/atomisp/i2c/ov2680.c | 4 ++--
drivers/staging/media/atomisp/i2c/ov2722.c | 4 ++--
drivers/staging/media/atomisp/i2c/ov5693/ov5693.c | 2 +-
drivers/staging/media/atomisp/i2c/ov8858.c | 2 +-
.../css2400/isp/kernels/bnlm/ia_css_bnlm.host.c | 2 +-
.../isp/kernels/macc/macc1_5/ia_css_macc1_5.host.c | 2 +-
.../css2400/isp/kernels/s3a/s3a_1.0/ia_css_s3a.host.c | 2 +-
.../media/atomisp/pci/atomisp2/css2400/sh_css_mipi.c | 18 +++++++++---------
10 files changed, 22 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/media/atomisp/i2c/gc0310.c b/drivers/staging/media/atomisp/i2c/gc0310.c
index ee1fd59..b4e9a8d 100644
--- a/drivers/staging/media/atomisp/i2c/gc0310.c
+++ b/drivers/staging/media/atomisp/i2c/gc0310.c
@@ -904,13 +904,13 @@ static int gc0310_s_power(struct v4l2_subdev *sd, int on)
#define LARGEST_ALLOWED_RATIO_MISMATCH 800
static int distance(struct gc0310_resolution *res, u32 w, u32 h)
{
- unsigned int w_ratio = ((res->width << 13)/w);
+ unsigned int w_ratio = (res->width << 13)/w;
unsigned int h_ratio;
int match;
if (h == 0)
return -1;
- h_ratio = ((res->height << 13) / h);
+ h_ratio = (res->height << 13) / h;
if (h_ratio == 0)
return -1;
match = abs(((w_ratio << 13) / h_ratio) - ((int)8192));
diff --git a/drivers/staging/media/atomisp/i2c/gc2235.c b/drivers/staging/media/atomisp/i2c/gc2235.c
index 3dd5e7f..eb68f44 100644
--- a/drivers/staging/media/atomisp/i2c/gc2235.c
+++ b/drivers/staging/media/atomisp/i2c/gc2235.c
@@ -697,13 +697,13 @@ static int gc2235_s_power(struct v4l2_subdev *sd, int on)
#define LARGEST_ALLOWED_RATIO_MISMATCH 800
static int distance(struct gc2235_resolution *res, u32 w, u32 h)
{
- unsigned int w_ratio = ((res->width << 13)/w);
+ unsigned int w_ratio = (res->width << 13)/w;
unsigned int h_ratio;
int match;
if (h == 0)
return -1;
- h_ratio = ((res->height << 13) / h);
+ h_ratio = (res->height << 13) / h;
if (h_ratio == 0)
return -1;
match = abs(((w_ratio << 13) / h_ratio) - ((int)8192));
diff --git a/drivers/staging/media/atomisp/i2c/ov2680.c b/drivers/staging/media/atomisp/i2c/ov2680.c
index 3f1495e..434b6f8 100644
--- a/drivers/staging/media/atomisp/i2c/ov2680.c
+++ b/drivers/staging/media/atomisp/i2c/ov2680.c
@@ -1005,13 +1005,13 @@ static int ov2680_s_power(struct v4l2_subdev *sd, int on)
#define LARGEST_ALLOWED_RATIO_MISMATCH 600
static int distance(struct ov2680_resolution *res, u32 w, u32 h)
{
- unsigned int w_ratio = ((res->width << 13)/w);
+ unsigned int w_ratio = (res->width << 13)/w;
unsigned int h_ratio;
int match;
if (h == 0)
return -1;
- h_ratio = ((res->height << 13) / h);
+ h_ratio = (res->height << 13) / h;
if (h_ratio == 0)
return -1;
match = abs(((w_ratio << 13) / h_ratio) - ((int)8192));
diff --git a/drivers/staging/media/atomisp/i2c/ov2722.c b/drivers/staging/media/atomisp/i2c/ov2722.c
index ec4938d..566157c 100644
--- a/drivers/staging/media/atomisp/i2c/ov2722.c
+++ b/drivers/staging/media/atomisp/i2c/ov2722.c
@@ -801,13 +801,13 @@ static int ov2722_s_power(struct v4l2_subdev *sd, int on)
#define LARGEST_ALLOWED_RATIO_MISMATCH 800
static int distance(struct ov2722_resolution *res, u32 w, u32 h)
{
- unsigned int w_ratio = ((res->width << 13)/w);
+ unsigned int w_ratio = (res->width << 13)/w;
unsigned int h_ratio;
int match;
if (h == 0)
return -1;
- h_ratio = ((res->height << 13) / h);
+ h_ratio = (res->height << 13) / h;
if (h_ratio == 0)
return -1;
match = abs(((w_ratio << 13) / h_ratio) - ((int)8192));
diff --git a/drivers/staging/media/atomisp/i2c/ov5693/ov5693.c b/drivers/staging/media/atomisp/i2c/ov5693/ov5693.c
index 790b881..30c3cea 100644
--- a/drivers/staging/media/atomisp/i2c/ov5693/ov5693.c
+++ b/drivers/staging/media/atomisp/i2c/ov5693/ov5693.c
@@ -1506,7 +1506,7 @@ static int distance(struct ov5693_resolution *res, u32 w, u32 h)
res->width < w || res->height < h)
return -1;
- ratio = (res->width << 13);
+ ratio = res->width << 13;
ratio /= w;
ratio *= h;
ratio /= res->height;
diff --git a/drivers/staging/media/atomisp/i2c/ov8858.c b/drivers/staging/media/atomisp/i2c/ov8858.c
index eccb4a3..054de8b 100644
--- a/drivers/staging/media/atomisp/i2c/ov8858.c
+++ b/drivers/staging/media/atomisp/i2c/ov8858.c
@@ -1250,7 +1250,7 @@ static int distance(struct ov8858_resolution const *res, const u32 w,
res->width < w || res->height < h)
return -1;
- ratio = (res->width << 13);
+ ratio = res->width << 13;
ratio /= w;
ratio *= h;
ratio /= res->height;
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/bnlm/ia_css_bnlm.host.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/bnlm/ia_css_bnlm.host.c
index 3af107d..5ff2529 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/bnlm/ia_css_bnlm.host.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/bnlm/ia_css_bnlm.host.c
@@ -45,7 +45,7 @@ bnlm_lut_encode(struct bnlm_lut *lut, const int32_t *lut_thr, const int32_t *lut
{
uint32_t blk, i;
const uint32_t block_size = 16;
- const uint32_t total_blocks = (ISP_VEC_NELEMS / block_size);
+ const uint32_t total_blocks = ISP_VEC_NELEMS / block_size;
/* Create VMEM LUTs from the threshold and value arrays.
*
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/macc/macc1_5/ia_css_macc1_5.host.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/macc/macc1_5/ia_css_macc1_5.host.c
index 836a3b9..96c81ad 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/macc/macc1_5/ia_css_macc1_5.host.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/macc/macc1_5/ia_css_macc1_5.host.c
@@ -50,7 +50,7 @@ ia_css_macc1_5_vmem_encode(
for (k = 0; k < 4; k++)
for (i = 0; i < IA_CSS_MACC_NUM_AXES; i++) {
- idx = (idx_map[i] + (k*IA_CSS_MACC_NUM_AXES));
+ idx = idx_map[i] + (k*IA_CSS_MACC_NUM_AXES);
j = 4*i;
params->data[0][(idx)] = from->data[j];
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/s3a/s3a_1.0/ia_css_s3a.host.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/s3a/s3a_1.0/ia_css_s3a.host.c
index 39de369..8ef6c54 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/s3a/s3a_1.0/ia_css_s3a.host.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/s3a/s3a_1.0/ia_css_s3a.host.c
@@ -350,7 +350,7 @@ ia_css_s3a_vmem_decode(
hi = isp_stats_hi;
lo = isp_stats_lo;
- chunk = (ISP_VEC_NELEMS >> host_stats->grid.deci_factor_log2);
+ chunk = ISP_VEC_NELEMS >> host_stats->grid.deci_factor_log2;
chunk = max(chunk, 1);
for (y = 0; y < out_height; y++) {
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_mipi.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_mipi.c
index 1210c21..ee91f83 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_mipi.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_mipi.c
@@ -210,18 +210,18 @@ ia_css_mipi_frame_calculate_size(const unsigned int width,
*/
- words_per_odd_line = ((odd_line_bytes + 3) >> 2); /* ceil(odd_line_bytes/4); word = 4 bytes */
- words_per_even_line = ((even_line_bytes + 3) >> 2);
+ words_per_odd_line = (odd_line_bytes + 3) >> 2; /* ceil(odd_line_bytes/4); word = 4 bytes */
+ words_per_even_line = (even_line_bytes + 3) >> 2;
words_for_first_line = words_per_odd_line + 2 + (hasSOLandEOL ? 1 : 0);
/* + SOF +packet header + optionally (SOL), but (EOL) is not in the first line */
words_per_odd_line += (1 + (hasSOLandEOL ? 2 : 0));
/* each non-first line has format header, and optionally (SOL) and (EOL). */
words_per_even_line += (1 + (hasSOLandEOL ? 2 : 0));
- mem_words_per_odd_line = ((words_per_odd_line + 7) >> 3);
+ mem_words_per_odd_line = (words_per_odd_line + 7) >> 3;
/* ceil(words_per_odd_line/8); mem_word = 32 bytes, 8 words */
- mem_words_for_first_line = ((words_for_first_line + 7) >> 3);
- mem_words_per_even_line = ((words_per_even_line + 7) >> 3);
+ mem_words_for_first_line = (words_for_first_line + 7) >> 3;
+ mem_words_per_even_line = (words_per_even_line + 7) >> 3;
mem_words_for_EOF = 1; /* last line consisit of the optional (EOL) and EOF */
mem_words = ((embedded_data_size_words + 7) >> 3) +
@@ -364,13 +364,13 @@ calculate_mipi_buff_size(
even_line_bytes = odd_line_bytes;
}
- words_per_odd_line = ((odd_line_bytes + 3) >> 2);
+ words_per_odd_line = (odd_line_bytes + 3) >> 2;
/* ceil(odd_line_bytes/4); word = 4 bytes */
- words_per_even_line = ((even_line_bytes + 3) >> 2);
+ words_per_even_line = (even_line_bytes + 3) >> 2;
- mem_words_per_odd_line = ((words_per_odd_line + 7) >> 3);
+ mem_words_per_odd_line = (words_per_odd_line + 7) >> 3;
/* ceil(words_per_odd_line/8); mem_word = 32 bytes, 8 words */
- mem_words_per_even_line = ((words_per_even_line + 7) >> 3);
+ mem_words_per_even_line = (words_per_even_line + 7) >> 3;
mem_words_per_buff_line =
(mem_words_per_odd_line > mem_words_per_even_line) ? mem_words_per_odd_line : mem_words_per_even_line;
--
2.9.3
next parent reply other threads:[~2017-03-04 17:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1488642821.git.varshar186@gmail.com>
2017-03-04 17:04 ` Varsha Rao [this message]
2017-03-04 17:04 ` [PATCH v3 2/9] staging: media: atomisp: Fix line over 80 characters Varsha Rao
2017-03-04 17:11 ` [PATCH v3 3/9] staging: media: atomisp: Added spaces around arithmetic and bitwise operators Varsha Rao
2017-03-04 17:12 ` [PATCH v3 4/9] staging: media: atomisp: Replace 'uint32_t' with kernel type u32 Varsha Rao
2017-03-04 17:15 ` [PATCH v3 5/9] staging: media: atomisp: Fix block comments warning Varsha Rao
2017-03-04 17:19 ` [PATCH v3 6/9] staging: media: atomisp: Removes the FSF mailing address Varsha Rao
2017-03-04 17:20 ` [PATCH v3 7/9] staging: media: atomisp: Use unsigned int instead of unsigned Varsha Rao
2017-03-04 17:22 ` [PATCH v3 8/9] staging: media: atomisp: Fixed typo Varsha Rao
2017-03-04 17:24 ` [PATCH v3 9/9] staging: media: atomisp: Replace NULL comparison Varsha Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58baf38a.930e620a.3fcd0.d50c@mx.google.com \
--to=rvarsha016@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=mchehab@kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.