From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Mark Lord <lkml@rtr.ca>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2.4.28-pre4-bk6] delkin_cb: new driver for Cardbus IDE CF adaptor
Date: Fri, 22 Oct 2004 02:31:41 +0200 [thread overview]
Message-ID: <58cb370e04102117316b5c250@mail.gmail.com> (raw)
In-Reply-To: <41785258.6060709@rtr.ca>
On Thu, 21 Oct 2004 20:20:40 -0400, Mark Lord <lkml@rtr.ca> wrote:
> >>+ drive->id->csfo = 0; /* workaround for idedisk_open bug */
>
> Not there in the 2.6.xx version.
>
> And in 2.4.xx.. why is idedisk_open() examining vendor-specific
> fields of the IDENTIFY data, anyway? Very very unsafe.
> I put the above one-liner workaround (drive->id->csfo) into delkin_cb
> to bypass the problems it creates for now, until idedisk_open gets fixed.
id->csfo is still checked in 2.6.x but in idedisk_setup()
> Normally I'd just send a patch to fix idedisk_open(), but since I don't
> even understand what it is trying to do, it would be safer for whoever
> put that code there to have a second look. Especially since 2.4.xx
> is supposed to be stable now -- if it ain't broke, don't break it. :)
I guess that Alan knows more about id->csfo.
next prev parent reply other threads:[~2004-10-22 0:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-21 18:44 [PATCH 2.4.28-pre4-bk6] delkin_cb: new driver for Cardbus IDE CF adaptor Mark Lord
2004-10-21 19:13 ` Bartlomiej Zolnierkiewicz
2004-10-21 20:24 ` Mark Lord
2004-10-21 20:42 ` Bartlomiej Zolnierkiewicz
2004-10-21 20:59 ` Mark Lord
2004-10-21 21:35 ` Alan Cox
2004-10-21 22:41 ` Bartlomiej Zolnierkiewicz
2004-10-21 21:51 ` Bartlomiej Zolnierkiewicz
2004-10-21 21:59 ` Mark Lord
2004-10-21 22:02 ` Bartlomiej Zolnierkiewicz
2004-10-21 23:40 ` Marcelo Tosatti
2004-10-21 21:04 ` Chris Friesen
2004-10-21 21:32 ` Alan Cox
2004-10-21 22:49 ` Mark Lord
2004-10-21 22:57 ` Bartlomiej Zolnierkiewicz
2004-10-22 0:07 ` Mark Lord
2004-10-22 0:15 ` Bartlomiej Zolnierkiewicz
2004-10-22 0:20 ` Mark Lord
2004-10-22 0:31 ` Bartlomiej Zolnierkiewicz [this message]
2004-10-23 11:08 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58cb370e04102117316b5c250@mail.gmail.com \
--to=bzolnier@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@rtr.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.