All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Chris Wedgwood <cw@f00f.org>, LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] IDE remove some cruft from ide.h
Date: Fri, 5 Nov 2004 14:16:05 +0100	[thread overview]
Message-ID: <58cb370e041105051635c15281@mail.gmail.com> (raw)
In-Reply-To: <418AE8C0.3040205@pobox.com>

On Thu, 04 Nov 2004 21:43:12 -0500, Jeff Garzik <jgarzik@pobox.com> wrote:
> Bart, Chris's two patches are OK with me.  If you agree, then please
> merge them up into your ide-2.6 queue.

OK (but I will leave SECTOR_[SIZE, WORDS] for
now as this change depends on the other patch).

> Chris, a useful follow-up patch (if Bart agrees) is a global
> search-n-replace of WIN_xxx constants with ATA_CMD_xxx constants.
> Depending on the size of the patch, it might even need to be split up
> across several patches.

One ceveat here: hdreg.h and WIN_xxx are (ab)used by user-space
so for sure there will be complaints (not that we should care :)...

Bartlomiej

  reply	other threads:[~2004-11-05 13:18 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-03  9:11 [PATCH] IDE remove some cruft from ide.h Chris Wedgwood
2004-11-05  2:43 ` Jeff Garzik
2004-11-05 13:16   ` Bartlomiej Zolnierkiewicz [this message]
2004-11-06  3:22     ` [PATCH 0/3] WIN_* -> ATA_CMD_* conversion: comments Chris Wedgwood
2004-11-06  3:23     ` [PATCH 1/3] WIN_* -> ATA_CMD_* conversion: add new entries to ata.h Chris Wedgwood
2004-11-06 16:48       ` Jeff Garzik
2004-11-06 17:05         ` Jeff Garzik
2004-11-07  6:04           ` [PATCH 0/3] WIN_* -> ATA_CMD_* conversion (take #2): comments Chris Wedgwood
2004-11-07  6:04           ` [PATCH 1/3] WIN_* -> ATA_CMD_* conversion (take #2): add new entries to ata.h Chris Wedgwood
2004-11-08  2:30             ` Jeff Garzik
2004-11-07  6:04           ` [PATCH 2/3] WIN_* -> ATA_CMD_* conversion (take #2): convert users of WIN_* to ATA_CMD_* Chris Wedgwood
2004-11-07  6:04           ` [PATCH 3/3] WIN_* -> ATA_CMD_* conversion (take #2): cleanup hdreg.h Chris Wedgwood
2004-11-06  3:23     ` [PATCH 2/3] WIN_* -> ATA_CMD_* conversion: update WIN_* users to use ATA_CMD_* Chris Wedgwood
2004-11-06  3:45       ` Ross Biro
2004-11-06  3:55         ` Chris Wedgwood
2004-11-06 14:53           ` Ross Biro
2004-11-08  8:55           ` Jens Axboe
2004-11-06  3:23     ` [PATCH 3/3] WIN_* -> ATA_CMD_* conversion: cleanup hdreg.h Chris Wedgwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58cb370e041105051635c15281@mail.gmail.com \
    --to=bzolnier@gmail.com \
    --cc=akpm@osdl.org \
    --cc=cw@f00f.org \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.