From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-ide@vger.kernel.org
Subject: Re: PATCH: Use the fixup layer to fix the various SI3112 hangs
Date: Sat, 6 Nov 2004 02:00:20 +0100 [thread overview]
Message-ID: <58cb370e04110517005a88562e@mail.gmail.com> (raw)
In-Reply-To: <1099697668.5564.82.camel@localhost.localdomain>
On Fri, 05 Nov 2004 23:34:29 +0000, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> On Gwe, 2004-11-05 at 23:24, Bartlomiej Zolnierkiewicz wrote:
>
>
> > On Fri, 5 Nov 2004 23:59:09 +0100, Bartlomiej Zolnierkiewicz
> > <bzolnier@gmail.com> wrote:
> > > all fixup patches applied
> > > (after merging into 2 changesets & cleanup)
> >
> > and fixed bug preventing both fixups from correct working,
> > fixup() must be called _before_ hwif_init() call!!!
>
> Moving it is definitely better I agree there - it also allows fixup to
> be used for irq mangling and sg table tweaks which couldn't be done
> before.
>
> I don't see why ita a bug in the present situation - and the code
> certainly works against 10rc1 and 2.6.9 that way but since moving it is
> better I've no problem at all
It depends which fixup you are talking about...
undecoded slave: hwif_init()->init_gendisk()-> drive->present checked
(sysfs and devfs entries registered for "ghost" drive but fixup works)
siimage: hwif_init()->init_irq()->ide_init_queue()-> hwif->rqsize used
(so fixup was executed too late previously)
next prev parent reply other threads:[~2004-11-06 1:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-05 16:42 PATCH: Use the fixup layer to fix the various SI3112 hangs Alan Cox
2004-11-05 22:59 ` Bartlomiej Zolnierkiewicz
2004-11-05 23:24 ` Bartlomiej Zolnierkiewicz
2004-11-05 23:34 ` Alan Cox
2004-11-06 1:00 ` Bartlomiej Zolnierkiewicz [this message]
2004-11-06 0:50 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58cb370e04110517005a88562e@mail.gmail.com \
--to=bzolnier@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.