From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Alan Pope <alan.pope@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
bugs@linux-ide.org, Andre Hedrick <andre@linux-ide.org>
Subject: Re: PDC202XX_OLD broken
Date: Tue, 7 Dec 2004 21:58:52 +0100 [thread overview]
Message-ID: <58cb370e041207125864b97eea@mail.gmail.com> (raw)
In-Reply-To: <1102425655.17950.21.camel@localhost.localdomain>
last mail and http://www.popey.com/promise helped a lot
You are using 40c cable instead of 80c one.
Thus transfer rate is limited to UDMA33.
Moreover pdc202xx_old has a bug in cable detection code.
pdc202xx_old_cable_detect() always returns '0' (which means
80c cable) due to a sloppy coding - result of CIS & mask is
truncated to 8 bits although CIS holds cable info in bits 10-11.
Does this fix work for you?
--- pdc202xx_old.c.orig 2004-11-07 03:14:09.000000000 +0100
+++ pdc202xx_old.c 2004-12-07 15:38:13.644921160 +0100
@@ -230,7 +230,7 @@
{
u16 CIS = 0, mask = (hwif->channel) ? (1<<11) : (1<<10);
pci_read_config_word(hwif->pci_dev, 0x50, &CIS);
- return ((u8)(CIS & mask));
+ return (CIS & mask) ? 1 : 0;
}
/*
next prev parent reply other threads:[~2004-12-07 20:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-06 22:05 PDC202XX_OLD broken Alan Pope
2004-12-06 22:12 ` Fwd: " Alan Pope
2004-12-07 13:21 ` Alan Cox
2004-12-07 20:13 ` Alan Pope
2004-12-07 20:58 ` Bartlomiej Zolnierkiewicz [this message]
2004-12-08 21:25 ` Alan Pope
2004-12-08 21:46 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58cb370e041207125864b97eea@mail.gmail.com \
--to=bzolnier@gmail.com \
--cc=alan.pope@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andre@linux-ide.org \
--cc=bugs@linux-ide.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.