From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/cdrom/isp16.c: small cleanups
Date: Sun, 30 Jan 2005 00:54:30 +0100 [thread overview]
Message-ID: <58cb370e0501291554450fbef8@mail.gmail.com> (raw)
In-Reply-To: <20050129234624.GC3185@stusta.de>
On Sun, 30 Jan 2005 00:46:24 +0100, Adrian Bunk <bunk@stusta.de> wrote:
> On Sat, Jan 29, 2005 at 06:51:25PM +0100, Bartlomiej Zolnierkiewicz wrote:
> > Hi,
> >
> > On Sat, 29 Jan 2005 18:11:08 +0100, Adrian Bunk <bunk@stusta.de> wrote:
> > > This patch makes the needlessly global function isp16_init static.
> > >
> > > As a result, it turned out that both this function and some other code
> > > are only required #ifdef MODULE.
> >
> > Your patch is correct but it is wrong. ;)
> >
> > #ifdefs around isp16_init() need to be removed as
> > otherwise this driver is not initialized in built-in case.
>
> It's somehow initialized via isp16_setup.
Could you explain?
AFAICS isp16_setup() only handles "isp16=" boot parameter.
next prev parent reply other threads:[~2005-01-29 23:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-29 17:11 [2.6 patch] drivers/cdrom/isp16.c: small cleanups Adrian Bunk
2005-01-29 17:51 ` Bartlomiej Zolnierkiewicz
2005-01-29 23:46 ` Adrian Bunk
2005-01-29 23:54 ` Bartlomiej Zolnierkiewicz [this message]
2005-01-30 9:02 ` [FIX] " Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58cb370e0501291554450fbef8@mail.gmail.com \
--to=bzolnier@gmail.com \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.