From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: "Stuart_Hayes@dell.com" <Stuart_Hayes@dell.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 2.6.11.6] ide-scsi: kmap scatter/gather before doing PIO
Date: Tue, 5 Apr 2005 22:27:36 +0200 [thread overview]
Message-ID: <58cb370e0504051327751a19d8@mail.gmail.com> (raw)
In-Reply-To: <7A8F92187EF7A249BF847F1BF4903C04010EEAF7@ausx2kmpc103.aus.amer.dell.com>
Hi,
On Apr 5, 2005 9:12 PM, Stuart_Hayes@dell.com <Stuart_Hayes@dell.com> wrote:
>
> The system can panic with a null pointer dereference using ide-scsi if
> PIO is being done on scatter gather pages that are in high memory,
> because page_address() returns 0. We are actually seeing this using a
> tape drive. This patch will kmap_atomic() the pages before performing
> PIO.
>
> I'm copying the text here, but I'm also attaching it as a file, because
> the text will get garbled with extra line breaks.
>
> Please let me know if there are any problems with the patch!
Looks fine, I have two small requests:
* please don't disable/enable local IRQs for !HIGHMEM case
(see ide_pio_sector() in ide-taskfile.c)
* declare 'unsigned long flags' at the beginning of the function
> (I sent this patch to linux-scsi a few weeks ago, and I was finally told
> that it is maintained by the IDE folks (Bartlomiej Zolnierkiewicz), not
> the SCSI folks...)
I'm not on linux-scsi, *sigh*, somebody could have simply
forwarded it to me...
Thanks!
Bartlomiej
next prev parent reply other threads:[~2005-04-05 20:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-05 19:12 [PATCH 2.6.11.6] ide-scsi: kmap scatter/gather before doing PIO Stuart_Hayes
2005-04-05 20:27 ` Bartlomiej Zolnierkiewicz [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-04-05 21:08 Stuart_Hayes
2005-04-05 21:41 ` Bartlomiej Zolnierkiewicz
2005-04-29 15:45 Stuart_Hayes
2005-04-29 15:53 Stuart_Hayes
2005-05-01 15:49 ` Jens Axboe
2005-05-02 15:17 Stuart_Hayes
2005-05-02 15:46 ` Bartlomiej Zolnierkiewicz
2005-05-02 16:01 ` Jens Axboe
2005-05-02 16:01 ` Jens Axboe
2005-05-02 15:56 Stuart_Hayes
2005-05-02 20:03 Stuart_Hayes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58cb370e0504051327751a19d8@mail.gmail.com \
--to=bzolnier@gmail.com \
--cc=Stuart_Hayes@dell.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.