All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Paolo Wattebled <paolo.wattebled@savoirfairelinux.com>
Cc: bitbake-devel <bitbake-devel@lists.openembedded.org>
Subject: Re: [bitbake-devel] [PATCH] toaster: Add recipe variables view
Date: Tue, 18 Aug 2026 20:04:29 +0100	[thread overview]
Message-ID: <58e087a5908a808a3557f92d3844f79b1cce61cd.camel@linuxfoundation.org> (raw)
In-Reply-To: <515257189.1172159.1787078030404.JavaMail.zimbra@savoirfairelinux.com>

On Tue, 2026-08-18 at 14:33 -0400, Paolo Wattebled wrote:
> Hi Richard,
> 
> > For example if the core metadata has:
> > 
> > X = "${Y}"
> > Y = "Z"
> > 
> > then the recipe sets Y = "A", the variable history for X doesn't change
> > but the value does.
> 
> You are right. My filtering happened before expansion and relied on
> `VariableHistory`, which records direct operations but not changes caused by
> references to other variables. It could therefore omit `X`, even though its
> effective value had changed.
> 
> I removed this history-based filter. The implementation now iterates the
> parsed recipe datastore and stores the expanded value of each included
> variable. I added your example as a regression test, and the snapshot contains
> both `X = "A"` and `Y = "A"`.
> 
> Variables marked as functions and explicit override keys are not stored.
> Active overrides are represented under their logical variable names, and
> non-function flags are stored as `VAR[flag]` entries. Values detected as
> involving inline Python are also omitted to avoid expansion side effects.
> 
> On an `imx-image-core` build, Toaster persisted 598 recipe snapshots with an
> average of 1663 entries, a minimum of 1627 and a maximum of 1944. The compressed
> payload was about 86 MB in total, or 145 kB per recipe on average.
> 
> If you agree with the current scope and semantics, I will generate and send a
> v3 of the series.
> 
> Thanks for pointing this out.

My big concern is that this was the simple example of a problem with
these patches I could find and easily demonstrate. I've tried to hint
at the bigger architecture issues with them but that is a lot harder
for me to try and explain but I don't think you're seeing it.

It leaves me with a dilemma as I doubt the patches are right in their
current form but we're at an impasse over addressing the concerns
without me doing a lot more work.

Not really sure what to do from here.

Cheers,

Richard



  reply	other threads:[~2026-08-18 19:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-12 15:04 [PATCH] toaster: Add recipe variables view Paolo Wattebled
2026-08-12 20:34 ` [bitbake-devel] " Richard Purdie
2026-08-13 15:31   ` Paolo Wattebled
2026-08-13 15:58     ` Richard Purdie
2026-08-14 14:31       ` Paolo Wattebled
2026-08-14 20:56         ` Richard Purdie
2026-08-17 19:48           ` Paolo Wattebled
2026-08-17 21:08             ` Richard Purdie
2026-08-18 18:33               ` Paolo Wattebled
2026-08-18 19:04                 ` Richard Purdie [this message]
2026-08-19 19:16                   ` Paolo Wattebled

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58e087a5908a808a3557f92d3844f79b1cce61cd.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=paolo.wattebled@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.