From: Anand Jain <anand.jain@oracle.com>
To: dsterba@suse.cz
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v3 0/6] part3 trivial adjustments for return variable coding style
Date: Wed, 22 May 2024 01:10:48 +0800 [thread overview]
Message-ID: <58fb580d-160d-40cc-94de-cecf97faed74@oracle.com> (raw)
In-Reply-To: <20240521152120.GQ17126@twin.jikos.cz>
On 5/21/24 23:21, David Sterba wrote:
> On Thu, May 16, 2024 at 07:12:09PM +0800, Anand Jain wrote:
>> This is part 3 of the series, containing renaming with optimization of the
>> return variable.
>>
>> Some of the patches are new it wasn't part of v1 or v2. The new patches follow
>> verb-first format for titles. Older patches not renamed for backward reference.
>>
>> Patchset passed tests -g quick without regressions, sending them first.
>>
>> Patch 3/6 and 4/6 can be merged; they are separated for easier diff.
>
> Splitting the patches like might seem strange but reviewing the changes
> individually is indeed a bit easier so you can keep it like that.
>
>> v2 part2:
>> https://lore.kernel.org/linux-btrfs/cover.1713370756.git.anand.jain@oracle.com/
>> v1:
>> https://lore.kernel.org/linux-btrfs/cover.1710857863.git.anand.jain@oracle.com/
>>
>> Anand Jain (6):
>> btrfs: btrfs_cleanup_fs_roots handle ret variable
>> btrfs: simplify ret in btrfs_recover_relocation
>> btrfs: rename ret in btrfs_recover_relocation
>> btrfs: rename err in btrfs_recover_relocation
>> btrfs: btrfs_drop_snapshot optimize return variable
>> btrfs: rename and optimize return variable in btrfs_find_orphan_roots
>
> I've edited the subject lines from the previous series, please have a
> look and copy the subjects when the kind of change is the same in the
> patch. Also use the () when a function si mentioned in the subject.
> Thanks.
yep. I have updated the patch titles in v4.
Thx. Anand
prev parent reply other threads:[~2024-05-21 17:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-16 11:12 [PATCH v3 0/6] part3 trivial adjustments for return variable coding style Anand Jain
2024-05-16 11:12 ` [PATCH v3 1/6] btrfs: btrfs_cleanup_fs_roots handle ret variable Anand Jain
2024-05-21 15:10 ` David Sterba
2024-05-21 17:08 ` Anand Jain
2024-05-16 11:12 ` [PATCH v3 2/6] btrfs: simplify ret in btrfs_recover_relocation Anand Jain
2024-05-16 11:12 ` [PATCH v3 3/6] btrfs: rename " Anand Jain
2024-05-16 11:12 ` [PATCH v3 4/6] btrfs: rename err " Anand Jain
2024-05-16 11:12 ` [PATCH v3 5/6] btrfs: btrfs_drop_snapshot optimize return variable Anand Jain
2024-05-16 11:12 ` [PATCH v3 6/6] btrfs: rename and optimize return variable in btrfs_find_orphan_roots Anand Jain
2024-05-21 15:18 ` David Sterba
2024-05-21 17:10 ` Anand Jain
2024-05-21 17:59 ` David Sterba
2024-05-23 14:35 ` Anand Jain
2024-05-21 1:04 ` [PATCH v3 0/6] part3 trivial adjustments for return variable coding style Anand Jain
2024-05-21 15:21 ` David Sterba
2024-05-21 17:10 ` Anand Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58fb580d-160d-40cc-94de-cecf97faed74@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.