From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 3AFD1E00B0B; Tue, 25 Apr 2017 22:57:26 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's * domain * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Received: from lelnx193.ext.ti.com (lelnx193.ext.ti.com [198.47.27.77]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id D1D8EE00B01 for ; Tue, 25 Apr 2017 22:57:24 -0700 (PDT) Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by lelnx193.ext.ti.com (8.15.1/8.15.1) with ESMTP id v3Q5vNZd002823 for ; Wed, 26 Apr 2017 00:57:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1493186243; bh=FP+vn8fRijRtf1wASJTPgbRON6aveBCJV+ZFC2PmMhc=; h=Subject:To:References:CC:From:Date:In-Reply-To; b=weQef58n2AN8mJQgtrC5w0RtVEiP/aZPSBHj6ebmQRTQvU4/TaC7Nn2/1TRfxciJ0 FRu3TKBw+cJWAPPzdzWZZp5eDgsG8pYCMn/br9kTsW0ayNB3kwe/A6QxzayUCZKlGx nPfG9sa454RF/CzLfCW2YHyKBEdHnjkcg3omMEQE= Received: from dbdlxv05.itg.ti.com (dbdlxv05.itg.ti.com [172.24.171.60]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id v3Q5vMAw025909 for ; Wed, 26 Apr 2017 00:57:23 -0500 Received: from DBDE72.ent.ti.com (dbde72.ent.ti.com [172.24.171.97]) by dbdlxv05.itg.ti.com (8.14.3/8.13.8) with ESMTP id v3Q5vIE4018088 for ; Wed, 26 Apr 2017 11:27:20 +0530 Received: from [172.24.159.169] (172.24.159.169) by DBDE72.ent.ti.com (172.24.171.97) with Microsoft SMTP Server id 14.3.294.0; Wed, 26 Apr 2017 11:27:15 +0530 To: "Pang, Ivan" , "Dmytriyenko, Denys" , "R, Karthik" References: <1493119564-36769-1-git-send-email-a0393906@ti.com> <20170425231916.GT31608@edge> From: Karthik Ramanan Message-ID: <590036BC.4010306@ti.com> Date: Wed, 26 Apr 2017 11:27:16 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [172.24.159.169] Cc: "meta-ti@yoctoproject.org" Subject: Re: [morty v3 1/3] ti-cgt-arm: add recipe for 16.9.2 X-BeenThere: meta-ti@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-ti layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Apr 2017 05:57:26 -0000 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit On 26-Apr-17 5:09 AM, Pang, Ivan wrote: > Karthik, Denys, > >>> +PV = "16.9.2" > > Would it be better to have this in the recipe filename? I'm not sure if there is a preference. > > Sorry, I haven't kept up with the patch mails. There was a specific reason I moved the PV out of the filename and into the .inc file - I had multiple recipes in RTOS that would need to align with this PV (see ti-cgt-arm-linux.bb and ti-cgt-arm-windows.bb). This would let us update only the .inc file whenever we want to bump up the version. > > Ivan Ivan, Since we decided to remove the linux and windows on the meta-ti context, we decided to move out the PV to the filename. I think we should merge the recipe in its current form and then work on subsequent changes. Would you be fine with that approach? > > -----Original Message----- > From: meta-ti-bounces@yoctoproject.org [mailto:meta-ti-bounces@yoctoproject.org] On Behalf Of Dmytriyenko, Denys > Sent: Tuesday, April 25, 2017 6:19 PM > To: R, Karthik > Cc: meta-ti@yoctoproject.org > Subject: Re: [meta-ti] [morty v3 1/3] ti-cgt-arm: add recipe for 16.9.2 > > Karthik, > > This looks much better! > > I would have said there's no reason to split it into a recipe and .inc anymore, but we'll probably also need a -nativesdk recipe, so keeping .inc for now. > > There are couple cosmetic nitpicks - there's no space between SUMMARY and = sign; and BINFILE variable is defined twice. I'll fix those on merge though. Thank you Denys, I will make a note on these points. The recipe went through a lot of rework and I overlooked these aspects. > > -- > Denys > > > On Tue, Apr 25, 2017 at 04:56:02PM +0530, Karthik Ramanan wrote: >> Signed-off-by: Karthik Ramanan >> --- >> recipes-ti/devtools/ti-cgt-arm-native_16.9.2.bb | 8 ++++++ >> recipes-ti/devtools/ti-cgt-arm.inc | 35 +++++++++++++++++++++++++ >> 2 files changed, 43 insertions(+) >> create mode 100644 recipes-ti/devtools/ti-cgt-arm-native_16.9.2.bb >> create mode 100644 recipes-ti/devtools/ti-cgt-arm.inc >> >> diff --git a/recipes-ti/devtools/ti-cgt-arm-native_16.9.2.bb b/recipes-ti/devtools/ti-cgt-arm-native_16.9.2.bb >> new file mode 100644 >> index 0000000..c4fc7f0 >> --- /dev/null >> +++ b/recipes-ti/devtools/ti-cgt-arm-native_16.9.2.bb >> @@ -0,0 +1,8 @@ >> +include ti-cgt-arm.inc >> + >> +LIC_FILES_CHKSUM = "file://ti-cgt-arm_${PV}.LTS/README.txt;md5=c32eadd03472353c042a8a7c4568438b" >> + >> +BINFILE_MD5 = "7b73e51e9548a4a0bf3923a336b1a974" >> +BINFILE_SHA256 = "d1a5c255319088be7d75b3fce1b16a2e3d60c75023db7dad16cab6d4d3425d06" >> + >> +PR_append = "r2" >> diff --git a/recipes-ti/devtools/ti-cgt-arm.inc b/recipes-ti/devtools/ti-cgt-arm.inc >> new file mode 100644 >> index 0000000..8cc1ca4 >> --- /dev/null >> +++ b/recipes-ti/devtools/ti-cgt-arm.inc >> @@ -0,0 +1,35 @@ >> +SUMMARY= "TI ARM Code Generation Tools" >> +HOMEPAGE = "https://www-a.ti.com/downloads/sds_support/TICodegenerationTools/download.htm" >> +LICENSE = "(TI-TSPA & Thai-Open-Source-Software-Center) & BSD-3-Clause & BSL-1.0 & Hewlett-Packard & AFL-3.0 & MIT & BSD-2-Clause & PD & BSD-4-Clause" >> + >> +inherit native >> +require recipes-ti/includes/ti-unpack.inc >> +require recipes-ti/includes/ti-staging.inc >> +require recipes-ti/includes/ti-paths.inc >> + >> +S = "${WORKDIR}/ti-cgt-arm-${PV}" >> + >> +SRC_URI = "http://software-dl.ti.com/codegen/esd/cgt_public_sw/TMS470/${PV}.LTS/${BINFILE};name=${BINFILE_NAME}" >> + >> +BINFILE = "ti_cgt_tms470_${PV}.LTS_linux_installer_x86.bin" >> +TI_BIN_UNPK_ARGS = "--prefix ${S}" >> +TI_BIN_UNPK_CMDS = "" >> + >> +do_install() { >> + install -d ${D}${M4_TOOLCHAIN_INSTALL_DIR_RECIPE} >> + cp -r ${S}/ti-cgt-arm*/. ${D}${M4_TOOLCHAIN_INSTALL_DIR_RECIPE} >> +} >> + >> +SRC_URI[cgt_arm_installer.md5sum] = "${BINFILE_MD5}" >> +SRC_URI[cgt_arm_installer.sha256sum] = "${BINFILE_SHA256}" >> + >> +BINFILE_NAME = "cgt_arm_installer" >> +BINFILE = "ti_cgt_tms470_${PV}.LTS_linux_installer_x86.bin" >> + >> +FILES_${PN} += "${M4_TOOLCHAIN_INSTALL_DIR_RECIPE}" >> + >> +INHIBIT_PACKAGE_STRIP = "1" >> +INHIBIT_SYSROOT_STRIP = "1" >> +INHIBIT_PACKAGE_DEBUG_SPLIT = "1" >> + >> +INSANE_SKIP_${PN} += "arch staticdev" >> -- >> 1.9.1 >> >> -- >> _______________________________________________ >> meta-ti mailing list >> meta-ti@yoctoproject.org >> https://lists.yoctoproject.org/listinfo/meta-ti