All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 09/11] i2c: Drop CONFIG_SYS_I2C_BOARD_LATE_INIT
Date: Fri, 28 Apr 2017 06:57:17 +0200	[thread overview]
Message-ID: <5902CBAD.7090803@denx.de> (raw)
In-Reply-To: <20170423153525.14882-10-sjg@chromium.org>

Hello Simon,

Am 23.04.2017 um 17:35 schrieb Simon Glass:
> This option is not used by any boards. Drop it.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
>   README                       | 11 -----------
>   drivers/i2c/fsl_i2c.c        |  9 ---------
>   drivers/i2c/fti2c010.c       |  9 ---------
>   include/i2c.h                |  3 ---
>   scripts/config_whitelist.txt |  1 -
>   5 files changed, 33 deletions(-)

Reviewed-by: Heiko Schocher <hs@denx.de>

Applied to u-boot-i2c/next

bye,
Heiko
>
> diff --git a/README b/README
> index f75dc0f2f6..aee17cb35d 100644
> --- a/README
> +++ b/README
> @@ -2333,17 +2333,6 @@ The following options need to be configured:
>   		custom i2c_init_board() routine in boards/xxx/board.c
>   		is run early in the boot sequence.
>
> -		CONFIG_SYS_I2C_BOARD_LATE_INIT
> -
> -		An alternative to CONFIG_SYS_I2C_INIT_BOARD. If this option is
> -		defined a custom i2c_board_late_init() routine in
> -		boards/xxx/board.c is run AFTER the operations in i2c_init()
> -		is completed. This callpoint can be used to unreset i2c bus
> -		using CPU i2c controller register accesses for CPUs whose i2c
> -		controller provide such a method. It is called at the end of
> -		i2c_init() to allow i2c_init operations to setup the i2c bus
> -		controller on the CPU (e.g. setting bus speed & slave address).
> -
>   		CONFIG_I2CFAST (PPC405GP|PPC405EP only)
>
>   		This option enables configuration of bi_iic_fast[] flags
> diff --git a/drivers/i2c/fsl_i2c.c b/drivers/i2c/fsl_i2c.c
> index a1406baa87..ff3dc25927 100644
> --- a/drivers/i2c/fsl_i2c.c
> +++ b/drivers/i2c/fsl_i2c.c
> @@ -284,15 +284,6 @@ static void __i2c_init(const struct fsl_i2c_base *base, int speed, int
>
>   		break;
>   	}
> -
> -#ifdef CONFIG_SYS_I2C_BOARD_LATE_INIT
> -	/* Call board specific i2c bus reset routine AFTER the bus has been
> -	 * initialized. Use either this callpoint or i2c_init_board;
> -	 * which is called before i2c_init operations.
> -	 * For details about this problem see doc/I2C_Edge_Conditions.
> -	*/
> -	i2c_board_late_init();
> -#endif
>   }
>
>   static int
> diff --git a/drivers/i2c/fti2c010.c b/drivers/i2c/fti2c010.c
> index b35d0d2d9c..4da959fa53 100644
> --- a/drivers/i2c/fti2c010.c
> +++ b/drivers/i2c/fti2c010.c
> @@ -146,15 +146,6 @@ static void fti2c010_init(struct i2c_adapter *adap, int speed, int slaveaddr)
>   	set_i2c_bus_speed(chip, speed);
>
>   	/* slave init, don't care */
> -
> -#ifdef CONFIG_SYS_I2C_BOARD_LATE_INIT
> -	/* Call board specific i2c bus reset routine AFTER the bus has been
> -	 * initialized. Use either this callpoint or i2c_init_board;
> -	 * which is called before fti2c010_init operations.
> -	 * For details about this problem see doc/I2C_Edge_Conditions.
> -	*/
> -	i2c_board_late_init();
> -#endif
>   }
>
>   /*
> diff --git a/include/i2c.h b/include/i2c.h
> index cd7f61e1c1..a88cc7cddf 100644
> --- a/include/i2c.h
> +++ b/include/i2c.h
> @@ -706,9 +706,6 @@ void i2c_early_init_f(void);
>   #endif
>   void i2c_init(int speed, int slaveaddr);
>   void i2c_init_board(void);
> -#ifdef CONFIG_SYS_I2C_BOARD_LATE_INIT
> -void i2c_board_late_init(void);
> -#endif
>
>   #ifdef CONFIG_SYS_I2C
>   /*
> diff --git a/scripts/config_whitelist.txt b/scripts/config_whitelist.txt
> index d18497c448..837c75f500 100644
> --- a/scripts/config_whitelist.txt
> +++ b/scripts/config_whitelist.txt
> @@ -4358,7 +4358,6 @@ CONFIG_SYS_I2C_BASE2
>   CONFIG_SYS_I2C_BASE3
>   CONFIG_SYS_I2C_BASE4
>   CONFIG_SYS_I2C_BASE5
> -CONFIG_SYS_I2C_BOARD_LATE_INIT
>   CONFIG_SYS_I2C_BOOT_EEPROM_ADDR
>   CONFIG_SYS_I2C_BUSES
>   CONFIG_SYS_I2C_BUS_MAX
>

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2017-04-28  4:57 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-23 15:35 [U-Boot] [PATCH 00/11] i2c: Remove old I2C support Simon Glass
2017-04-23 15:35 ` [U-Boot] [PATCH 01/11] i2c: Drop use of CONFIG_I2C_HARD Simon Glass
2017-04-28  4:35   ` Heiko Schocher
2017-04-23 15:35 ` [U-Boot] [PATCH 02/11] i2c: powerpc: Remove use of CONFIG_HARD_I2C Simon Glass
2017-04-28  4:43   ` Heiko Schocher
2017-04-23 15:35 ` [U-Boot] [PATCH 03/11] i2c: cm5200: Drop use of CONFIG_I2C_HARD Simon Glass
2017-04-28  4:44   ` Heiko Schocher
2017-04-23 15:35 ` [U-Boot] [PATCH 04/11] i2c: pdm360ng: " Simon Glass
2017-04-28  4:45   ` Heiko Schocher
2017-04-23 15:35 ` [U-Boot] [PATCH 05/11] i2c: keymile: " Simon Glass
2017-04-24  7:22   ` Holger Brunck
2017-04-28  4:46   ` Heiko Schocher
2017-04-23 15:35 ` [U-Boot] [PATCH 06/11] i2c: mxc_i2c: " Simon Glass
2017-04-28  4:48   ` Heiko Schocher
2017-04-23 15:35 ` [U-Boot] [PATCH 07/11] i2c: " Simon Glass
2017-04-25  3:03   ` Lokesh Vutla
2017-04-25  7:56     ` Heiko Schocher
2017-04-25  8:15       ` Lokesh Vutla
2017-04-28  4:54   ` Heiko Schocher
2017-04-28  4:56     ` Lokesh Vutla
2017-04-28 11:33       ` Tom Rini
2017-04-23 15:35 ` [U-Boot] [PATCH 08/11] i2c: README: Drop CONFIG_SYS_I2C_INIT_MPC5XXX Simon Glass
2017-04-28  4:55   ` Heiko Schocher
2017-04-23 15:35 ` [U-Boot] [PATCH 09/11] i2c: Drop CONFIG_SYS_I2C_BOARD_LATE_INIT Simon Glass
2017-04-28  4:57   ` Heiko Schocher [this message]
2017-04-23 15:35 ` [U-Boot] [PATCH 10/11] Drop CONFIG_I2CFAST Simon Glass
2017-04-28  4:58   ` Heiko Schocher
2017-04-23 15:35 ` [U-Boot] [PATCH 11/11] Drop use of CONFIG_I2C_SOFT Simon Glass
2017-04-28  4:59   ` Heiko Schocher
2017-04-24  6:44 ` [U-Boot] [PATCH 00/11] i2c: Remove old I2C support Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5902CBAD.7090803@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.