From: Daniel Borkmann <daniel@iogearbox.net>
To: Jakub Kicinski <jakub.kicinski@netronome.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net, johannes@sipsolutions.net,
dsa@cumulusnetworks.com, alexei.starovoitov@gmail.com,
bblanco@gmail.com, john.fastabend@gmail.com, kubakici@wp.pl,
oss-drivers@netronome.com, brouer@redhat.com, jhs@mojatatu.com
Subject: Re: [PATCH net-next 1/4] netlink: add NULL-friendly helper for setting extended ACK message
Date: Mon, 01 May 2017 12:45:53 +0200 [thread overview]
Message-ID: <590711E1.7060400@iogearbox.net> (raw)
In-Reply-To: <20170501044648.13022-2-jakub.kicinski@netronome.com>
On 05/01/2017 06:46 AM, Jakub Kicinski wrote:
> As we propagate extended ack reporting throughout various paths in
> the kernel it may be that the same function is called with the
> extended ack parameter passed as NULL. One place where that happens
> is in drivers which have a centralized reconfiguration function
> called both from ndos and from ethtool_ops. Add a new helper for
> setting the error message in such conditions.
>
> Existing helper is left as is to encourage propagating the ext act
> fully wherever possible. It also makes it clear in the code which
> messages may be lost due to ext ack being NULL.
>
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
next prev parent reply other threads:[~2017-05-01 10:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-01 4:46 [PATCH net-next 0/4] xdp: use netlink extended ACK reporting Jakub Kicinski
2017-05-01 4:46 ` [PATCH net-next 1/4] netlink: add NULL-friendly helper for setting extended ACK message Jakub Kicinski
2017-05-01 10:45 ` Daniel Borkmann [this message]
2017-05-01 4:46 ` [PATCH net-next 2/4] xdp: propagate extended ack to XDP setup Jakub Kicinski
2017-05-01 10:46 ` Daniel Borkmann
2017-05-01 4:46 ` [PATCH net-next 3/4] nfp: make use of extended ack message reporting Jakub Kicinski
2017-05-01 10:46 ` Daniel Borkmann
2017-05-01 4:46 ` [PATCH net-next 4/4] virtio_net: " Jakub Kicinski
2017-05-01 10:50 ` Daniel Borkmann
2017-05-01 14:34 ` David Miller
2017-05-01 10:32 ` [oss-drivers] [PATCH net-next 0/4] xdp: use netlink extended ACK reporting Simon Horman
2017-05-01 14:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=590711E1.7060400@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=alexei.starovoitov@gmail.com \
--cc=bblanco@gmail.com \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=jakub.kicinski@netronome.com \
--cc=jhs@mojatatu.com \
--cc=johannes@sipsolutions.net \
--cc=john.fastabend@gmail.com \
--cc=kubakici@wp.pl \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.