From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Subject: Re: [PATCH net-next 1/4] netlink: add NULL-friendly helper for setting extended ACK message Date: Mon, 01 May 2017 12:45:53 +0200 Message-ID: <590711E1.7060400@iogearbox.net> References: <20170501044648.13022-1-jakub.kicinski@netronome.com> <20170501044648.13022-2-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, johannes@sipsolutions.net, dsa@cumulusnetworks.com, alexei.starovoitov@gmail.com, bblanco@gmail.com, john.fastabend@gmail.com, kubakici@wp.pl, oss-drivers@netronome.com, brouer@redhat.com, jhs@mojatatu.com To: Jakub Kicinski , netdev@vger.kernel.org Return-path: Received: from www62.your-server.de ([213.133.104.62]:41048 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946122AbdEAKp6 (ORCPT ); Mon, 1 May 2017 06:45:58 -0400 In-Reply-To: <20170501044648.13022-2-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: On 05/01/2017 06:46 AM, Jakub Kicinski wrote: > As we propagate extended ack reporting throughout various paths in > the kernel it may be that the same function is called with the > extended ack parameter passed as NULL. One place where that happens > is in drivers which have a centralized reconfiguration function > called both from ndos and from ethtool_ops. Add a new helper for > setting the error message in such conditions. > > Existing helper is left as is to encourage propagating the ext act > fully wherever possible. It also makes it clear in the code which > messages may be lost due to ext ack being NULL. > > Signed-off-by: Jakub Kicinski Acked-by: Daniel Borkmann