From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Subject: Re: [PATCH net-next 4/4] virtio_net: make use of extended ack message reporting Date: Mon, 01 May 2017 12:50:55 +0200 Message-ID: <5907130F.7070807@iogearbox.net> References: <20170501044648.13022-1-jakub.kicinski@netronome.com> <20170501044648.13022-5-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, johannes@sipsolutions.net, dsa@cumulusnetworks.com, alexei.starovoitov@gmail.com, bblanco@gmail.com, john.fastabend@gmail.com, kubakici@wp.pl, oss-drivers@netronome.com, brouer@redhat.com, jhs@mojatatu.com To: Jakub Kicinski , netdev@vger.kernel.org Return-path: Received: from www62.your-server.de ([213.133.104.62]:41857 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S376955AbdEAKvR (ORCPT ); Mon, 1 May 2017 06:51:17 -0400 In-Reply-To: <20170501044648.13022-5-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: On 05/01/2017 06:46 AM, Jakub Kicinski wrote: > Try to carry error messages to the user via the netlink extended > ack message attribute. > > Signed-off-by: Jakub Kicinski [...] > @@ -1890,16 +1891,17 @@ static int virtnet_xdp_set(struct net_device *dev, struct bpf_prog *prog) > virtio_has_feature(vi->vdev, VIRTIO_NET_F_GUEST_TSO6) || > virtio_has_feature(vi->vdev, VIRTIO_NET_F_GUEST_ECN) || > virtio_has_feature(vi->vdev, VIRTIO_NET_F_GUEST_UFO)) { > - netdev_warn(dev, "can't set XDP while host is implementing LRO, disable LRO first\n"); > + NL_SET_ERR_MSG(extack, "can't set XDP while host is implementing LRO, disable LRO first"); Should this be NL_MOD_TRY_SET_ERR_MSG() as well like in nfp case (otherwise the 'if (_extack)' check might be missing from the macro)? Thanks, Daniel