From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guoqing Jiang Subject: Re: [PATCH] md/raid10: skip spare disk as 'first' disk Date: Tue, 2 May 2017 09:22:57 +0800 Message-ID: <5907DF71.10806@suse.com> References: <7adb3f88bd6d611511ad14dcf8da6898e5f8168d.1493666464.git.shli@fb.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <7adb3f88bd6d611511ad14dcf8da6898e5f8168d.1493666464.git.shli@fb.com> Sender: linux-raid-owner@vger.kernel.org To: Shaohua Li , linux-raid@vger.kernel.org Cc: NeilBrown List-Id: linux-raid.ids On 05/02/2017 03:22 AM, Shaohua Li wrote: > Commit 6f287ca(md/raid10: reset the 'first' at the end of loop) ignores > a case in reshape, the first rdev could be a spare disk, which shouldn't > be accounted as the first disk since it doesn't include the offset info. Acked-by: Guoqing Jiang Thanks, Guoqing > Fix: 6f287ca(md/raid10: reset the 'first' at the end of loop) > Cc: Guoqing Jiang > Cc: NeilBrown > Signed-off-by: Shaohua Li > --- > drivers/md/raid10.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c > index 2883b72..cce23be 100644 > --- a/drivers/md/raid10.c > +++ b/drivers/md/raid10.c > @@ -4079,8 +4079,8 @@ static int raid10_start_reshape(struct mddev *mddev) > diff = 0; > if (first || diff < min_offset_diff) > min_offset_diff = diff; > + first = 0; > } > - first = 0; > } > > if (max(before_length, after_length) > min_offset_diff)