From: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
To: Adam Stylinski <adam.stylinski@etegent.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Peter Zijlstra <peterz@infradead.org>,
Taeung Song <treeze.taeung@gmail.com>,
linux-kernel@vger.kernel.org,
Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Subject: Re: [PATCH] Fixed a pathing issue with objdump and grep
Date: Fri, 5 May 2017 19:00:47 +0530 [thread overview]
Message-ID: <590C7E87.3040807@linux.vnet.ibm.com> (raw)
In-Reply-To: <590C7CB2.6000409@linux.vnet.ibm.com>
On Friday 05 May 2017 06:52 PM, Ravi Bangoria wrote:
>
> On Friday 05 May 2017 06:27 PM, Arnaldo Carvalho de Melo wrote:
>> Em Wed, May 03, 2017 at 12:12:23PM +0000, Adam Stylinski escreveu:
>>> The path fed to the argument for objdump used in the perf-annotate
>>> feature didn't escape spaces. The subsequent argument to grep for
>>> the name of the DSO containing symbols also assumed no spaces existed
>>> in the pathname, so grep also parsed these as extra positional
>>> arguments.
>> This one didn't apply to tip/perf/urgent, so I tried another patch
>> addressing the same issue, from Ravi Bangoria, and it applied, ok?
> Oh, I was not aware about this patch. Coincidently, I sent the same fix. :)
BTW, Adam, Looks like you have older code. The same line was recently
changed by Taeung Song in commit e7cb9de211ebb29. I don't see that
change in your code.
Ravi
prev parent reply other threads:[~2017-05-05 13:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-03 12:12 [PATCH] Fixed a pathing issue with objdump and grep Adam Stylinski
2017-05-05 12:57 ` Arnaldo Carvalho de Melo
2017-05-05 13:22 ` Ravi Bangoria
2017-05-05 13:30 ` Ravi Bangoria [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=590C7E87.3040807@linux.vnet.ibm.com \
--to=ravi.bangoria@linux.vnet.ibm.com \
--cc=acme@kernel.org \
--cc=adam.stylinski@etegent.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=borntraeger@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=treeze.taeung@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.