All of lore.kernel.org
 help / color / mirror / Atom feed
From: zhoucm1 <david1.zhou-5C7GfCeVMHo@public.gmane.org>
To: Felix Kuehling <felix.kuehling-5C7GfCeVMHo@public.gmane.org>,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [RFC] Problems with SRBM select on KIQ
Date: Tue, 9 May 2017 10:45:05 +0800	[thread overview]
Message-ID: <59112D31.90909@amd.com> (raw)
In-Reply-To: <f7f5d054-3288-3f8f-710f-594cca81f482-5C7GfCeVMHo@public.gmane.org>



On 2017年05月06日 06:57, Felix Kuehling wrote:
> We ran into a similar problem when we played with priorities on KFD
> queues. You can't change an MQD of a currently mapped queue. To change a
> queue priority we need to unmap it, update the MQD, and then map it again.
I wonder if there is similar requirement when engine soft reset happens.
We encounter the issue that KIQ doesn't work any more after gfx/compute 
engine soft reset.

Regards,
David Zhou
>
> I wonder if a queue can change its own priority by using register write
> commands in the queue itself.
>
> Regards,
>    Felix
>
>
> On 17-05-05 06:40 PM, Alex Deucher wrote:
>> On Fri, May 5, 2017 at 1:10 PM, Andres Rodriguez <andresx7@gmail.com> wrote:
>>> Hey Everyone,
>>>
>>> On one of the previous comments for this series I received feedback that
>>> the register programming should be done through the KIQ. This series has
>>> the relevant changes.
>>>
>>> However, register writes that require an srbm_select are not working
>>> correctly. The effect is as if the write never happened.
>>>
>>> Maybe I'm just doing something silly or dumb in here, but I can't really
>>> see it. Possibly the way I try to perform the srbm_select for KIQ?
>>>
>>> Any feedback on this issue is appreciated.
>> I think to make this work, you'd probably need to do is unmap the
>> queue, update the priority in the mqd, and then map it again.  It's
>> probably more efficient to use runlists, but that is a lot of work.
>>
>> Alex
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

      parent reply	other threads:[~2017-05-09  2:45 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-05 17:10 [RFC] Problems with SRBM select on KIQ Andres Rodriguez
     [not found] ` <20170505171015.4672-1-andresx7-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-05-05 17:10   ` [PATCH 1/8] drm/amdgpu: add parameter to allocate high priority contexts v9 Andres Rodriguez
2017-05-05 17:10   ` [PATCH 2/8] drm/amdgpu: add framework for HW specific priority settings v6 Andres Rodriguez
2017-05-05 17:10   ` [PATCH 3/8] drm/amdgpu: separate KIQ operations from amdgpu_virt Andres Rodriguez
2017-05-05 17:10   ` [PATCH 4/8] drm/amdgpu: convert kiq ring_mutex to a spinlock Andres Rodriguez
     [not found]     ` <20170505171015.4672-5-andresx7-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-05-08  5:58       ` Liu, Monk
     [not found]         ` <DM5PR12MB1610B5F2D27E49A2F756B59184EE0-2J9CzHegvk++jCVTvoAFKAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-05-08  6:08           ` Liu, Monk
     [not found]             ` <DM5PR12MB1610D5D12607A122B53395E284EE0-2J9CzHegvk++jCVTvoAFKAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-05-08 15:41               ` Andres Rodriguez
     [not found]                 ` <544E607D03B20249AA404517E498FC469FE655-Lp/cVzEoVyaisxZYEgh0i620KmCxYQEWVpNB7YpNyf8@public.gmane.org>
2017-05-09  3:51                   ` Liu, Monk
     [not found]                     ` <DM5PR12MB16109893E9AD4A0CC4583DE284EF0-2J9CzHegvk++jCVTvoAFKAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-05-09  4:03                       ` Andres Rodriguez
2017-05-05 17:10   ` [PATCH 5/8] drm/amdgpu: add option to force register ops through kiq Andres Rodriguez
2017-05-05 17:10   ` [PATCH 6/8] drm/amdgpu: add macro for asynchronous KIQ register writes Andres Rodriguez
2017-05-05 17:10   ` [PATCH 7/8] drm/amdgpu/vi: add mechanism to edit the kiq srbm window Andres Rodriguez
2017-05-05 17:10   ` [PATCH 8/8] drm/amdgpu: implement ring set_priority for gfx_v8 compute v7 Andres Rodriguez
2017-05-05 22:40   ` [RFC] Problems with SRBM select on KIQ Alex Deucher
     [not found]     ` <CADnq5_MQjufZkdS-7uCYEhe9FuJGGSWxhjveKDzBynA6f1UFJQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-05 22:57       ` Felix Kuehling
     [not found]         ` <f7f5d054-3288-3f8f-710f-594cca81f482-5C7GfCeVMHo@public.gmane.org>
2017-05-06  0:51           ` Andres Rodriguez
2017-05-09  2:45           ` zhoucm1 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59112D31.90909@amd.com \
    --to=david1.zhou-5c7gfcevmho@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=felix.kuehling-5C7GfCeVMHo@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.