Re: [dpdk-stable] [PATCH] net/ixgbe: fix calling null function of VF

[Laurent Hardy <laurent.hardy@6wind.com>]

Hi Ferruh, Wei, Roger,
PSB
I also redo test plan provided through 
http://dpdk.org/dev/patchwork/patch/20502/

Thanks & regards,
Laurent

On 05/10/2017 02:20 PM, Roger B. Melton wrote:
>
>
> On 5/10/17 5:50 AM, Ferruh Yigit wrote:
>> On 5/10/2017 8:00 AM, Wei Dai wrote:
>>> hw->mac.ops.get_media-type() of ixgbe VF is NULL and should not
>>> be called directly. It had better be replaced by calling
>>> ixgbe_get_media_type( ) to avoid crash.
>>>
>>> Fixes: c12d22f65b13 ("net/ixgbe: ensure link status is updated")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Wei Dai <wei.dai@intel.com>
Acked-by: Laurent Hardy <laurent.hardy@6wind.com>
>> Hi Roger and Laurent,
>>
>> This is very close the release, can you please support verifying this
>> defect?
>>
>> An explicit Acked-by and/or Tested-by would help a lot.
>>
>> Thanks,
>> ferruh
>
> Hi Ferruh,
>
> Happy to test it.  I'll get back to you shortly.
>
> Regards,
> Roger
>
>>
>>
>>> ---
>>>   drivers/net/ixgbe/ixgbe_ethdev.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c 
>>> b/drivers/net/ixgbe/ixgbe_ethdev.c
>>> index ec667d8..ed2baec 100644
>>> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
>>> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
>>> @@ -3799,7 +3799,7 @@ ixgbe_dev_link_update(struct rte_eth_dev *dev, 
>>> int wait_to_complete)
>>>       hw->mac.get_link_status = true;
>>>         if ((intr->flags & IXGBE_FLAG_NEED_LINK_CONFIG) &&
>>> -        hw->mac.ops.get_media_type(hw) == ixgbe_media_type_fiber) {
>>> +        ixgbe_get_media_type(hw) == ixgbe_media_type_fiber) {
>>>           speed = hw->phy.autoneg_advertised;
>>>           if (!speed)
>>>               ixgbe_get_link_capabilities(hw, &speed, &autoneg);
>>>
>> .
>>
>