From: "Jermain Horsman" <jermain.horsman@nedap.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/3] useradd.bbclass: Fix order of postinst-useradd-*
Date: Fri, 23 Feb 2024 01:10:27 -0800 [thread overview]
Message-ID: <5914.1708679427032535180@lists.openembedded.org> (raw)
In-Reply-To: <5eb199fe11d71f598726b75808b3330cd3efd2e5.1708613381.git.pidge@baylibre.com>
Although I did notice the rest of the file uses this syntax,
and I do not believe there are any guidelines specific to this (that I am aware of),
I did want to comment on this.
> + if test "x$1" = "xgroup"; then
> + if test "x$1" = "xuser"; then
> + if test "x$1" = "xgroupmems"; then
As these are quotes variables the added 'x' doesn't really add anything here.
> + if test "x$1" = "x"; then
Same here, but this could just test for a zero length variable instead using 'test -z "$1"'.
Sincerely,
Jermain Horsman
next prev parent reply other threads:[~2024-02-23 9:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 14:53 [PATCH 0/3] Useradd postinstall fixes and tests Eilís 'pidge' Ní Fhlannagáin
2024-02-22 14:53 ` [PATCH 1/3] useradd.bbclass: Fix order of postinst-useradd-* Eilís 'pidge' Ní Fhlannagáin
2024-02-22 15:02 ` [OE-core] " Richard Purdie
2024-02-22 15:05 ` Piotr Łobacz
2024-02-23 9:10 ` Jermain Horsman [this message]
2024-02-23 9:36 ` ChenQi
2024-02-23 9:57 ` Piotr Łobacz
2024-02-22 14:53 ` [PATCH 2/3] selftest-users: Convoluted selftest for USERADD_DEPENDS Eilís 'pidge' Ní Fhlannagáin
2024-02-22 14:53 ` [PATCH 3/3] creategroup*: Remove coreutils-native as a DEPENDS Eilís 'pidge' Ní Fhlannagáin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5914.1708679427032535180@lists.openembedded.org \
--to=jermain.horsman@nedap.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.