From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from perceval.ideasonboard.com ([213.167.242.64]:58744 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727170AbeIQP1n (ORCPT ); Mon, 17 Sep 2018 11:27:43 -0400 From: Laurent Pinchart To: Geert Uytterhoeven Cc: Simon Horman , Laurent Pinchart , DRI Development , Linux-Renesas , uli@fpond.eu, Kieran Bingham Subject: Re: [PATCH v2 13/16] arm64: dts: renesas: r8a77990: Add display output support Date: Mon, 17 Sep 2018 13:01:15 +0300 Message-ID: <5915801.JlFAhZJqeN@avalon> In-Reply-To: References: <20180914091046.483-1-laurent.pinchart+renesas@ideasonboard.com> <3481349.HLygXACKyS@avalon> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Geert, On Monday, 17 September 2018 12:48:12 EEST Geert Uytterhoeven wrote: > On Mon, Sep 17, 2018 at 11:09 AM Laurent Pinchart wrote: > > On Monday, 17 September 2018 11:51:06 EEST Simon Horman wrote: > >> On Mon, Sep 17, 2018 at 11:38:43AM +0300, Laurent Pinchart wrote: > >>> On Monday, 17 September 2018 10:50:55 EEST Simon Horman wrote: > >>>> On Fri, Sep 14, 2018 at 12:10:43PM +0300, Laurent Pinchart wrote: > >>>>> The R8A77990 (E3) platform has one RGB output and two LVDS outputs > >>>>> connected to the DU. Add the DT nodes for the DU, LVDS encoders > >>>>> and supporting VSP and FCP. > >>>>> > >>>>> Signed-off-by: Laurent Pinchart > >>>>> > >>>>> Tested-by: Jacopo Mondi > >>>>> --- > >>>>> > >>>>> arch/arm64/boot/dts/renesas/r8a77990.dtsi | 167 +++++++++++++++++ > >>>>> 1 file changed, 167 insertions(+) > >>>>> > >>>>> diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi > >>>>> b/arch/arm64/boot/dts/renesas/r8a77990.dtsi index > >>>>> abb14af76c0e..600074ca3ee5 100644 > >>>>> --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi > >>>>> +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi > >>>>> @@ -537,6 +537,173 @@ > >>>>> resets = <&cpg 408>; > >>>>> }; > >>>> > >>>> These nodes should be placed after the gic to preserve the sorting > >>>> of nodes by bus address and then IP block. > >>> > >>> Aren't they already ? :-) > >> > >> Git didn't seem to think so. But its not a big deal, > >> I can fix this up locally. > > > > Did it apply the below hunk to a different location ? 408 is the gic, > > isn't it ? > > The "-U " option (with sufficiently large) of "git diff" and "git > show" is a great help for inspecting DT changes. I know. This is what I have in my tree: diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/ renesas/r8a77990.dtsi index abb14af76c0e..935bb313d29f 100644 --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi @@ -522,32 +522,199 @@ gic: interrupt-controller@f1010000 { compatible = "arm,gic-400"; #interrupt-cells = <3>; #address-cells = <0>; interrupt-controller; reg = <0x0 0xf1010000 0 0x1000>, <0x0 0xf1020000 0 0x20000>, <0x0 0xf1040000 0 0x20000>, <0x0 0xf1060000 0 0x20000>; interrupts = ; clocks = <&cpg CPG_MOD 408>; clock-names = "clk"; power-domains = <&sysc 32>; resets = <&cpg 408>; }; + vspb0: vsp@fe960000 { + compatible = "renesas,vsp2"; + reg = <0 0xfe960000 0 0x8000>; + interrupts = ; + clocks = <&cpg CPG_MOD 626>; + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; + resets = <&cpg 626>; + renesas,fcp = <&fcpvb0>; + }; [snip] so I don't see where the problem that Simon pointed out is, especially given that I took care to sort nodes out properly this time. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2 13/16] arm64: dts: renesas: r8a77990: Add display output support Date: Mon, 17 Sep 2018 13:01:15 +0300 Message-ID: <5915801.JlFAhZJqeN@avalon> References: <20180914091046.483-1-laurent.pinchart+renesas@ideasonboard.com> <3481349.HLygXACKyS@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id E4ECA6E24B for ; Mon, 17 Sep 2018 10:01:02 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Geert Uytterhoeven Cc: uli@fpond.eu, Laurent Pinchart , Kieran Bingham , DRI Development , Linux-Renesas , Simon Horman List-Id: dri-devel@lists.freedesktop.org SGkgR2VlcnQsCgpPbiBNb25kYXksIDE3IFNlcHRlbWJlciAyMDE4IDEyOjQ4OjEyIEVFU1QgR2Vl cnQgVXl0dGVyaG9ldmVuIHdyb3RlOgo+IE9uIE1vbiwgU2VwIDE3LCAyMDE4IGF0IDExOjA5IEFN IExhdXJlbnQgUGluY2hhcnQgd3JvdGU6Cj4gPiBPbiBNb25kYXksIDE3IFNlcHRlbWJlciAyMDE4 IDExOjUxOjA2IEVFU1QgU2ltb24gSG9ybWFuIHdyb3RlOgo+ID4+IE9uIE1vbiwgU2VwIDE3LCAy MDE4IGF0IDExOjM4OjQzQU0gKzAzMDAsIExhdXJlbnQgUGluY2hhcnQgd3JvdGU6Cj4gPj4+IE9u IE1vbmRheSwgMTcgU2VwdGVtYmVyIDIwMTggMTA6NTA6NTUgRUVTVCBTaW1vbiBIb3JtYW4gd3Jv dGU6Cj4gPj4+PiBPbiBGcmksIFNlcCAxNCwgMjAxOCBhdCAxMjoxMDo0M1BNICswMzAwLCBMYXVy ZW50IFBpbmNoYXJ0IHdyb3RlOgo+ID4+Pj4+IFRoZSBSOEE3Nzk5MCAoRTMpIHBsYXRmb3JtIGhh cyBvbmUgUkdCIG91dHB1dCBhbmQgdHdvIExWRFMgb3V0cHV0cwo+ID4+Pj4+IGNvbm5lY3RlZCB0 byB0aGUgRFUuIEFkZCB0aGUgRFQgbm9kZXMgZm9yIHRoZSBEVSwgTFZEUyBlbmNvZGVycwo+ID4+ Pj4+IGFuZCBzdXBwb3J0aW5nIFZTUCBhbmQgRkNQLgo+ID4+Pj4+IAo+ID4+Pj4+IFNpZ25lZC1v ZmYtYnk6IExhdXJlbnQgUGluY2hhcnQKPiA+Pj4+PiA8bGF1cmVudC5waW5jaGFydCtyZW5lc2Fz QGlkZWFzb25ib2FyZC5jb20+Cj4gPj4+Pj4gVGVzdGVkLWJ5OiBKYWNvcG8gTW9uZGkgPGphY29w bytyZW5lc2FzQGptb25kaS5vcmc+Cj4gPj4+Pj4gLS0tCj4gPj4+Pj4gCj4gPj4+Pj4gIGFyY2gv YXJtNjQvYm9vdC9kdHMvcmVuZXNhcy9yOGE3Nzk5MC5kdHNpIHwgMTY3ICsrKysrKysrKysrKysr KysrCj4gPj4+Pj4gIDEgZmlsZSBjaGFuZ2VkLCAxNjcgaW5zZXJ0aW9ucygrKQo+ID4+Pj4+IAo+ ID4+Pj4+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2Jvb3QvZHRzL3JlbmVzYXMvcjhhNzc5OTAu ZHRzaQo+ID4+Pj4+IGIvYXJjaC9hcm02NC9ib290L2R0cy9yZW5lc2FzL3I4YTc3OTkwLmR0c2kg aW5kZXgKPiA+Pj4+PiBhYmIxNGFmNzZjMGUuLjYwMDA3NGNhM2VlNSAxMDA2NDQKPiA+Pj4+PiAt LS0gYS9hcmNoL2FybTY0L2Jvb3QvZHRzL3JlbmVzYXMvcjhhNzc5OTAuZHRzaQo+ID4+Pj4+ICsr KyBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvcmVuZXNhcy9yOGE3Nzk5MC5kdHNpCj4gPj4+Pj4gQEAg LTUzNyw2ICs1MzcsMTczIEBACj4gPj4+Pj4gICAgICAgICAgICAgICAgICAgICAgICAgcmVzZXRz ID0gPCZjcGcgNDA4PjsKPiA+Pj4+PiAgICAgICAgICAgICAgICAgfTsKPiA+Pj4+IAo+ID4+Pj4g VGhlc2Ugbm9kZXMgc2hvdWxkIGJlIHBsYWNlZCBhZnRlciB0aGUgZ2ljIHRvIHByZXNlcnZlIHRo ZSBzb3J0aW5nCj4gPj4+PiBvZiBub2RlcyBieSBidXMgYWRkcmVzcyBhbmQgdGhlbiBJUCBibG9j ay4KPiA+Pj4gCj4gPj4+IEFyZW4ndCB0aGV5IGFscmVhZHkgPyA6LSkKPiA+PiAKPiA+PiBHaXQg ZGlkbid0IHNlZW0gdG8gdGhpbmsgc28uIEJ1dCBpdHMgbm90IGEgYmlnIGRlYWwsCj4gPj4gSSBj YW4gZml4IHRoaXMgdXAgbG9jYWxseS4KPiA+IAo+ID4gRGlkIGl0IGFwcGx5IHRoZSBiZWxvdyBo dW5rIHRvIGEgZGlmZmVyZW50IGxvY2F0aW9uID8gNDA4IGlzIHRoZSBnaWMsCj4gPiBpc24ndCBp dCA/Cj4gCj4gVGhlICItVSA8bj4iIG9wdGlvbiAod2l0aCA8bj4gc3VmZmljaWVudGx5IGxhcmdl KSBvZiAiZ2l0IGRpZmYiIGFuZCAiZ2l0Cj4gc2hvdyIgaXMgYSBncmVhdCBoZWxwIGZvciBpbnNw ZWN0aW5nIERUIGNoYW5nZXMuCgpJIGtub3cuIFRoaXMgaXMgd2hhdCBJIGhhdmUgaW4gbXkgdHJl ZToKCmRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2Jvb3QvZHRzL3JlbmVzYXMvcjhhNzc5OTAuZHRz aSBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvCnJlbmVzYXMvcjhhNzc5OTAuZHRzaQppbmRleCBhYmIx NGFmNzZjMGUuLjkzNWJiMzEzZDI5ZiAxMDA2NDQKLS0tIGEvYXJjaC9hcm02NC9ib290L2R0cy9y ZW5lc2FzL3I4YTc3OTkwLmR0c2kKKysrIGIvYXJjaC9hcm02NC9ib290L2R0cy9yZW5lc2FzL3I4 YTc3OTkwLmR0c2kKQEAgLTUyMiwzMiArNTIyLDE5OSBAQAogCiAJCWdpYzogaW50ZXJydXB0LWNv bnRyb2xsZXJAZjEwMTAwMDAgewogCQkJY29tcGF0aWJsZSA9ICJhcm0sZ2ljLTQwMCI7CiAJCQkj aW50ZXJydXB0LWNlbGxzID0gPDM+OwogCQkJI2FkZHJlc3MtY2VsbHMgPSA8MD47CiAJCQlpbnRl cnJ1cHQtY29udHJvbGxlcjsKIAkJCXJlZyA9IDwweDAgMHhmMTAxMDAwMCAwIDB4MTAwMD4sCiAJ CQkgICAgICA8MHgwIDB4ZjEwMjAwMDAgMCAweDIwMDAwPiwKIAkJCSAgICAgIDwweDAgMHhmMTA0 MDAwMCAwIDB4MjAwMDA+LAogCQkJICAgICAgPDB4MCAweGYxMDYwMDAwIDAgMHgyMDAwMD47CiAJ CQlpbnRlcnJ1cHRzID0gPEdJQ19QUEkgOQogCQkJCQkoR0lDX0NQVV9NQVNLX1NJTVBMRSgyKSB8 IElSUV9UWVBFX0xFVkVMX0hJR0gpPjsKIAkJCWNsb2NrcyA9IDwmY3BnIENQR19NT0QgNDA4PjsK IAkJCWNsb2NrLW5hbWVzID0gImNsayI7CiAJCQlwb3dlci1kb21haW5zID0gPCZzeXNjIDMyPjsK IAkJCXJlc2V0cyA9IDwmY3BnIDQwOD47CiAJCX07CiAKKwkJdnNwYjA6IHZzcEBmZTk2MDAwMCB7 CisJCQljb21wYXRpYmxlID0gInJlbmVzYXMsdnNwMiI7CisJCQlyZWcgPSA8MCAweGZlOTYwMDAw IDAgMHg4MDAwPjsKKwkJCWludGVycnVwdHMgPSA8R0lDX1NQSSAyNjYgSVJRX1RZUEVfTEVWRUxf SElHSD47CisJCQljbG9ja3MgPSA8JmNwZyBDUEdfTU9EIDYyNj47CisJCQlwb3dlci1kb21haW5z ID0gPCZzeXNjIFI4QTc3OTkwX1BEX0FMV0FZU19PTj47CisJCQlyZXNldHMgPSA8JmNwZyA2MjY+ OworCQkJcmVuZXNhcyxmY3AgPSA8JmZjcHZiMD47CisJCX07Cgpbc25pcF0KCnNvIEkgZG9uJ3Qg c2VlIHdoZXJlIHRoZSBwcm9ibGVtIHRoYXQgU2ltb24gcG9pbnRlZCBvdXQgaXMsIGVzcGVjaWFs bHkgZ2l2ZW4gCnRoYXQgSSB0b29rIGNhcmUgdG8gc29ydCBub2RlcyBvdXQgcHJvcGVybHkgdGhp cyB0aW1lLgoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgoKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QK ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=