All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] at91_udc.c: Fix unused variable warning
Date: Tue, 16 May 2017 05:19:02 +0200	[thread overview]
Message-ID: <591A6FA6.9070500@denx.de> (raw)
In-Reply-To: <1492568631-21900-1-git-send-email-trini@konsulko.com>

Hello Tom, Marek,

Am 19.04.2017 um 04:23 schrieb Tom Rini:
> With gcc-6 and later we see warnings that at91sam9263_udc_caps and
> at91rm9200_udc_caps are unused.
>
> Fixes: 620197670a69 ("usb: gadget: at91_udc: add at91_udc into U-Boot")
> Cc: Lukasz Majewski <lukma@denx.de>
> Cc: Marek Vasut <marex@denx.de>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
>   drivers/usb/gadget/at91_udc.c | 10 ----------
>   1 file changed, 10 deletions(-)

Acked-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
>
> diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb/gadget/at91_udc.c
> index f5bc277fa6e0..01a59078b84a 100644
> --- a/drivers/usb/gadget/at91_udc.c
> +++ b/drivers/usb/gadget/at91_udc.c
> @@ -1386,11 +1386,6 @@ static void at91rm9200_udc_pullup(struct at91_udc *udc, int is_on)
>   		gpio_set_value(udc->board.pullup_pin, !active);
>   }
>
> -static const struct at91_udc_caps at91rm9200_udc_caps = {
> -	.init = at91rm9200_udc_init,
> -	.pullup = at91rm9200_udc_pullup,
> -};
> -
>   static int at91sam9260_udc_init(struct at91_udc *udc)
>   {
>   	struct at91_ep *ep;
> @@ -1503,11 +1498,6 @@ static int at91sam9263_udc_init(struct at91_udc *udc)
>   	return 0;
>   }
>
> -static const struct at91_udc_caps at91sam9263_udc_caps = {
> -	.init = at91sam9263_udc_init,
> -	.pullup = at91sam9260_udc_pullup,
> -};
> -
>   int usb_gadget_handle_interrupts(int index)
>   {
>   	struct at91_udc *udc = controller;
>

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

      parent reply	other threads:[~2017-05-16  3:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-19  2:23 [U-Boot] [PATCH] at91_udc.c: Fix unused variable warning Tom Rini
2017-04-19  8:49 ` Marek Vasut
2017-05-16  3:19 ` Heiko Schocher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=591A6FA6.9070500@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.