All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 07/47] Kconfig: Drop CONFIG_SYS_I2C_DTT_ADDR
Date: Tue, 16 May 2017 05:31:41 +0200	[thread overview]
Message-ID: <591A729D.5020908@denx.de> (raw)
In-Reply-To: <20170515105802.23023-8-sjg@chromium.org>

Hello Simon,

Am 15.05.2017 um 12:57 schrieb Simon Glass:
> This option is only defined to a non-default value by canyonlands, which
> needs conversion to driver model (where the I2C address would be defined
> by the device tree).
>
> Drop this option.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
>   README                        | 6 ------
>   drivers/hwmon/ds1775.c        | 2 +-
>   drivers/hwmon/lm75.c          | 4 ----
>   include/configs/canyonlands.h | 4 ----
>   include/configs/kilauea.h     | 1 -
>   include/configs/makalu.h      | 1 -
>   scripts/config_whitelist.txt  | 1 -
>   7 files changed, 1 insertion(+), 18 deletions(-)

Reviewed-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
>
> diff --git a/README b/README
> index ace492edde..0e6ed53736 100644
> --- a/README
> +++ b/README
> @@ -2391,12 +2391,6 @@ The following options need to be configured:
>   		If defined, then this indicates the I2C bus number for the DTT.
>   		If not defined, then U-Boot assumes that DTT is on I2C bus 0.
>
> -		CONFIG_SYS_I2C_DTT_ADDR:
> -
> -		If defined, specifies the I2C address of the DTT device.
> -		If not defined, then U-Boot uses predefined value for
> -		specified DTT device.
> -
>   		CONFIG_SOFT_I2C_READ_REPEATED_START
>
>   		defining this will force the i2c_read() function in
> diff --git a/drivers/hwmon/ds1775.c b/drivers/hwmon/ds1775.c
> index b95b130d92..4c0c0b82a0 100644
> --- a/drivers/hwmon/ds1775.c
> +++ b/drivers/hwmon/ds1775.c
> @@ -11,7 +11,7 @@
>   #include <i2c.h>
>   #include <dtt.h>
>
> -#define DTT_I2C_DEV_CODE	CONFIG_SYS_I2C_DTT_ADDR /* Dallas Semi's DS1775 device code */
> +#define DTT_I2C_DEV_CODE	0x48 /* Dallas Semi's DS1775 device code */
>   #define DTT_READ_TEMP		0x0
>   #define DTT_CONFIG		0x1
>   #define DTT_TEMP_HYST		0x2
> diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c
> index 462f902dad..aafa4757b1 100644
> --- a/drivers/hwmon/lm75.c
> +++ b/drivers/hwmon/lm75.c
> @@ -16,11 +16,7 @@
>   /*
>    * Device code
>    */
> -#if defined(CONFIG_SYS_I2C_DTT_ADDR)
> -#define DTT_I2C_DEV_CODE CONFIG_SYS_I2C_DTT_ADDR
> -#else
>   #define DTT_I2C_DEV_CODE 0x48			/* ON Semi's LM75 device */
> -#endif
>   #define DTT_READ_TEMP		0x0
>   #define DTT_CONFIG		0x1
>   #define DTT_TEMP_HYST		0x2
> diff --git a/include/configs/canyonlands.h b/include/configs/canyonlands.h
> index a330372d19..ea440d6e16 100644
> --- a/include/configs/canyonlands.h
> +++ b/include/configs/canyonlands.h
> @@ -269,10 +269,6 @@
>   #define CONFIG_SYS_DTT_LOW_TEMP	-30
>   #define CONFIG_SYS_DTT_HYSTERESIS	3
>
> -#if defined(CONFIG_ARCHES)
> -#define CONFIG_SYS_I2C_DTT_ADDR	0x4a		/* AD7414 I2C address	*/
> -#endif
> -
>   #if !defined(CONFIG_ARCHES)
>   /* RTC configuration */
>   #define CONFIG_RTC_M41T62
> diff --git a/include/configs/kilauea.h b/include/configs/kilauea.h
> index 1f5c2ad234..b8c0d0d8f0 100644
> --- a/include/configs/kilauea.h
> +++ b/include/configs/kilauea.h
> @@ -320,7 +320,6 @@
>   /* Standard DTT sensor configuration */
>   #define CONFIG_DTT_DS1775	1
>   #define CONFIG_DTT_SENSORS	{ 0 }
> -#define CONFIG_SYS_I2C_DTT_ADDR	0x48
>
>   /* RTC configuration */
>   #define CONFIG_RTC_DS1338	1
> diff --git a/include/configs/makalu.h b/include/configs/makalu.h
> index da5cfa19d3..cdb02f3693 100644
> --- a/include/configs/makalu.h
> +++ b/include/configs/makalu.h
> @@ -192,7 +192,6 @@
>   /* Standard DTT sensor configuration */
>   #define CONFIG_DTT_DS1775	1
>   #define CONFIG_DTT_SENSORS	{ 0 }
> -#define CONFIG_SYS_I2C_DTT_ADDR	0x48
>
>   /* RTC configuration */
>   #define CONFIG_RTC_X1205	1
> diff --git a/scripts/config_whitelist.txt b/scripts/config_whitelist.txt
> index 85ab8f8933..e39fa2520e 100644
> --- a/scripts/config_whitelist.txt
> +++ b/scripts/config_whitelist.txt
> @@ -4232,7 +4232,6 @@ CONFIG_SYS_I2C_DSPIC_2_ADDR
>   CONFIG_SYS_I2C_DSPIC_ADDR
>   CONFIG_SYS_I2C_DSPIC_IO_ADDR
>   CONFIG_SYS_I2C_DSPIC_KEYB_ADDR
> -CONFIG_SYS_I2C_DTT_ADDR
>   CONFIG_SYS_I2C_DVI_ADDR
>   CONFIG_SYS_I2C_DVI_BUS_NUM
>   CONFIG_SYS_I2C_EARLY_INIT
>

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  parent reply	other threads:[~2017-05-16  3:31 UTC|newest]

Thread overview: 85+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-15 10:57 [U-Boot] [PATCH 00/47] Kconfig: Convert commands (D to L) to Kconfig Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 01/47] configs: Re-sync Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 02/47] Kconfig: Drop CONFIG_CMD_DS4510_INFO Simon Glass
2017-05-15 16:33   ` Tom Rini
2017-05-16  3:29   ` Heiko Schocher
2017-05-15 10:57 ` [U-Boot] [PATCH 03/47] Kconfig: Drop CONFIG_CMD_DS4510_MEM Simon Glass
2017-05-15 16:33   ` Tom Rini
2017-05-16  3:30   ` Heiko Schocher
2017-05-15 10:57 ` [U-Boot] [PATCH 04/47] Kconfig: Drop CONFIG_CMD_DS4510_RST Simon Glass
2017-05-15 16:33   ` Tom Rini
2017-05-16  3:30   ` Heiko Schocher
2017-05-15 10:57 ` [U-Boot] [PATCH 05/47] Kconfig: Drop CONFIG_CMD_DS4510 Simon Glass
2017-05-15 16:33   ` Tom Rini
2017-05-16  3:30   ` Heiko Schocher
2017-05-15 10:57 ` [U-Boot] [PATCH 06/47] Convert CONFIG_DS4510 to Kconfig Simon Glass
2017-05-15 16:33   ` Tom Rini
2017-05-16  3:31   ` Heiko Schocher
2017-05-15 10:57 ` [U-Boot] [PATCH 07/47] Kconfig: Drop CONFIG_SYS_I2C_DTT_ADDR Simon Glass
2017-05-15 16:33   ` Tom Rini
2017-05-16  3:31   ` Heiko Schocher [this message]
2017-05-15 10:57 ` [U-Boot] [PATCH 08/47] Drop three-wire serial (TWS) support Simon Glass
2017-05-15 16:32   ` Tom Rini
2017-05-15 17:13     ` Anatolij Gustschin
2017-05-15 10:57 ` [U-Boot] [PATCH 09/47] Drop digital thermometer and thermostat (DTT) drivers Simon Glass
2017-05-15 16:59   ` Tom Rini
2017-05-16  0:17     ` Simon Glass
2017-05-16  3:32   ` Heiko Schocher
2017-05-15 10:57 ` [U-Boot] [PATCH 10/47] Kconfig: Drop CONFIG_SYS_I2C_DS1621_ADDR Simon Glass
2017-05-16  3:32   ` Heiko Schocher
2017-05-15 10:57 ` [U-Boot] [PATCH 11/47] Kconfig: Drop CONFIG_SYS_I2C_DS4510_ADDR Simon Glass
2017-05-15 18:04   ` Tom Rini
2017-05-16  3:32   ` Heiko Schocher
2017-05-15 10:57 ` [U-Boot] [PATCH 12/47] Convert CONFIG_CMD_ECCTEST to Kconfig Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 13/47] Convert CONFIG_CMD_EECONFIG " Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 14/47] Convert CONFIG_CMD_EEPROM et al " Simon Glass
2017-05-15 18:04   ` Tom Rini
2017-05-16  0:18     ` Simon Glass
2017-05-16  0:54       ` Tom Rini
2017-05-15 10:57 ` [U-Boot] [PATCH 15/47] Convert CONFIG_CMD_ENTERRCM " Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 16/47] Convert CONFIG_CMD_ENV " Simon Glass
2017-05-15 18:04   ` Tom Rini
2017-05-15 10:57 ` [U-Boot] [PATCH 17/47] Convert CONFIG_CMD_ENV_CALLBACK " Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 18/47] Convert CONFIG_CMD_ENV_FLAGS " Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 19/47] Convert CONFIG_CMD_ERRATA " Simon Glass
2017-05-15 18:04   ` Tom Rini
2017-05-15 10:57 ` [U-Boot] [PATCH 20/47] Convert CONFIG_CMD_ESBC_VALIDATE " Simon Glass
2017-05-15 18:04   ` Tom Rini
2017-05-15 10:57 ` [U-Boot] [PATCH 21/47] Convert CONFIG_CMD_ETHSW " Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 22/47] Convert CONFIG_CMD_FDC " Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 23/47] Kconfig: Drop CONFIG_CMD_FDT_MAX_DUMP Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 24/47] Convert CONFIG_CMD_FPGAD to Kconfig Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 25/47] Convert CONFIG_CMD_FPGA_LOADBP et al " Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 26/47] Convert CONFIG_CMD_FUSE " Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 27/47] Convert CONFIG_CMD_GETTIME " Simon Glass
2017-05-15 18:04   ` Tom Rini
2017-05-15 10:57 ` [U-Boot] [PATCH 28/47] Convert CONFIG_CMD_GSC " Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 29/47] Convert CONFIG_CMD_HASH " Simon Glass
2017-05-15 18:04   ` Tom Rini
2017-05-17  1:34     ` Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 30/47] Kconfig: Add CONFIG_HASH to enable hashing API Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 31/47] Convert CONFIG_CMD_HD44760 to Kconfig Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 32/47] Convert CONFIG_CMD_HDMIDETECT " Simon Glass
2017-05-15 18:04   ` Tom Rini
2017-05-16  0:18     ` Simon Glass
2017-05-16  0:48       ` Tom Rini
2017-05-15 10:57 ` [U-Boot] [PATCH 33/47] Convert CONFIG_CMD_IDE " Simon Glass
2017-05-15 18:04   ` Tom Rini
2017-05-16  0:18     ` Simon Glass
2017-05-16  0:45       ` Tom Rini
2017-05-15 10:57 ` [U-Boot] [PATCH 34/47] Kconfig: Add a CONFIG_IDE option Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 35/47] Convert CONFIG_CMD_IMMAP to Kconfig Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 36/47] Kconfig: Drop CONFIG_CMD_IMXOTP Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 37/47] Kconfig: Drop CONFIG_CMD_IMX_FUSE Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 38/47] Convert CONFIG_CMD_IO to Kconfig Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 39/47] Convert CONFIG_CMD_IOLOOP " Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 40/47] Convert CONFIG_CMD_IOTRACE " Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 41/47] Convert CONFIG_CMD_JFFS2 " Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 42/47] fs: Kconfig: Add a separate option for FS_JFFS2 Simon Glass
2017-05-15 10:57 ` [U-Boot] [PATCH 43/47] Convert CONFIG_CMD_IRQ to Kconfig Simon Glass
2017-05-15 18:05   ` Tom Rini
2017-05-16 11:24   ` Daniel Schwierzeck
2017-05-15 10:57 ` [U-Boot] [PATCH 44/47] Convert CONFIG_CMD_KGDB " Simon Glass
2017-05-15 10:58 ` [U-Boot] [PATCH 45/47] Kconfig: Drop CONFIG_CMD_LOADY Simon Glass
2017-05-15 10:58 ` [U-Boot] [PATCH 46/47] Convert CONFIG_LZMA to Kconfig Simon Glass
2017-05-15 10:58 ` [U-Boot] [PATCH 47/47] Convert CONFIG_CMD_LZMADEC " Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=591A729D.5020908@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.