From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: fstests <fstests@vger.kernel.org>, Eryu Guan <eguan@redhat.com>
Subject: Re: [PATCH 1/2] common: use _require_xfs_io_command() directly to check fiemap
Date: Wed, 17 May 2017 09:10:09 +0800 [thread overview]
Message-ID: <591BA2F1.1010208@cn.fujitsu.com> (raw)
In-Reply-To: <CAOQ4uxjA05XO6xfG1AkpF69LkkQM-y5FrKia0pU-ztx8DaPgsw@mail.gmail.com>
On 2017/05/16 16:16, Amir Goldstein wrote:
> On Mon, May 15, 2017 at 10:17 AM, Xiao Yang<yangx.jy@cn.fujitsu.com> wrote:
>> We could remove _require_fiemap and _require_fiemap_attr.
>>
> We COULD remove it but why SHOULD we?
>
>
Hi Amir
Sorry for my lack of explanation, this is just a cleanup for growing
unnecessary helper.
_require_fiemap and _require_xfs_io_command "fiemap" do the same thing, but i find that
some test cases use the former and some use the latter, i feel they shoud be unified.
Moreover, the number of helpers like this is slowly growing, but it's easy to simply use
_require_xfs_io_command directly and just specify the command we want to check.
If it is acceptable, then i will rewrite the commit message and send a v2.
Thanks,
Xiao Yang
prev parent reply other threads:[~2017-05-17 1:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 7:17 [PATCH 1/2] common: use _require_xfs_io_command() directly to check fiemap Xiao Yang
2017-05-15 7:17 ` [PATCH 2/2] common: cleanup _require_xfs_io_command Xiao Yang
2017-05-16 8:04 ` Eryu Guan
2017-05-16 8:13 ` Xiao Yang
2017-05-17 1:42 ` [PATCH v2 1/2] common: use _require_xfs_io_command() directly to check fiemap Xiao Yang
2017-05-17 1:42 ` [PATCH v2 2/2] common: cleanup _require_xfs_io_command Xiao Yang
2017-05-16 8:16 ` [PATCH 1/2] common: use _require_xfs_io_command() directly to check fiemap Amir Goldstein
2017-05-17 1:10 ` Xiao Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=591BA2F1.1010208@cn.fujitsu.com \
--to=yangx.jy@cn.fujitsu.com \
--cc=amir73il@gmail.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.